Re: [PATCH][next][V2] media: vivid: fix potential integer overflow on left shift

2019-06-27 Thread Hans Verkuil
On 6/26/19 4:47 PM, Colin King wrote: > From: Colin Ian King > > There is a potential integer overflow when int 2 is left shifted > as this is evaluated using 32 bit arithmetic but is being used in > a context that expects an expression of type s64. Fix this by > shifting 2ULL to avoid a 32 bit

Re: [PATCH][next][V2] media: vivid: fix potential integer overflow on left shift

2019-06-27 Thread walter harms
Am 26.06.2019 16:47, schrieb Colin King: > From: Colin Ian King > > There is a potential integer overflow when int 2 is left shifted > as this is evaluated using 32 bit arithmetic but is being used in > a context that expects an expression of type s64. Fix this by > shifting 2ULL to avoid a

[PATCH][next][V2] media: vivid: fix potential integer overflow on left shift

2019-06-26 Thread Colin King
From: Colin Ian King There is a potential integer overflow when int 2 is left shifted as this is evaluated using 32 bit arithmetic but is being used in a context that expects an expression of type s64. Fix this by shifting 2ULL to avoid a 32 bit overflow. Addresses-Coverity: ("Unintentional