Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

2007-12-20 Thread Grant Likely
On 12/20/07, Andy Whitcroft <[EMAIL PROTECTED]> wrote: > On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote: > > > + /* Make the sysace device 'live' */ > > + if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA); > > + add_disk(ace->gd); > >

Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

2007-12-20 Thread Andy Whitcroft
On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote: > + /* Make the sysace device 'live' */ > + if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA); > + add_disk(ace->gd); checkpatch.pl reports the above if as suspect due to the trailing ;.

Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

2007-12-20 Thread Andy Whitcroft
On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote: + /* Make the sysace device 'live' */ + if (ace-fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA); + add_disk(ace-gd); checkpatch.pl reports the above if as suspect due to the trailing ;.

Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

2007-12-20 Thread Grant Likely
On 12/20/07, Andy Whitcroft [EMAIL PROTECTED] wrote: On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote: + /* Make the sysace device 'live' */ + if (ace-fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA); + add_disk(ace-gd); checkpatch.pl

Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

2007-12-19 Thread Grant Likely
On 12/19/07, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > Please review and comment. This patch works in my setup, but I haven't > tested exhaustively yet. I also need to fixup the documentation to > reflect new states before I request this patch to be

[PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

2007-12-19 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Please review and comment. This patch works in my setup, but I haven't tested exhaustively yet. I also need to fixup the documentation to reflect new states before I request this patch to be merged. Question for the block layer experts: I'm using

[PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

2007-12-19 Thread Grant Likely
From: Grant Likely [EMAIL PROTECTED] Please review and comment. This patch works in my setup, but I haven't tested exhaustively yet. I also need to fixup the documentation to reflect new states before I request this patch to be merged. Question for the block layer experts: I'm using

Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

2007-12-19 Thread Grant Likely
On 12/19/07, Grant Likely [EMAIL PROTECTED] wrote: From: Grant Likely [EMAIL PROTECTED] Please review and comment. This patch works in my setup, but I haven't tested exhaustively yet. I also need to fixup the documentation to reflect new states before I request this patch to be merged.