Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-13 Thread Geert Uytterhoeven
Hi Andrew, On Tue, Jan 5, 2021 at 3:10 PM Andrew Lunn wrote: > > I added a statically-linked ethtool binary to my initramfs, and can > > confirm that retrieving the PHY statistics does not access the PHY > > registers when the device is suspended: > > > > # ethtool --phy-statistics eth0 > >

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-05 Thread Andrew Lunn
> I added a statically-linked ethtool binary to my initramfs, and can > confirm that retrieving the PHY statistics does not access the PHY > registers when the device is suspended: > > # ethtool --phy-statistics eth0 > no stats available > # ifconfig eth0 up > # ethtool

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-05 Thread Geert Uytterhoeven
Hi Ioana, Andrew, On Mon, 4 Jan 2021, Ioana Ciornei wrote: On Mon, Jan 04, 2021 at 06:31:05PM +0100, Andrew Lunn wrote: The basic rules here should be, if the MDIO bus is registered, it is usable. There are things like PHY statistics, HWMON temperature sensors, etc, DSA switches, all

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Florian Fainelli
On 1/4/21 10:43 AM, Ioana Ciornei wrote: > On Mon, Jan 04, 2021 at 06:31:05PM +0100, Andrew Lunn wrote: >>> The basic rules here should be, if the MDIO bus is registered, it is >>> usable. There are things like PHY statistics, HWMON temperature >>> sensors, etc, DSA switches, all which have a life

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Ioana Ciornei
On Mon, Jan 04, 2021 at 06:31:05PM +0100, Andrew Lunn wrote: > > The basic rules here should be, if the MDIO bus is registered, it is > > usable. There are things like PHY statistics, HWMON temperature > > sensors, etc, DSA switches, all which have a life cycle separate to > > the interface being

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Andrew Lunn
> The basic rules here should be, if the MDIO bus is registered, it is > usable. There are things like PHY statistics, HWMON temperature > sensors, etc, DSA switches, all which have a life cycle separate to > the interface being up. [Goes and looks at the code] Yes, this is runtime PM which is

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Andrew Lunn
> Ok, so this does not have anything to do with interrupts explicitly but > rather with the fact that any PHY access will cause a crash when the > sh_eth device is powered down. > > If the device is powered-down before the actual .ndo_open() how is the > probe actually setting up the device? Or

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Ioana Ciornei
On Mon, Jan 04, 2021 at 04:11:02PM +0100, Geert Uytterhoeven wrote: > Hi Ioana, > > On Mon, Jan 4, 2021 at 3:53 PM Ioana Ciornei wrote: > > On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote: > > > Wolfram reports that his R-Car H2-based Lager board can no longer be > > >

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Geert Uytterhoeven
Hi Ioana, On Mon, Jan 4, 2021 at 3:53 PM Ioana Ciornei wrote: > On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote: > > Wolfram reports that his R-Car H2-based Lager board can no longer be > > rebooted in v5.11-rc1, as it crashes with an imprecise external abort. > > The issue

Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Ioana Ciornei
Hi Geert, On Mon, Jan 04, 2021 at 01:24:15PM +0100, Geert Uytterhoeven wrote: > Wolfram reports that his R-Car H2-based Lager board can no longer be > rebooted in v5.11-rc1, as it crashes with an imprecise external abort. > The issue can be reproduced on other boards (e.g. Koelsch with R-Car >

[PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set

2021-01-04 Thread Geert Uytterhoeven
Wolfram reports that his R-Car H2-based Lager board can no longer be rebooted in v5.11-rc1, as it crashes with an imprecise external abort. The issue can be reproduced on other boards (e.g. Koelsch with R-Car M2-W) too, if CONFIG_IP_PNP is disabled: Unhandled fault: imprecise external abort