Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 4/3/2017 3:12 PM, Joao Pinto wrote: Yes older cores do not support multiple queues and I tried to isolate the features not to affect older versions. ok so we are inline ;-) Do you think that functions as "ndev = alloc_etherdev_mqs" has some sort of influence? I do not think

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 4/3/2017 3:12 PM, Joao Pinto wrote: Yes older cores do not support multiple queues and I tried to isolate the features not to affect older versions. ok so we are inline ;-) Do you think that functions as "ndev = alloc_etherdev_mqs" has some sort of influence? I do not think

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Peppe, Às 2:07 PM de 4/3/2017, Giuseppe CAVALLARO escreveu: > Hello Joao > > On 3/30/2017 6:42 PM, Joao Pinto wrote: >> Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: >>> On 03/30/2017 04:34 PM, Thierry Reding wrote: On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote:

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Peppe, Às 2:07 PM de 4/3/2017, Giuseppe CAVALLARO escreveu: > Hello Joao > > On 3/30/2017 6:42 PM, Joao Pinto wrote: >> Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: >>> On 03/30/2017 04:34 PM, Thierry Reding wrote: On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote:

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 3/30/2017 6:42 PM, Joao Pinto wrote: Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: On 03/30/2017 04:34 PM, Thierry Reding wrote: On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 3/30/2017 6:42 PM, Joao Pinto wrote: Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: On 03/30/2017 04:34 PM, Thierry Reding wrote: On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 5:57 PM de 3/31/2017, David Miller escreveu: > From: Joao Pinto > Date: Fri, 31 Mar 2017 11:43:38 +0100 > >> @David: Could you please create a branch in your git tree for us to work on >> it >> until the multiple buffers get stable for everyone? This way the patches

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 5:57 PM de 3/31/2017, David Miller escreveu: > From: Joao Pinto > Date: Fri, 31 Mar 2017 11:43:38 +0100 > >> @David: Could you please create a branch in your git tree for us to work on >> it >> until the multiple buffers get stable for everyone? This way the patches >> could >> circulate in

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

From: Joao Pinto Date: Fri, 31 Mar 2017 11:43:38 +0100 > @David: Could you please create a branch in your git tree for us to work on it > until the multiple buffers get stable for everyone? This way the patches could > circulate in the mailing-list with a different

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

From: Joao Pinto Date: Fri, 31 Mar 2017 11:43:38 +0100 > @David: Could you please create a branch in your git tree for us to work on it > until the multiple buffers get stable for everyone? This way the patches could > circulate in the mailing-list with a different target, like stmmac-next or >

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 11:14 AM de 3/31/2017, Joao Pinto escreveu: > Às 6:48 PM de 3/30/2017, David Miller escreveu: >> From: Thierry Reding >> Date: Thu, 30 Mar 2017 16:34:36 +0200 >> >>> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: On Tue, Mar 28, 2017 at 06:01:05PM

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 11:14 AM de 3/31/2017, Joao Pinto escreveu: > Às 6:48 PM de 3/30/2017, David Miller escreveu: >> From: Thierry Reding >> Date: Thu, 30 Mar 2017 16:34:36 +0200 >> >>> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 6:48 PM de 3/30/2017, David Miller escreveu: > From: Thierry Reding > Date: Thu, 30 Mar 2017 16:34:36 +0200 > >> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >>> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 6:48 PM de 3/30/2017, David Miller escreveu: > From: Thierry Reding > Date: Thu, 30 Mar 2017 16:34:36 +0200 > >> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >>> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann Date: Tue, 28 Mar

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

From: Thierry Reding Date: Thu, 30 Mar 2017 16:34:36 +0200 > On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: >> > From: Arnd Bergmann >> > Date: Tue, 28 Mar 2017 11:48:21 +0200 >>

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

From: Thierry Reding Date: Thu, 30 Mar 2017 16:34:36 +0200 > On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: >> > From: Arnd Bergmann >> > Date: Tue, 28 Mar 2017 11:48:21 +0200 >> > >> > > A driver must not access

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: > On 03/30/2017 04:34 PM, Thierry Reding wrote: >> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >>> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann Date: Tue, 28 Mar 2017

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: > On 03/30/2017 04:34 PM, Thierry Reding wrote: >> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >>> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann Date: Tue, 28 Mar 2017 11:48:21 +0200

Re: Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

On 03/30/2017 04:34 PM, Thierry Reding wrote: > On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: >>> From: Arnd Bergmann >>> Date: Tue, 28 Mar 2017 11:48:21 +0200 >>> A driver must not access the

Re: Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

On 03/30/2017 04:34 PM, Thierry Reding wrote: > On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: >>> From: Arnd Bergmann >>> Date: Tue, 28 Mar 2017 11:48:21 +0200 >>> A driver must not access the two fields

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: > On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: > > From: Arnd Bergmann > > Date: Tue, 28 Mar 2017 11:48:21 +0200 > > > > > A driver must not access the two fields directly but should instead use > > >

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: > On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: > > From: Arnd Bergmann > > Date: Tue, 28 Mar 2017 11:48:21 +0200 > > > > > A driver must not access the two fields directly but should instead use > > > the helper

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: > From: Arnd Bergmann > Date: Tue, 28 Mar 2017 11:48:21 +0200 > > > A driver must not access the two fields directly but should instead use > > the helper functions to set the values and keep a consistent internal > >

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: > From: Arnd Bergmann > Date: Tue, 28 Mar 2017 11:48:21 +0200 > > > A driver must not access the two fields directly but should instead use > > the helper functions to set the values and keep a consistent internal > > state: > > > >

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

From: Arnd Bergmann Date: Tue, 28 Mar 2017 11:48:21 +0200 > A driver must not access the two fields directly but should instead use > the helper functions to set the values and keep a consistent internal > state: > > ethernet/stmicro/stmmac/stmmac_main.c: In function

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

From: Arnd Bergmann Date: Tue, 28 Mar 2017 11:48:21 +0200 > A driver must not access the two fields directly but should instead use > the helper functions to set the values and keep a consistent internal > state: > > ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe': >

[PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

A driver must not access the two fields directly but should instead use the helper functions to set the values and keep a consistent internal state: ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe': ethernet/stmicro/stmmac/stmmac_main.c:4083:8: error: 'struct net_device' has

[PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

A driver must not access the two fields directly but should instead use the helper functions to set the values and keep a consistent internal state: ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe': ethernet/stmicro/stmmac/stmmac_main.c:4083:8: error: 'struct net_device' has