Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-17 Thread Jeff Garzik
Boaz Harrosh wrote: On Sat, Feb 16 2008 at 18:37 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote: On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote: I still don't have a card for testing myself. Again anyone wants to send me a card. Intel people anybody home? Apparently Intel sold

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-17 Thread Boaz Harrosh
On Sat, Feb 16 2008 at 18:37 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote: >> I still don't have a card for testing myself. Again anyone >> wants to send me a card. Intel people anybody home? > > Apparently Intel sold this line of

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-17 Thread Boaz Harrosh
On Sat, Feb 16 2008 at 18:37 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote: I still don't have a card for testing myself. Again anyone wants to send me a card. Intel people anybody home? Apparently Intel sold this line of cards to

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-17 Thread Jeff Garzik
Boaz Harrosh wrote: On Sat, Feb 16 2008 at 18:37 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote: I still don't have a card for testing myself. Again anyone wants to send me a card. Intel people anybody home? Apparently Intel sold

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-16 Thread Matthew Wilcox
On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote: > I still don't have a card for testing myself. Again anyone > wants to send me a card. Intel people anybody home? Apparently Intel sold this line of cards to Adaptec. The copyright notice in the file backs this up: * Copyright (C)

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-16 Thread Matthew Wilcox
On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote: I still don't have a card for testing myself. Again anyone wants to send me a card. Intel people anybody home? Apparently Intel sold this line of cards to Adaptec. The copyright notice in the file backs this up: * Copyright (C)

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-13 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 2:17 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote: >> reposting an updated version of it. Please check if it's ok. > > Looks fine, thanks! You added an extra space at the end of > > while ((pdev =

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-13 Thread Boaz Harrosh
On Wed, Feb 13 2008 at 2:17 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote: reposting an updated version of it. Please check if it's ok. Looks fine, thanks! You added an extra space at the end of while ((pdev = pci_get_device(vendor,

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote: > reposting an updated version of it. Please check if it's ok. Looks fine, thanks! You added an extra space at the end of while ((pdev = pci_get_device(vendor, device, pdev)) Which I fixed. Unfortunately checkpatch isn't very helpful for

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread Boaz Harrosh
On Tue, Feb 12 2008 at 18:22 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-12 at 11:31 -0300, Sergio Luis wrote: >> Fix compilation warning in drivers/scsi/gdth.c, using deprecated >> pci_find_device. >> Change it into using pci_get_device instead: >>

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 11:31 -0300, Sergio Luis wrote: > Fix compilation warning in drivers/scsi/gdth.c, using deprecated > pci_find_device. > Change it into using pci_get_device instead: > drivers/scsi/gdth.c:645: warning: 'pci_find_device' is deprecated (declared > at include/linux/pci.h:495)

[PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread Sergio Luis
Fix compilation warning in drivers/scsi/gdth.c, using deprecated pci_find_device. Change it into using pci_get_device instead: drivers/scsi/gdth.c:645: warning: 'pci_find_device' is deprecated (declared at include/linux/pci.h:495) Signed-off-by: Sergio Luis <[EMAIL PROTECTED]> gdth.c |2

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote: reposting an updated version of it. Please check if it's ok. Looks fine, thanks! You added an extra space at the end of while ((pdev = pci_get_device(vendor, device, pdev)) Which I fixed. Unfortunately checkpatch isn't very helpful for

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread Boaz Harrosh
On Tue, Feb 12 2008 at 18:22 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 11:31 -0300, Sergio Luis wrote: Fix compilation warning in drivers/scsi/gdth.c, using deprecated pci_find_device. Change it into using pci_get_device instead: drivers/scsi/gdth.c:645: warning:

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread James Bottomley
On Tue, 2008-02-12 at 11:31 -0300, Sergio Luis wrote: Fix compilation warning in drivers/scsi/gdth.c, using deprecated pci_find_device. Change it into using pci_get_device instead: drivers/scsi/gdth.c:645: warning: 'pci_find_device' is deprecated (declared at include/linux/pci.h:495)

[PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-12 Thread Sergio Luis
Fix compilation warning in drivers/scsi/gdth.c, using deprecated pci_find_device. Change it into using pci_get_device instead: drivers/scsi/gdth.c:645: warning: 'pci_find_device' is deprecated (declared at include/linux/pci.h:495) Signed-off-by: Sergio Luis [EMAIL PROTECTED] gdth.c |2 +-