Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 09:07:49PM -0500, Jeff Garzik escreveu: > And here are the rest of the ones in pcmcia. Hey man, thats what I call cooperation 8) I was now on the netwave one, but had to stop to get another beer, when I came back... Jeff, go get a beer please, I'll pay you by March, 31,

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Jeff Garzik
And here are the rest of the ones in pcmcia. -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who dig. You dig." --Blondie Index: drivers/net/pcmcia/3c574_cs.c

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 08:56:06PM -0500, Jeff Garzik escreveu: > Arnaldo Carvalho de Melo wrote: > > --- linux-2.4.2/drivers/net/pcmcia/3c589_cs.c Tue Feb 13 19:15:05 2001 > > +++ linux-2.4.2.acme/drivers/net/pcmcia/3c589_cs.c Mon Feb 26 22:44:00 2001 > > @@ -992,9 +992,9 @@ > >

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Jeff Garzik
Arnaldo Carvalho de Melo wrote: > --- linux-2.4.2/drivers/net/pcmcia/3c589_cs.c Tue Feb 13 19:15:05 2001 > +++ linux-2.4.2.acme/drivers/net/pcmcia/3c589_cs.c Mon Feb 26 22:44:00 2001 > @@ -992,9 +992,9 @@ > (pkt_len+3)>>2); > skb->protocol =

[PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
now to pcmcia ones Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added to the

[PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
now to pcmcia ones Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu: Hi, I've just read davem's post at netdev about the brokeness of referencing skbs after passing it to netif_rx, so please consider applying this patch. Ah, this was just added to the

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Jeff Garzik
Arnaldo Carvalho de Melo wrote: --- linux-2.4.2/drivers/net/pcmcia/3c589_cs.c Tue Feb 13 19:15:05 2001 +++ linux-2.4.2.acme/drivers/net/pcmcia/3c589_cs.c Mon Feb 26 22:44:00 2001 @@ -992,9 +992,9 @@ (pkt_len+3)2); skb-protocol =

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 08:56:06PM -0500, Jeff Garzik escreveu: Arnaldo Carvalho de Melo wrote: --- linux-2.4.2/drivers/net/pcmcia/3c589_cs.c Tue Feb 13 19:15:05 2001 +++ linux-2.4.2.acme/drivers/net/pcmcia/3c589_cs.c Mon Feb 26 22:44:00 2001 @@ -992,9 +992,9 @@

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Jeff Garzik
And here are the rest of the ones in pcmcia. -- Jeff Garzik | "You see, in this world there's two kinds of Building 1024 | people, my friend: Those with loaded guns MandrakeSoft | and those who dig. You dig." --Blondie Index: drivers/net/pcmcia/3c574_cs.c

Re: [PATCH] 3c589_cs: don't reference skb after passing it to netif_rx

2001-02-26 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 26, 2001 at 09:07:49PM -0500, Jeff Garzik escreveu: And here are the rest of the ones in pcmcia. Hey man, thats what I call cooperation 8) I was now on the netwave one, but had to stop to get another beer, when I came back... Jeff, go get a beer please, I'll pay you by March, 31, if