Re: [PATCH] ADP1653 board code for Nokia RX-51

2013-03-30 Thread Pavel Machek
Hi! > +static int __init rx51_camera_hw_init(void) > +{ > + int rval; > + > + rval = rx51_adp1653_init(); > + if (rval) > + return rval; > + > + return 0; > +} "return rx51_adp1653_init()". Or better yet, rename rx51_adp1653_init to rx51_camera_hw_init. Thanks for

Re: [PATCH] ADP1653 board code for Nokia RX-51

2013-03-30 Thread Pavel Machek
Hi! +static int __init rx51_camera_hw_init(void) +{ + int rval; + + rval = rx51_adp1653_init(); + if (rval) + return rval; + + return 0; +} return rx51_adp1653_init(). Or better yet, rename rx51_adp1653_init to rx51_camera_hw_init. Thanks for all the n900

Re: [PATCH] ADP1653 board code for Nokia RX-51

2013-02-17 Thread Aaro Koskinen
Hi, On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: > I'm sending ADP1653 flash torch board code for Nokia RX-51. Kernel > driver ADP1653 is already in upstream kernel. Board code was extracted > from this big camera meego patch: > >

[PATCH] ADP1653 board code for Nokia RX-51

2013-02-17 Thread Pali Rohár
Hello, I'm sending ADP1653 flash torch board code for Nokia RX-51. Kernel driver ADP1653 is already in upstream kernel. Board code was extracted from this big camera meego patch:

[PATCH] ADP1653 board code for Nokia RX-51

2013-02-17 Thread Pali Rohár
Hello, I'm sending ADP1653 flash torch board code for Nokia RX-51. Kernel driver ADP1653 is already in upstream kernel. Board code was extracted from this big camera meego patch:

Re: [PATCH] ADP1653 board code for Nokia RX-51

2013-02-17 Thread Aaro Koskinen
Hi, On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: I'm sending ADP1653 flash torch board code for Nokia RX-51. Kernel driver ADP1653 is already in upstream kernel. Board code was extracted from this big camera meego patch: