Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-28 Thread Jason Cooper
On Sat, Mar 23, 2013 at 01:56:58PM +0100, Sebastian Hesselbarth wrote: > mvsdio_platform_data allows to pass card detect and write protect gpio > numbers to the driver. Some kirkwood boards don't use both pins as they > are not connected, and don't set the corresponding value in platform_data. >

Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-28 Thread Jason Cooper
On Sat, Mar 23, 2013 at 01:56:58PM +0100, Sebastian Hesselbarth wrote: mvsdio_platform_data allows to pass card detect and write protect gpio numbers to the driver. Some kirkwood boards don't use both pins as they are not connected, and don't set the corresponding value in platform_data.

Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Sebastian Hesselbarth
On 03/23/2013 05:30 PM, Thomas Petazzoni wrote: Dear Sebastian Hesselbarth, On Sat, 23 Mar 2013 16:25:54 +0100, Sebastian Hesselbarth wrote: I understand that you proposed patch fixes mvsdio grab mpp0 by accident. But what if you have a kirkwood board where cd-gpio _is_ connected to mpp0?

Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Sat, 23 Mar 2013 16:25:54 +0100, Sebastian Hesselbarth wrote: > I understand that you proposed patch fixes mvsdio grab mpp0 by accident. > But what if you have a kirkwood board where cd-gpio _is_ connected to mpp0? It didn't work with the existing mvsdio driver,

Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Sebastian Hesselbarth
On 03/23/2013 04:17 PM, Thomas Petazzoni wrote: On Sat, 23 Mar 2013 13:56:58 +0100, Sebastian Hesselbarth wrote: mvsdio_platform_data allows to pass card detect and write protect gpio numbers to the driver. Some kirkwood boards don't use both pins as they are not connected, and don't set the

Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Sat, 23 Mar 2013 13:56:58 +0100, Sebastian Hesselbarth wrote: > mvsdio_platform_data allows to pass card detect and write protect gpio > numbers to the driver. Some kirkwood boards don't use both pins as > they are not connected, and don't set the corresponding

[PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Sebastian Hesselbarth
mvsdio_platform_data allows to pass card detect and write protect gpio numbers to the driver. Some kirkwood boards don't use both pins as they are not connected, and don't set the corresponding value in platform_data. This will leave the unset values in platform_data initialized as 0, which is in

[PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Sebastian Hesselbarth
mvsdio_platform_data allows to pass card detect and write protect gpio numbers to the driver. Some kirkwood boards don't use both pins as they are not connected, and don't set the corresponding value in platform_data. This will leave the unset values in platform_data initialized as 0, which is in

Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Sat, 23 Mar 2013 13:56:58 +0100, Sebastian Hesselbarth wrote: mvsdio_platform_data allows to pass card detect and write protect gpio numbers to the driver. Some kirkwood boards don't use both pins as they are not connected, and don't set the corresponding value

Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Sebastian Hesselbarth
On 03/23/2013 04:17 PM, Thomas Petazzoni wrote: On Sat, 23 Mar 2013 13:56:58 +0100, Sebastian Hesselbarth wrote: mvsdio_platform_data allows to pass card detect and write protect gpio numbers to the driver. Some kirkwood boards don't use both pins as they are not connected, and don't set the

Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Sat, 23 Mar 2013 16:25:54 +0100, Sebastian Hesselbarth wrote: I understand that you proposed patch fixes mvsdio grab mpp0 by accident. But what if you have a kirkwood board where cd-gpio _is_ connected to mpp0? It didn't work with the existing mvsdio driver, so

Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins

2013-03-23 Thread Sebastian Hesselbarth
On 03/23/2013 05:30 PM, Thomas Petazzoni wrote: Dear Sebastian Hesselbarth, On Sat, 23 Mar 2013 16:25:54 +0100, Sebastian Hesselbarth wrote: I understand that you proposed patch fixes mvsdio grab mpp0 by accident. But what if you have a kirkwood board where cd-gpio _is_ connected to mpp0?