Re: [PATCH] ARM: avoid ARCH_MMAP_RND_BITS for NOMMU

2015-12-06 Thread Uwe Kleine-König
On Fri, Nov 27, 2015 at 03:04:03PM +0100, Arnd Bergmann wrote: > ARM kernels with MMU disabled fail to build because of > CONFIG_ARCH_MMAP_RND_BITS: > > kernel/built-in.o:(.data+0x754): undefined reference to `mmap_rnd_bits' > kernel/built-in.o:(.data+0x76c): undefined reference to

Re: [PATCH] ARM: avoid ARCH_MMAP_RND_BITS for NOMMU

2015-12-06 Thread Uwe Kleine-König
On Fri, Nov 27, 2015 at 03:04:03PM +0100, Arnd Bergmann wrote: > ARM kernels with MMU disabled fail to build because of > CONFIG_ARCH_MMAP_RND_BITS: > > kernel/built-in.o:(.data+0x754): undefined reference to `mmap_rnd_bits' > kernel/built-in.o:(.data+0x76c): undefined reference to

Re: [PATCH] ARM: avoid ARCH_MMAP_RND_BITS for NOMMU

2015-11-30 Thread Daniel Cashman
Thank you for this. I will add this to the recently posted patchset v4. Without CONFIG_MMU, arch_pick_mmap_layout() is a no-op and the arch/$ARCH/mm/mmap.c source is not included, so this change makes sense. In addition, we should drop the nommu default and add depends-on for the Kconfig

Re: [PATCH] ARM: avoid ARCH_MMAP_RND_BITS for NOMMU

2015-11-30 Thread Daniel Cashman
Thank you for this. I will add this to the recently posted patchset v4. Without CONFIG_MMU, arch_pick_mmap_layout() is a no-op and the arch/$ARCH/mm/mmap.c source is not included, so this change makes sense. In addition, we should drop the nommu default and add depends-on for the Kconfig

[PATCH] ARM: avoid ARCH_MMAP_RND_BITS for NOMMU

2015-11-27 Thread Arnd Bergmann
ARM kernels with MMU disabled fail to build because of CONFIG_ARCH_MMAP_RND_BITS: kernel/built-in.o:(.data+0x754): undefined reference to `mmap_rnd_bits' kernel/built-in.o:(.data+0x76c): undefined reference to `mmap_rnd_bits_min' kernel/built-in.o:(.data+0x770): undefined reference to

[PATCH] ARM: avoid ARCH_MMAP_RND_BITS for NOMMU

2015-11-27 Thread Arnd Bergmann
ARM kernels with MMU disabled fail to build because of CONFIG_ARCH_MMAP_RND_BITS: kernel/built-in.o:(.data+0x754): undefined reference to `mmap_rnd_bits' kernel/built-in.o:(.data+0x76c): undefined reference to `mmap_rnd_bits_min' kernel/built-in.o:(.data+0x770): undefined reference to