Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-04 Thread Linus Walleij
On Wed, Oct 3, 2018 at 1:49 PM Leonard Crestez wrote: > On Tue, 2018-10-02 at 21:56 +0200, Linus Walleij wrote: > > I guess I could hack to make "gpios" be ignored by the > > regulator GPIO quirks in gpiolib, but I take it you probably > > prefer to fix up the real issue like this. > > Maybe you

Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-04 Thread Linus Walleij
On Wed, Oct 3, 2018 at 1:49 PM Leonard Crestez wrote: > On Tue, 2018-10-02 at 21:56 +0200, Linus Walleij wrote: > > I guess I could hack to make "gpios" be ignored by the > > regulator GPIO quirks in gpiolib, but I take it you probably > > prefer to fix up the real issue like this. > > Maybe you

Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-03 Thread Leonard Crestez
On Tue, 2018-10-02 at 21:56 +0200, Linus Walleij wrote: > On Tue, Oct 2, 2018 at 8:37 PM Leonard Crestez < > leonard.cres...@nxp.com> wrote: > > > This issue was exposed by commit efdfeb079cc3 ("regulator: fixed: > > Convert to use GPIO descriptor only") which causes the "gpios" > > property > >

Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-03 Thread Leonard Crestez
On Tue, 2018-10-02 at 21:56 +0200, Linus Walleij wrote: > On Tue, Oct 2, 2018 at 8:37 PM Leonard Crestez < > leonard.cres...@nxp.com> wrote: > > > This issue was exposed by commit efdfeb079cc3 ("regulator: fixed: > > Convert to use GPIO descriptor only") which causes the "gpios" > > property > >

Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-02 Thread Fabio Estevam
Hi Leonard, On Tue, Oct 2, 2018 at 3:42 PM Leonard Crestez wrote: > @@ -371,10 +372,12 @@ > MX6SX_PAD_RGMII1_RD1__ENET1_RX_DATA_1 0x3081 > MX6SX_PAD_RGMII1_RD2__ENET1_RX_DATA_2 0x3081 >

Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-02 Thread Fabio Estevam
Hi Leonard, On Tue, Oct 2, 2018 at 3:42 PM Leonard Crestez wrote: > @@ -371,10 +372,12 @@ > MX6SX_PAD_RGMII1_RD1__ENET1_RX_DATA_1 0x3081 > MX6SX_PAD_RGMII1_RD2__ENET1_RX_DATA_2 0x3081 >

Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-02 Thread Linus Walleij
On Tue, Oct 2, 2018 at 8:37 PM Leonard Crestez wrote: > This issue was exposed by commit efdfeb079cc3 ("regulator: fixed: > Convert to use GPIO descriptor only") which causes the "gpios" property > to also be parsed. Before that commit the "gpios" property had no > effect and PHY reset was only

Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-02 Thread Linus Walleij
On Tue, Oct 2, 2018 at 8:37 PM Leonard Crestez wrote: > This issue was exposed by commit efdfeb079cc3 ("regulator: fixed: > Convert to use GPIO descriptor only") which causes the "gpios" property > to also be parsed. Before that commit the "gpios" property had no > effect and PHY reset was only

[PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-02 Thread Leonard Crestez
Bindings for "fixed-regulator" only explicitly support "gpio" property, not "gpios". Fix by correcting the property name. The enet PHYs on imx6sx-sdb needs to be explicitly reset after a power cycle, handle this by adding the phy-reset-gpios property. Both phys share a single reset, a scenario

[PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

2018-10-02 Thread Leonard Crestez
Bindings for "fixed-regulator" only explicitly support "gpio" property, not "gpios". Fix by correcting the property name. The enet PHYs on imx6sx-sdb needs to be explicitly reset after a power cycle, handle this by adding the phy-reset-gpios property. Both phys share a single reset, a scenario