Re: [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode

2020-09-02 Thread Shengjiu Wang
On Thu, Sep 3, 2020 at 11:42 AM Nicolin Chen wrote: > > On Thu, Sep 03, 2020 at 11:09:15AM +0800, Shengjiu Wang wrote: > > Transmit data pins will output zero when slots are masked or channels > > are disabled. In CHMOD TDM mode, transmit data pins are tri-stated when > > slots are masked or

Re: [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode

2020-09-02 Thread Nicolin Chen
On Thu, Sep 03, 2020 at 11:09:15AM +0800, Shengjiu Wang wrote: > Transmit data pins will output zero when slots are masked or channels > are disabled. In CHMOD TDM mode, transmit data pins are tri-stated when > slots are masked or channels are disabled. When data pins are tri-stated, > there is

[PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode

2020-09-02 Thread Shengjiu Wang
Transmit data pins will output zero when slots are masked or channels are disabled. In CHMOD TDM mode, transmit data pins are tri-stated when slots are masked or channels are disabled. When data pins are tri-stated, there is noise on some channels when FS clock value is high and data is read while

Re: [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode

2019-09-02 Thread Mark Brown
On Mon, Sep 02, 2019 at 04:35:56PM +0300, Daniel Baluta wrote: > On Mon, Sep 2, 2019 at 3:42 PM Mark Brown wrote: > > This patch seems to do this unconditionally. This is fine for > > configurations where the SoC is the only thing driving the bus but will > > mean that for TDM configurations

Re: [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode

2019-09-02 Thread Daniel Baluta
On Mon, Sep 2, 2019 at 3:42 PM Mark Brown wrote: > > On Sat, Aug 31, 2019 at 01:55:14AM +0300, Daniel Baluta wrote: > > > Fix this by setting CHMOD to Output Mode so that pins will output zero > > when slots are masked or channels are disabled. > > This patch seems to do this unconditionally.

Re: [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode

2019-09-02 Thread Mark Brown
On Sat, Aug 31, 2019 at 01:55:14AM +0300, Daniel Baluta wrote: > Fix this by setting CHMOD to Output Mode so that pins will output zero > when slots are masked or channels are disabled. This patch seems to do this unconditionally. This is fine for configurations where the SoC is the only thing

Re: [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode

2019-09-01 Thread Cosmin-Gabriel Samoila
Looks good to me! Best regards, Cosmin On Sat, 2019-08-31 at 01:55 +0300, Daniel Baluta wrote: > From SAI datasheet: > > CHMOD, configures if transmit data pins are configured for TDM mode > or Output mode. > * (0) TDM mode, transmit data pins are tri-stated when slots > are >

[PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode

2019-08-30 Thread Daniel Baluta
>From SAI datasheet: CHMOD, configures if transmit data pins are configured for TDM mode or Output mode. * (0) TDM mode, transmit data pins are tri-stated when slots are masked or channels are disabled. * (1) Output mode, transmit data pins are never tri-stated and