Greg KH wrote:
On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote:
+ if (hdr->id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >>
8, + (nic->pci_bdf & 0xff));
pci_get_bus_and_slot fails in
On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote:
> > > + if (hdr->id == id_nic) {
> > > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >>
> > > 8, + (nic->pci_bdf & 0xff));
> > pci_get_bus_and_slot fails in
> > + if (hdr->id == id_nic) {
> > + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >>
> > 8, + (nic->pci_bdf & 0xff));
> pci_get_bus_and_slot fails in the presence of PCI domains, which are
> getting to be fairly common even
On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote:
+ if (hdr-id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic-pci_bdf 0xff00)
8, + (nic-pci_bdf 0xff));
pci_get_bus_and_slot fails in the presence of
Greg KH wrote:
On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote:
+ if (hdr-id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic-pci_bdf 0xff00)
8, + (nic-pci_bdf 0xff));
pci_get_bus_and_slot fails in the
+ if (hdr-id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic-pci_bdf 0xff00)
8, + (nic-pci_bdf 0xff));
pci_get_bus_and_slot fails in the presence of PCI domains, which are
getting to be fairly common even in medium
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> + if (hdr->id == id_nic) {
> + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8,
> + (nic->pci_bdf & 0xff));
> + if (pci_dev) {
> +
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> + ibft_device = kmalloc(len, GFP_KERNEL);
> + if (!ibft_device)
> + return -ENOMEM;
> +
> + memcpy(ibft_device, hdr, len);
This piece looks a bit odd. you're making ibft_device an exact
duplicate of
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> +/*
> + * Physical location of iSCSI Boot Format Table.
This is now the Virtual address, isn't it? So just drop the Physical.
> + */
> +unsigned long ibft_addr;
> +EXPORT_SYMBOL(ibft_addr);
And since it is the virtual address,
Whoops. I've attached an incorrect patch in the previous
e-mail (http://lkml.org/lkml/2008/2/8/350) that didn't take
in to account the 'reserve_bootmem' parameters changes.
Here is fresher copy which has been tested on 2.6.24-git19
on a machine with iBFT and without.
This patch (v0.4.7) adds
On Friday 01 February 2008 19:18:09 James Bottomley wrote:
> On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote:
> > This patch (v0.4.6) adds
> Some pieces of the patch are obviously wrong: find_ibft() shouldn't be
> in ibft_init ... if ibft_phys was zero, it means the bootmem reservation
This patch (v0.4.7) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
Whoops. I've attached an incorrect patch in the previous
e-mail (http://lkml.org/lkml/2008/2/8/350) that didn't take
in to account the 'reserve_bootmem' parameters changes.
Here is fresher copy which has been tested on 2.6.24-git19
on a machine with iBFT and without.
This patch (v0.4.7) adds
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
+/*
+ * Physical location of iSCSI Boot Format Table.
This is now the Virtual address, isn't it? So just drop the Physical.
+ */
+unsigned long ibft_addr;
+EXPORT_SYMBOL(ibft_addr);
And since it is the virtual address, there's no
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
+ ibft_device = kmalloc(len, GFP_KERNEL);
+ if (!ibft_device)
+ return -ENOMEM;
+
+ memcpy(ibft_device, hdr, len);
This piece looks a bit odd. you're making ibft_device an exact
duplicate of ibft_addr
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
+ if (hdr-id == id_nic) {
+ pci_dev = pci_get_bus_and_slot((nic-pci_bdf 0xff00) 8,
+ (nic-pci_bdf 0xff));
+ if (pci_dev) {
+ rc =
This patch (v0.4.7) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
On Friday 01 February 2008 19:18:09 James Bottomley wrote:
On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote:
This patch (v0.4.6) adds
Some pieces of the patch are obviously wrong: find_ibft() shouldn't be
in ibft_init ... if ibft_phys was zero, it means the bootmem reservation
On Fri, 01 Feb 2008 18:18:09 -0600
James Bottomley <[EMAIL PROTECTED]> wrote:
> Also, move the reserve_bootmem into the ibft_find routines and ensure
> they're only called once on boot.
And note that the reserve_bootmem() interface is about to change.
On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote:
> This patch (v0.4.6) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
> directories along with text properties which export the the iSCSI
> Boot Firmware Table (iBFT) structure.
>
> What is iSCSI Boot Firmware Table? It is a
On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote:
This patch (v0.4.6) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism
On Fri, 01 Feb 2008 18:18:09 -0600
James Bottomley [EMAIL PROTECTED] wrote:
Also, move the reserve_bootmem into the ibft_find routines and ensure
they're only called once on boot.
And note that the reserve_bootmem() interface is about to change.
> That being said, I don't think there's any reason to expect the table to
> show up on anything but i386 and x86_64, and maybe ia64.
I've posted a new patch (http://lkml.org/lkml/2008/1/30/531) that includes
that dependency in the Kconfig (i386, x86_64, ia64)
--
To unsubscribe from this
This patch (v0.4.6) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
This patch (v0.4.6) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
That being said, I don't think there's any reason to expect the table to
show up on anything but i386 and x86_64, and maybe ia64.
I've posted a new patch (http://lkml.org/lkml/2008/1/30/531) that includes
that dependency in the Kconfig (i386, x86_64, ia64)
--
To unsubscribe from this list:
On Tuesday 29 January 2008 14:15:15 Mike Christie wrote:
> Konrad Rzeszutek wrote:
> > +/*
> > + * Helper functions to parse data properly.
> > + */
> > +static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
> > +{
> > + if (ip[0] == 0 && ip[1] == 0 && ip[2] == 0 && ip[3] == 0 &&
> > + ip[4] ==
On Tue, Jan 29, 2008 at 01:13:28PM -0600, Mike Christie wrote:
> Konrad Rzeszutek wrote:
>> On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]>
wrote: Hey Andrew,
Please add this patch along with Greg KH's
Konrad Rzeszutek wrote:
+/*
+ * Helper functions to parse data properly.
+ */
+static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
+{
+ if (ip[0] == 0 && ip[1] == 0 && ip[2] == 0 && ip[3] == 0 &&
+ ip[4] == 0 && ip[5] == 0 && ip[6] == 0 && ip[7] == 0 &&
+ ip[8] == 0 &&
Konrad Rzeszutek wrote:
On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]>
wrote: Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
Konrad Rzeszutek wrote:
On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED]
wrote: Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
On Tue, Jan 29, 2008 at 01:13:28PM -0600, Mike Christie wrote:
Konrad Rzeszutek wrote:
On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED]
wrote: Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK.
Konrad Rzeszutek wrote:
+/*
+ * Helper functions to parse data properly.
+ */
+static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
+{
+ if (ip[0] == 0 ip[1] == 0 ip[2] == 0 ip[3] == 0
+ ip[4] == 0 ip[5] == 0 ip[6] == 0 ip[7] == 0
+ ip[8] == 0 ip[9] == 0 ip[10] ==
On Tuesday 29 January 2008 14:15:15 Mike Christie wrote:
Konrad Rzeszutek wrote:
+/*
+ * Helper functions to parse data properly.
+ */
+static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
+{
+ if (ip[0] == 0 ip[1] == 0 ip[2] == 0 ip[3] == 0
+ ip[4] == 0 ip[5] == 0 ip[6]
Konrad Rzeszutek wrote:
iBFT is not platform-independent; it only makes sense on platforms with
ACPI (and even then, just barely; ACPI is a poor fit for it and it was
probably "integrated" with ACPI for political reasons.)
The spec just mentions that iBFT table has to be "compatible with an
> iBFT is not platform-independent; it only makes sense on platforms with
> ACPI (and even then, just barely; ACPI is a poor fit for it and it was
> probably "integrated" with ACPI for political reasons.)
The spec just mentions that iBFT table has to be "compatible with an ACPI
table format" and
Doug Maxey wrote:
On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote:
+EXPORT_SYMBOL(find_ibft);
Is this x86-specific? Are suitable Kconfig dependencies in place?
Originally I had it to be x86-specific but was told that I should make it all
platforms since the IBFT is platform
On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote:
> > > +EXPORT_SYMBOL(find_ibft);
> >
> > Is this x86-specific? Are suitable Kconfig dependencies in place?
>
> Originally I had it to be x86-specific but was told that I should make it all
> platforms since the IBFT is platform
On Sunday 27 January 2008 01:01:23 you wrote:
> > On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]>
> > wrote: Hey Andrew,
> >
> > Please add this patch along with Greg KH's kobject fixes.
>
> erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
>
> By
This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
On Sat, Jan 26, 2008 at 10:01:23PM -0800, Andrew Morton wrote:
> > int __initdata user_defined_memmap = 0;
>
> checkpatch should have told you that this "= 0" shouldn't be there. But it
> doesn't.
Ok, this line would be correctly picked up if it was being added by this
author, but this line
On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote:
+EXPORT_SYMBOL(find_ibft);
Is this x86-specific? Are suitable Kconfig dependencies in place?
Originally I had it to be x86-specific but was told that I should make it all
platforms since the IBFT is platform independent.
On Sunday 27 January 2008 01:01:23 you wrote:
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED]
wrote: Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
By what path _does_
iBFT is not platform-independent; it only makes sense on platforms with
ACPI (and even then, just barely; ACPI is a poor fit for it and it was
probably integrated with ACPI for political reasons.)
The spec just mentions that iBFT table has to be compatible with an ACPI
table format and
Konrad Rzeszutek wrote:
iBFT is not platform-independent; it only makes sense on platforms with
ACPI (and even then, just barely; ACPI is a poor fit for it and it was
probably integrated with ACPI for political reasons.)
The spec just mentions that iBFT table has to be compatible with an ACPI
This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
On Sat, Jan 26, 2008 at 10:01:23PM -0800, Andrew Morton wrote:
int __initdata user_defined_memmap = 0;
checkpatch should have told you that this = 0 shouldn't be there. But it
doesn't.
Ok, this line would be correctly picked up if it was being added by this
author, but this line is in
Doug Maxey wrote:
On Mon, 28 Jan 2008 14:04:51 EST, Konrad Rzeszutek wrote:
+EXPORT_SYMBOL(find_ibft);
Is this x86-specific? Are suitable Kconfig dependencies in place?
Originally I had it to be x86-specific but was told that I should make it all
platforms since the IBFT is platform
Andrew Morton wrote:
int __initdata user_defined_memmap = 0;
checkpatch should have told you that this "= 0" shouldn't be there. But it
doesn't.
checkpatch checks for static initializers, not non-static ones.
Should that be changed?
+ for (pos = (u8 *)hdr; pos < (u8 *)hdr +
Andrew Morton wrote:
int __initdata user_defined_memmap = 0;
checkpatch should have told you that this = 0 shouldn't be there. But it
doesn't.
checkpatch checks for static initializers, not non-static ones.
Should that be changed?
+ for (pos = (u8 *)hdr; pos (u8 *)hdr + len;
> On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> wrote:
> Hey Andrew,
>
> Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
By what path _does_ iscsi ode get into the tree, anyway? Mike
Please always include a diffstat with non-trivial patches.
> On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek <[EMAIL PROTECTED]> wrote:
> --- a/arch/x86/kernel/setup_32.c
> +++ b/arch/x86/kernel/setup_32.c
lol. You touched x86 code.
--
To unsubscribe from this list: send the line
Please always include a diffstat with non-trivial patches.
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED] wrote:
--- a/arch/x86/kernel/setup_32.c
+++ b/arch/x86/kernel/setup_32.c
lol. You touched x86 code.
goes off to fix the inevitable rejects
--
To unsubscribe from
On Fri, 25 Jan 2008 18:06:29 -0400 Konrad Rzeszutek [EMAIL PROTECTED] wrote:
Hey Andrew,
Please add this patch along with Greg KH's kobject fixes.
erm, OK. But I don't think I'm the appropriate conduit for iscsi paches.
By what path _does_ iscsi ode get into the tree, anyway? Mike is
Hey Andrew,
Please add this patch along with Greg KH's kobject fixes. This module
is dependent on the fixes that Greg KH has in his patches git tree.
This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot
Hey Andrew,
Please add this patch along with Greg KH's kobject fixes. This module
is dependent on the fixes that Greg KH has in his patches git tree.
This patch (v0.4.5) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI
Boot
This patch (v0.4.4) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX|
extensionX] directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs
This patch (v0.4.4) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX|
extensionX] directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs
This patch (v0.4.3) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX|
extensionX] directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine
This patch (v0.4.3) adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX|
extensionX] directories along with text properties which export the the iSCSI
Boot Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine
> > > > > This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
> > > > > directories along with text properties which export the the iSCSI Boot
> > > > > Firmware Table (iBFT) structure.
> > > > >
> > > > > What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
> > > > >
On Wed, Dec 05, 2007 at 03:47:08PM -0400, Konrad Rzeszutek wrote:
> On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote:
> > Overall, looks nice. Good work.
>
> Thank you.
>
> >
> > comments inline below...
> >
> > On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote:
> > > On
On Wed, Dec 05, 2007 at 03:47:08PM -0400, Konrad Rzeszutek wrote:
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote:
Overall, looks nice. Good work.
Thank you.
comments inline below...
On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote:
On Wed, Nov 28, 2007
This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI Boot
Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the
On Wed, Dec 05, 2007 at 03:02:56PM -0600, Doug Maxey wrote:
> [added cc: to mikec]
>
> On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote:
> > On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote:
> > >
> > > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
> > > > > Is
[added cc: to mikec]
On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote:
> On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote:
> >
> > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
> > > > Is the current include from open-iscsi being duplicated? If not, why
> > > >
On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote:
>
> On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
> > > Is the current include from open-iscsi being duplicated? If not, why
> > > not consolidate in one file?
> >
> > The include files that come from open-iscsi that are
On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
> > Is the current include from open-iscsi being duplicated? If not, why
> > not consolidate in one file?
>
> The include files that come from open-iscsi that are in the kernel do
> not have the iBFT data structures in them - therefore
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote:
> Overall, looks nice. Good work.
Thank you.
>
> comments inline below...
>
> On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote:
> > On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote:
> > >
> > > This patch
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote:
> Overall, looks nice. Good work.
Thank you.
>
> comments inline below...
>
.. snip ..
> > +#include
>
> Is the current include from open-iscsi being duplicated? If not, why
> not consolidate in one file?
The include files that
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote:
Overall, looks nice. Good work.
Thank you.
comments inline below...
.. snip ..
+#include linux/iscsi_ibft.h
Is the current include from open-iscsi being duplicated? If not, why
not consolidate in one file?
The include
[added cc: to mikec]
On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote:
On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote:
On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
Is the current include from open-iscsi being duplicated? If not, why
not
On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
Is the current include from open-iscsi being duplicated? If not, why
not consolidate in one file?
The include files that come from open-iscsi that are in the kernel do
not have the iBFT data structures in them - therefore no
On Tue, Dec 04, 2007 at 09:12:11PM -0600, Doug Maxey wrote:
Overall, looks nice. Good work.
Thank you.
comments inline below...
On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote:
On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote:
This patch adds
On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote:
On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
Is the current include from open-iscsi being duplicated? If not, why
not consolidate in one file?
The include files that come from open-iscsi that are in the
On Wed, Dec 05, 2007 at 03:02:56PM -0600, Doug Maxey wrote:
[added cc: to mikec]
On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote:
On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote:
On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
Is the current
Overall, looks nice. Good work.
comments inline below...
On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote:
> On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote:
> >
> > This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
> > directories along with text
On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote:
>
> This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
> directories along with text properties which export the the iSCSI Boot
> Firmware Table (iBFT) structure.
>
> What is iSCSI Boot Firmware Table? It is a
On Thu, Nov 29, 2007 at 11:36:21AM -0400, [EMAIL PROTECTED] wrote:
> > >
> > > /sys/firmware/ibft/ethernet0/pci-bdf
> > > 5:1:0
> >
> > shouldn't this somehow also have a symlink to the kernels ethX view of
> > ethernet devices?
> > (and if so.. how much of the info is duplicated..)
>
> That
On Thu, Nov 29, 2007 at 11:36:21AM -0400, [EMAIL PROTECTED] wrote:
/sys/firmware/ibft/ethernet0/pci-bdf
5:1:0
shouldn't this somehow also have a symlink to the kernels ethX view of
ethernet devices?
(and if so.. how much of the info is duplicated..)
That NIC is used by the
On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote:
This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI Boot
Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism
Overall, looks nice. Good work.
comments inline below...
On Tue, 04 Dec 2007 20:44:19 -0400, [EMAIL PROTECTED] wrote:
On Wed, Nov 28, 2007 at 07:34:22PM -0400, Konrad Rzeszutek wrote:
This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text
> >
> > /sys/firmware/ibft/ethernet0/pci-bdf
> > 5:1:0
>
> shouldn't this somehow also have a symlink to the kernels ethX view of
> ethernet devices?
> (and if so.. how much of the info is duplicated..)
That NIC is used by the NIC firmware (or the BIOS) to negotiate
the iSCSI target. The
On Mon, 26 Nov 2007 23:50:10 -0500
Konrad Rzeszutek <[EMAIL PROTECTED]> wrote:
> > >
> > > sysfs files have ONE VALUE PER FILE, not a whole bunch of
> > > different things in a single file. Please fix this.
> >
> > The subparameters _are_ actually part of a single value, that value
> > being
On Mon, 26 Nov 2007 23:50:10 -0500
Konrad Rzeszutek [EMAIL PROTECTED] wrote:
sysfs files have ONE VALUE PER FILE, not a whole bunch of
different things in a single file. Please fix this.
The subparameters _are_ actually part of a single value, that value
being associated with the
/sys/firmware/ibft/ethernet0/pci-bdf
5:1:0
shouldn't this somehow also have a symlink to the kernels ethX view of
ethernet devices?
(and if so.. how much of the info is duplicated..)
That NIC is used by the NIC firmware (or the BIOS) to negotiate
the iSCSI target. The information that
This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI Boot
Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
On Wed, Nov 28, 2007 at 04:24:32PM -0400, [EMAIL PROTECTED] wrote:
> > But, why not just put it in a separate file, that is built in if the
> > user wants iscsi support? That way the setup code can call it properly
> > if needed.
>
> In what directory should I put that file? It can't be in the
> > > I didn't realize an external file, outside of your changes, needed this
> > > function. If it does, then perhaps you need to just place it elsewhere.
> >
> > The fundamental problem is that 'find_ibft' ought to be available
> > from anywhere (or at least from the iscsi_ibft.c) so that the
On Wed, Nov 28, 2007 at 03:21:40PM -0400, [EMAIL PROTECTED] wrote:
> On Tue, Nov 27, 2007 at 11:09:19AM -0800, Greg KH wrote:
> > On Tue, Nov 27, 2007 at 02:09:50PM -0400, [EMAIL PROTECTED] wrote:
> > > On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote:
> > > > On Mon, Nov 26, 2007 at
On Tue, Nov 27, 2007 at 11:09:19AM -0800, Greg KH wrote:
> On Tue, Nov 27, 2007 at 02:09:50PM -0400, [EMAIL PROTECTED] wrote:
> > On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote:
> > > On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote:
> > > > On Monday 26 November 2007
On Tue, Nov 27, 2007 at 11:09:19AM -0800, Greg KH wrote:
On Tue, Nov 27, 2007 at 02:09:50PM -0400, [EMAIL PROTECTED] wrote:
On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote:
On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote:
On Monday 26 November 2007 22:31:38 Greg
On Wed, Nov 28, 2007 at 03:21:40PM -0400, [EMAIL PROTECTED] wrote:
On Tue, Nov 27, 2007 at 11:09:19AM -0800, Greg KH wrote:
On Tue, Nov 27, 2007 at 02:09:50PM -0400, [EMAIL PROTECTED] wrote:
On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote:
On Mon, Nov 26, 2007 at 11:23:31PM
On Wed, Nov 28, 2007 at 04:24:32PM -0400, [EMAIL PROTECTED] wrote:
But, why not just put it in a separate file, that is built in if the
user wants iscsi support? That way the setup code can call it properly
if needed.
In what directory should I put that file? It can't be in the arch/*
I didn't realize an external file, outside of your changes, needed this
function. If it does, then perhaps you need to just place it elsewhere.
The fundamental problem is that 'find_ibft' ought to be available
from anywhere (or at least from the iscsi_ibft.c) so that the iscsi_ibft
This patch adds /sysfs/firmware/ibft/[initiator|targetX|ethernetX]
directories along with text properties which export the the iSCSI Boot
Firmware Table (iBFT) structure.
What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI
tools to extract from the machine NICs the iSCSI
On Tue, Nov 27, 2007 at 02:09:50PM -0400, [EMAIL PROTECTED] wrote:
> On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote:
> > On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote:
> > > On Monday 26 November 2007 22:31:38 Greg KH wrote:
> > > > > +#if defined(CONFIG_ISCSI_IBFT) ||
On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote:
> On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote:
> > On Monday 26 November 2007 22:31:38 Greg KH wrote:
> > > > +#if defined(CONFIG_ISCSI_IBFT) || defined(CONFIG_ISCSI_IBFT_MODULE)
> > ..snip..
> > > > +static ssize_t
On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote:
On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote:
On Monday 26 November 2007 22:31:38 Greg KH wrote:
+#if defined(CONFIG_ISCSI_IBFT) || defined(CONFIG_ISCSI_IBFT_MODULE)
..snip..
+static ssize_t find_ibft(void)
On Tue, Nov 27, 2007 at 02:09:50PM -0400, [EMAIL PROTECTED] wrote:
On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote:
On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote:
On Monday 26 November 2007 22:31:38 Greg KH wrote:
+#if defined(CONFIG_ISCSI_IBFT) ||
1 - 100 of 152 matches
Mail list logo
