Re: [PATCH] Add missing spin_unlock_irq to ide.c (244ac16)

2001-05-25 Thread Rasmus Andersen
On Fri, May 25, 2001 at 11:11:23PM +0200, Jens Axboe wrote: [...] > This isn't right. Granted the locking isn't straight forward here, but > take a look at ide_write_setting -> ide_spin_wait_hwgroup and the > latters return value. Yes, Andre set me straight here. My apologies for being lazy

Re: [PATCH] Add missing spin_unlock_irq to ide.c (244ac16)

2001-05-25 Thread Jens Axboe
On Fri, May 25 2001, Rasmus Andersen wrote: > (I forgot to cc l-k on this one when it went to andre.) > > Hi. > > This patch adds a spin_unlock_irqsave to ide_spin_wait_hwgroup as > reported by the Stanford team way back. It applies against 244ac16. > > > ---

[PATCH] Add missing spin_unlock_irq to ide.c (244ac16)

2001-05-25 Thread Rasmus Andersen
(I forgot to cc l-k on this one when it went to andre.) Hi. This patch adds a spin_unlock_irqsave to ide_spin_wait_hwgroup as reported by the Stanford team way back. It applies against 244ac16. --- linux-244-ac16-clean/drivers/ide/ide.c Fri May 25 21:11:08 2001 +++

[PATCH] Add missing spin_unlock_irq to ide.c (244ac16)

2001-05-25 Thread Rasmus Andersen
(I forgot to cc l-k on this one when it went to andre.) Hi. This patch adds a spin_unlock_irqsave to ide_spin_wait_hwgroup as reported by the Stanford team way back. It applies against 244ac16. --- linux-244-ac16-clean/drivers/ide/ide.c Fri May 25 21:11:08 2001 +++

Re: [PATCH] Add missing spin_unlock_irq to ide.c (244ac16)

2001-05-25 Thread Jens Axboe
On Fri, May 25 2001, Rasmus Andersen wrote: (I forgot to cc l-k on this one when it went to andre.) Hi. This patch adds a spin_unlock_irqsave to ide_spin_wait_hwgroup as reported by the Stanford team way back. It applies against 244ac16. --- linux-244-ac16-clean/drivers/ide/ide.c

Re: [PATCH] Add missing spin_unlock_irq to ide.c (244ac16)

2001-05-25 Thread Rasmus Andersen
On Fri, May 25, 2001 at 11:11:23PM +0200, Jens Axboe wrote: [...] This isn't right. Granted the locking isn't straight forward here, but take a look at ide_write_setting - ide_spin_wait_hwgroup and the latters return value. Yes, Andre set me straight here. My apologies for being lazy and