Re: [PATCH] Fix modular AGPGART (ia64 allmodconfig)

2007-02-15 Thread Zwane Mwaikambo
On Fri, 16 Feb 2007, Kyle McMartin wrote: > On Thu, Feb 15, 2007 at 10:09:57PM -0800, Zwane Mwaikambo wrote: > > +ifeq ($(CONFIG_COMPAT),y) > > +agpgart-y += compat_ioctl.o > > +endif > > + > > eh? > > Couldn't this be? > agpgart-$(CONFIG_COMPAT) += compat_ioctl.o Yep

Re: [PATCH] Fix modular AGPGART (ia64 allmodconfig)

2007-02-15 Thread Kyle McMartin
On Thu, Feb 15, 2007 at 10:09:57PM -0800, Zwane Mwaikambo wrote: > +ifeq ($(CONFIG_COMPAT),y) > +agpgart-y+= compat_ioctl.o > +endif > + eh? Couldn't this be? agpgart-$(CONFIG_COMPAT)+= compat_ioctl.o Cheers, Kyle M. - To unsubscribe from this list: send the

[PATCH] Fix modular AGPGART (ia64 allmodconfig)

2007-02-15 Thread Zwane Mwaikambo
My previous compat AGP patch broke modular AGPGART. Test built on; i386 CONFIG_AGP=y,m x86_64 CONFIG_AGP=y ia64 CONFIG_AGP=m Signed-off-by: Zwane Mwaikambo <[EMAIL PROTECTED]> Index: linux-2.6.20-mm1-ia64/drivers/char/agp/Makefile

[PATCH] Fix modular AGPGART (ia64 allmodconfig)

2007-02-15 Thread Zwane Mwaikambo
My previous compat AGP patch broke modular AGPGART. Test built on; i386 CONFIG_AGP=y,m x86_64 CONFIG_AGP=y ia64 CONFIG_AGP=m Signed-off-by: Zwane Mwaikambo [EMAIL PROTECTED] Index: linux-2.6.20-mm1-ia64/drivers/char/agp/Makefile

Re: [PATCH] Fix modular AGPGART (ia64 allmodconfig)

2007-02-15 Thread Kyle McMartin
On Thu, Feb 15, 2007 at 10:09:57PM -0800, Zwane Mwaikambo wrote: +ifeq ($(CONFIG_COMPAT),y) +agpgart-y+= compat_ioctl.o +endif + eh? Couldn't this be? agpgart-$(CONFIG_COMPAT)+= compat_ioctl.o Cheers, Kyle M. - To unsubscribe from this list: send the line

Re: [PATCH] Fix modular AGPGART (ia64 allmodconfig)

2007-02-15 Thread Zwane Mwaikambo
On Fri, 16 Feb 2007, Kyle McMartin wrote: On Thu, Feb 15, 2007 at 10:09:57PM -0800, Zwane Mwaikambo wrote: +ifeq ($(CONFIG_COMPAT),y) +agpgart-y += compat_ioctl.o +endif + eh? Couldn't this be? agpgart-$(CONFIG_COMPAT) += compat_ioctl.o Yep thay works too