Re: [PATCH] Improve error recovery in serial mouse driver

2007-03-16 Thread Chuck Ebbert
Peter Osterlund wrote: > if (data & 0x40) sermouse->count = 0; > + else if (sermouse->count == 0) return; if (data & 0x40) sermouse->count = 0; else if (sermouse->count == 0) return; ? Would have been a good time

Re: [PATCH] Improve error recovery in serial mouse driver

2007-03-16 Thread Chuck Ebbert
Peter Osterlund wrote: if (data 0x40) sermouse-count = 0; + else if (sermouse-count == 0) return; if (data 0x40) sermouse-count = 0; else if (sermouse-count == 0) return; ? Would have been a good time to

Re: [PATCH] Improve error recovery in serial mouse driver

2007-03-15 Thread Dmitry Torokhov
On Thursday 15 March 2007 15:16, Peter Osterlund wrote: > If bytes get lost in the communication with a serial mouse using the > MS protocol, the kernel driver could do a better job getting back in > sync. The first byte in a packet has bit 6 set, and no other bytes > have that bit set. Therefore,

[PATCH] Improve error recovery in serial mouse driver

2007-03-15 Thread Peter Osterlund
If bytes get lost in the communication with a serial mouse using the MS protocol, the kernel driver could do a better job getting back in sync. The first byte in a packet has bit 6 set, and no other bytes have that bit set. Therefore, if a byte is received with bit 6 cleared when the driver thinks

[PATCH] Improve error recovery in serial mouse driver

2007-03-15 Thread Peter Osterlund
If bytes get lost in the communication with a serial mouse using the MS protocol, the kernel driver could do a better job getting back in sync. The first byte in a packet has bit 6 set, and no other bytes have that bit set. Therefore, if a byte is received with bit 6 cleared when the driver thinks

Re: [PATCH] Improve error recovery in serial mouse driver

2007-03-15 Thread Dmitry Torokhov
On Thursday 15 March 2007 15:16, Peter Osterlund wrote: If bytes get lost in the communication with a serial mouse using the MS protocol, the kernel driver could do a better job getting back in sync. The first byte in a packet has bit 6 set, and no other bytes have that bit set. Therefore, if