Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry

2021-03-23 Thread Dmitry Torokhov
On Tue, Mar 23, 2021 at 02:06:13PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The Zenbook Flip entry that was added overwrites a previous one > because of a typo: > > In file included from drivers/input/serio/i8042.h:23, > from drivers/input/serio/i8042.c:131: >

Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry

2021-03-23 Thread Marcos Paulo de Souza
On Tue, 2021-03-23 at 14:06 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The Zenbook Flip entry that was added overwrites a previous one > because of a typo: > > In file included from drivers/input/serio/i8042.h:23, > from drivers/input/serio/i8042.c:131: >

Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry

2021-03-23 Thread Hans de Goede
Hi, On 3/23/21 2:06 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The Zenbook Flip entry that was added overwrites a previous one > because of a typo: > > In file included from drivers/input/serio/i8042.h:23, > from drivers/input/serio/i8042.c:131: >

[PATCH] Input: i8042 - fix Pegatron C15B ID entry

2021-03-23 Thread Arnd Bergmann
From: Arnd Bergmann The Zenbook Flip entry that was added overwrites a previous one because of a typo: In file included from drivers/input/serio/i8042.h:23, from drivers/input/serio/i8042.c:131: drivers/input/serio/i8042-x86ia64io.h:591:28: error: initialized field overwritten

[PATCH] Input: i8042 - add dmi quirk

2021-03-15 Thread AceLan Kao
From: "Chia-Lin Kao (AceLan)" On some platforms, the EC doesn't support the register reading sequence for sentelic[1], and then make the EC can't respond commands for a while when probing. It leads to the keyboard non-responsive for around 10 seconds while waking up from s2idle. [ 44.304488]

Re: [PATCH] Input: i8042: Remove unneeded variable

2021-02-25 Thread kernel test robot
Hi angkery, Thank you for the patch! Yet something to improve: [auto build test ERROR on input/next] [also build test ERROR on v5.11 next-20210225] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

Re: [PATCH] Input: i8042: Remove unneeded variable

2021-02-25 Thread kernel test robot
Hi angkery, Thank you for the patch! Yet something to improve: [auto build test ERROR on input/next] [also build test ERROR on v5.11 next-20210225] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in

[PATCH] Input: i8042: Remove unneeded variable

2021-02-25 Thread angkery
From: Junlin Yang The variable "delay" is initialized to zero and then returned. So remove the delay variable and return zero. Generated by:scripts/coccinelle/misc/returnvar.cocci Signed-off-by: Junlin Yang --- drivers/input/serio/i8042.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH] Input: i8042: remove definition of DEBUG

2021-01-15 Thread trix
From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- drivers/input/serio/i8042.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index abae23af0791..411ebb2cefb5 100644 ---

Re: [PATCH] Input: i8042 - add Acer laptops to the i8042 reset list

2020-12-09 Thread Dmitry Torokhov
Hi Chris, On Mon, Dec 07, 2020 at 03:12:50PM +0800, Chris Chiu wrote: > The touchpad operates in Basic Mode by default in the Acer BIOS > setup, but some Aspire/TravelMate models require the i8042 to be > reset in order to be correctly detected. > > Signed-off-by: Chris Chiu > --- >

[PATCH] Input: i8042 - add Acer laptops to the i8042 reset list

2020-12-06 Thread Chris Chiu
The touchpad operates in Basic Mode by default in the Acer BIOS setup, but some Aspire/TravelMate models require the i8042 to be reset in order to be correctly detected. Signed-off-by: Chris Chiu --- drivers/input/serio/i8042-x86ia64io.h | 42 +++ 1 file changed, 42

Re: [PATCH] Input: i8042 - Add ByteSpeed touchpad to noloop table

2020-11-30 Thread Dmitry Torokhov
On Tue, Dec 01, 2020 at 01:47:23PM +0800, Po-Hsu Lin wrote: > It looks like the C15B laptop got another vendor: ByteSpeed LLC. > > Avoid AUX loopback on this touchpad as well, thus input subsystem will > be able to recognize a Synaptics touchpad in the AUX port. > > BugLink:

[PATCH] Input: i8042 - Add ByteSpeed touchpad to noloop table

2020-11-30 Thread Po-Hsu Lin
It looks like the C15B laptop got another vendor: ByteSpeed LLC. Avoid AUX loopback on this touchpad as well, thus input subsystem will be able to recognize a Synaptics touchpad in the AUX port. BugLink: https://bugs.launchpad.net/bugs/1906128 Signed-off-by: Po-Hsu Lin ---

[PATCH] input: i8042: remove redundant assignment to variable retval

2020-06-22 Thread Colin King
From: Colin Ian King The variable retval is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/input/serio/i8042.c

Re: [PATCH] input: i8042: Remove special PowerPC handling

2020-06-08 Thread Michael Ellerman
On Mon, 18 May 2020 11:10:43 -0700, Nathan Chancellor wrote: > This causes a build error with CONFIG_WALNUT because kb_cs and kb_data > were removed in commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and > include/asm-ppc"). > > ld.lld: error: undefined symbol: kb_cs > > referenced by

Re: [PATCH] input: i8042: Remove special PowerPC handling

2020-05-21 Thread Michael Ellerman
Dmitry Torokhov writes: > Hi Michael, > > On Wed, May 20, 2020 at 04:07:00PM +1000, Michael Ellerman wrote: >> [ + Dmitry & linux-input ] >> >> Nathan Chancellor writes: >> > This causes a build error with CONFIG_WALNUT because kb_cs and kb_data >> > were removed in commit 917f0af9e5a9

Re: [PATCH] input: i8042: Remove special PowerPC handling

2020-05-20 Thread Dmitry Torokhov
Hi Michael, On Wed, May 20, 2020 at 04:07:00PM +1000, Michael Ellerman wrote: > [ + Dmitry & linux-input ] > > Nathan Chancellor writes: > > This causes a build error with CONFIG_WALNUT because kb_cs and kb_data > > were removed in commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and > >

Re: [PATCH] input: i8042: Remove special PowerPC handling

2020-05-20 Thread Michael Ellerman
[ + Dmitry & linux-input ] Nathan Chancellor writes: > This causes a build error with CONFIG_WALNUT because kb_cs and kb_data > were removed in commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and > include/asm-ppc"). > > ld.lld: error: undefined symbol: kb_cs >> referenced by i8042-ppcio.h:28

[PATCH] input: i8042: Remove special PowerPC handling

2020-05-18 Thread Nathan Chancellor
This causes a build error with CONFIG_WALNUT because kb_cs and kb_data were removed in commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"). ld.lld: error: undefined symbol: kb_cs > referenced by i8042-ppcio.h:28 (drivers/input/serio/i8042-ppcio.h:28) >

[PATCH] Input - i8042: Enable wakeup on a stable struct device

2019-08-27 Thread Stephen Boyd
We don't know when the device will be added with device_add() in serio_add_port() because serio_add_port() is called from a workqueue that this driver schedules by calling serio_register_port(). The best we can know is that the device will definitely not have been added yet when the start callback

Re: [PATCH] Input: i8042 - disable KBD port on Late-2016 Razer Blade Stealth

2019-07-17 Thread Dmitry Torokhov
On Mon, Apr 08, 2019 at 09:55:00AM +, David Laight wrote: > From: Lyude Paul > > Sent: 07 April 2019 23:55 > > On Sun, 2019-04-07 at 15:10 -0700, Dmitry Torokhov wrote: > > > Hi Lyude, > > > > > > On Sun, Apr 07, 2019 at 05:37:34PM -0400, Lyude Paul wrote: > > > > The late 2016 model of the

RE: [PATCH] Input: i8042 - disable KBD port on Late-2016 Razer Blade Stealth

2019-04-08 Thread David Laight
From: Lyude Paul > Sent: 07 April 2019 23:55 > On Sun, 2019-04-07 at 15:10 -0700, Dmitry Torokhov wrote: > > Hi Lyude, > > > > On Sun, Apr 07, 2019 at 05:37:34PM -0400, Lyude Paul wrote: > > > The late 2016 model of the Razer Blade Stealth has a built-in USB > > > keyboard, but for some reason the

Re: [PATCH] Input: i8042 - disable KBD port on Late-2016 Razer Blade Stealth

2019-04-07 Thread Lyude Paul
On Sun, 2019-04-07 at 15:10 -0700, Dmitry Torokhov wrote: > Hi Lyude, > > On Sun, Apr 07, 2019 at 05:37:34PM -0400, Lyude Paul wrote: > > The late 2016 model of the Razer Blade Stealth has a built-in USB > > keyboard, but for some reason the BIOS exposes an i8042 controller with > > a connected

Re: [PATCH] Input: i8042 - disable KBD port on Late-2016 Razer Blade Stealth

2019-04-07 Thread Dmitry Torokhov
Hi Lyude, On Sun, Apr 07, 2019 at 05:37:34PM -0400, Lyude Paul wrote: > The late 2016 model of the Razer Blade Stealth has a built-in USB > keyboard, but for some reason the BIOS exposes an i8042 controller with > a connected KBD port. While this fake AT Keyboard device doesn't appear > to report

[PATCH] Input: i8042 - disable KBD port on Late-2016 Razer Blade Stealth

2019-04-07 Thread Lyude Paul
The late 2016 model of the Razer Blade Stealth has a built-in USB keyboard, but for some reason the BIOS exposes an i8042 controller with a connected KBD port. While this fake AT Keyboard device doesn't appear to report any events, attempting to change the state of the caps lock LED on it from on

Re: [PATCH] Input: i8042 - signal wakeup from atkbd/psmouse

2019-03-28 Thread Rafael J. Wysocki
On Wednesday, March 27, 2019 1:28:00 AM CET Dmitry Torokhov wrote: > Instead of signalling wakeup directly from i8042, let psmouse and atkbd > drivers execute basic protocol handling and only then signal wakeup > condition. This solves the issue where we increment wakeup counter > simply because

[PATCH] Input: i8042 - signal wakeup from atkbd/psmouse

2019-03-26 Thread Dmitry Torokhov
Instead of signalling wakeup directly from i8042, let psmouse and atkbd drivers execute basic protocol handling and only then signal wakeup condition. This solves the issue where we increment wakeup counter simply because we are getting responses from keyboard/mouse to the commands we ourselves

Re: [PATCH] Input: i8042 - Rework DT node name comparisons

2019-02-17 Thread Dmitry Torokhov
On Wed, Feb 13, 2019 at 10:16:31AM -0600, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. For the root node on SUN DT, we need to retrieve the 'name' > property as it is the rare case where the 'name' property and node name > differ. With both

[PATCH] Input: i8042 - Rework DT node name comparisons

2019-02-13 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. For the root node on SUN DT, we need to retrieve the 'name' property as it is the rare case where the 'name' property and node name differ. With both changes, it removes direct access to the node name pointer. While

Re: [PATCH] Input: i8042 add of_node_put()

2018-12-08 Thread Frank Lee
On Fri, Nov 30, 2018 at 2:37 AM Dmitry Torokhov wrote: > > Hi Yangtao, > > On Wed, Nov 21, 2018 at 09:35:13AM -0500, Yangtao Li wrote: > > use of_node_put() to release the refcount. > > > > Signed-off-by: Yangtao Li > > --- > > drivers/input/serio/i8042-sparcio.h | 24 +--- >

[PATCH] Input: i8042 - Rework DT node name comparisons

2018-12-05 Thread Rob Herring
Signed-off-by: Rob Herring --- drivers/input/serio/i8042-sparcio.h | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/input/serio/i8042-sparcio.h b/drivers/input/serio/i8042-sparcio.h index 796289846204..fce76812843b 100644 ---

[PATCH] Input: i8042 - Rework DT node name comparisons

2018-12-05 Thread Rob Herring
Signed-off-by: Rob Herring --- drivers/input/serio/i8042-sparcio.h | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/input/serio/i8042-sparcio.h b/drivers/input/serio/i8042-sparcio.h index 796289846204..fce76812843b 100644 ---

Re: [PATCH] Input: i8042 add of_node_put()

2018-11-29 Thread Dmitry Torokhov
Hi Yangtao, On Wed, Nov 21, 2018 at 09:35:13AM -0500, Yangtao Li wrote: > use of_node_put() to release the refcount. > > Signed-off-by: Yangtao Li > --- > drivers/input/serio/i8042-sparcio.h | 24 +--- > 1 file changed, 17 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH] Input: i8042 add of_node_put()

2018-11-29 Thread Dmitry Torokhov
Hi Yangtao, On Wed, Nov 21, 2018 at 09:35:13AM -0500, Yangtao Li wrote: > use of_node_put() to release the refcount. > > Signed-off-by: Yangtao Li > --- > drivers/input/serio/i8042-sparcio.h | 24 +--- > 1 file changed, 17 insertions(+), 7 deletions(-) > > diff --git

[PATCH] Input: i8042 add of_node_put()

2018-11-21 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/input/serio/i8042-sparcio.h | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/input/serio/i8042-sparcio.h b/drivers/input/serio/i8042-sparcio.h index

[PATCH] Input: i8042 add of_node_put()

2018-11-21 Thread Yangtao Li
use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/input/serio/i8042-sparcio.h | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/input/serio/i8042-sparcio.h b/drivers/input/serio/i8042-sparcio.h index

Re: [PATCH] Input: i8042 - add Lenovo LaVie Z to the i8042 reset list

2018-07-18 Thread Dmitry Torokhov
On Thu, Jul 05, 2018 at 09:08:49PM +0800, Chen-Yu Tsai wrote: > The Lenovo LaVie Z laptop requires i8042 to be reset in order to > consistently detect its Elantech touchpad. The nomux and kbdreset > quirks are not sufficient. > > It's possible the other LaVie Z models from NEC require this as

Re: [PATCH] Input: i8042 - add Lenovo LaVie Z to the i8042 reset list

2018-07-18 Thread Dmitry Torokhov
On Thu, Jul 05, 2018 at 09:08:49PM +0800, Chen-Yu Tsai wrote: > The Lenovo LaVie Z laptop requires i8042 to be reset in order to > consistently detect its Elantech touchpad. The nomux and kbdreset > quirks are not sufficient. > > It's possible the other LaVie Z models from NEC require this as

[PATCH] Input: i8042 - add Lenovo LaVie Z to the i8042 reset list

2018-07-05 Thread Chen-Yu Tsai
The Lenovo LaVie Z laptop requires i8042 to be reset in order to consistently detect its Elantech touchpad. The nomux and kbdreset quirks are not sufficient. It's possible the other LaVie Z models from NEC require this as well. Cc: sta...@vger.kernel.org Signed-off-by: Chen-Yu Tsai ---

[PATCH] Input: i8042 - add Lenovo LaVie Z to the i8042 reset list

2018-07-05 Thread Chen-Yu Tsai
The Lenovo LaVie Z laptop requires i8042 to be reset in order to consistently detect its Elantech touchpad. The nomux and kbdreset quirks are not sufficient. It's possible the other LaVie Z models from NEC require this as well. Cc: sta...@vger.kernel.org Signed-off-by: Chen-Yu Tsai ---

Re: [PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-17 Thread Kai-Heng Feng
at 5:57 AM, Dmitry Torokhov wrote: On Wed, Apr 11, 2018 at 04:59:05PM +0800, Kai-Heng Feng wrote: Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's

Re: [PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-17 Thread Kai-Heng Feng
at 5:57 AM, Dmitry Torokhov wrote: On Wed, Apr 11, 2018 at 04:59:05PM +0800, Kai-Heng Feng wrote: Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by default. In commit

Re: [PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-13 Thread Dmitry Torokhov
On Wed, Apr 11, 2018 at 04:59:05PM +0800, Kai-Heng Feng wrote: > Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up > from suspend-to-idle") make system in s2idle can be woken up by i8042 > keyboard, but it's disabled by default. > > In commit 3e6e15a862a0 ("Input: enable

Re: [PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-13 Thread Dmitry Torokhov
On Wed, Apr 11, 2018 at 04:59:05PM +0800, Kai-Heng Feng wrote: > Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up > from suspend-to-idle") make system in s2idle can be woken up by i8042 > keyboard, but it's disabled by default. > > In commit 3e6e15a862a0 ("Input: enable

[PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-11 Thread Kai-Heng Feng
Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by default. In commit 3e6e15a862a0 ("Input: enable remote wakeup for PNP i8042 keyboard ports") states that "Keyboard ports are

[PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-11 Thread Kai-Heng Feng
Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by default. In commit 3e6e15a862a0 ("Input: enable remote wakeup for PNP i8042 keyboard ports") states that "Keyboard ports are

[PATCH] Input: i8042 - Never reset on Sony VAIO VGN-CS series

2018-04-09 Thread Ondrej Zary
Resetting i8042 breaks MUX on Sony VAIO VGN-CS. Never reset i8042 on these machines to fix MUX after suspend. Signed-off-by: Ondrej Zary --- drivers/input/serio/i8042-x86ia64io.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[PATCH] Input: i8042 - Never reset on Sony VAIO VGN-CS series

2018-04-09 Thread Ondrej Zary
Resetting i8042 breaks MUX on Sony VAIO VGN-CS. Never reset i8042 on these machines to fix MUX after suspend. Signed-off-by: Ondrej Zary --- drivers/input/serio/i8042-x86ia64io.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] Input: i8042: add Lenovo ThinkPad L460 to i8042 reset list

2018-03-08 Thread Dmitry Torokhov
On Thu, Mar 08, 2018 at 05:35:14PM +0100, Dennis Wassenberg wrote: > Reset i8042 before probing because of insufficient > BIOS initialisation of the i8042 serial controller. > This makes synaptics touchpad detection possible. > Without resetting the synaptics touchpad is not detected > because

Re: [PATCH] Input: i8042: add Lenovo ThinkPad L460 to i8042 reset list

2018-03-08 Thread Dmitry Torokhov
On Thu, Mar 08, 2018 at 05:35:14PM +0100, Dennis Wassenberg wrote: > Reset i8042 before probing because of insufficient > BIOS initialisation of the i8042 serial controller. > This makes synaptics touchpad detection possible. > Without resetting the synaptics touchpad is not detected > because

[PATCH] Input: i8042: add Lenovo ThinkPad L460 to i8042 reset list

2018-03-08 Thread Dennis Wassenberg
Reset i8042 before probing because of insufficient BIOS initialisation of the i8042 serial controller. This makes synaptics touchpad detection possible. Without resetting the synaptics touchpad is not detected because there are always NACK messages from AUX port. Signed-off-by: Dennis Wassenberg

[PATCH] Input: i8042: add Lenovo ThinkPad L460 to i8042 reset list

2018-03-08 Thread Dennis Wassenberg
Reset i8042 before probing because of insufficient BIOS initialisation of the i8042 serial controller. This makes synaptics touchpad detection possible. Without resetting the synaptics touchpad is not detected because there are always NACK messages from AUX port. Signed-off-by: Dennis Wassenberg

Re: [PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

2017-09-15 Thread Dmitry Torokhov
On Wed, Jul 12, 2017 at 11:39:53AM +0800, Kai-Heng Feng wrote: > Similar to other Gigabyte laptops, the touchpad on P57 requires a > keyboard reset to detect Elantech touchpad correctly. > > BugLink: https://bugs.launchpad.net/bugs/1594214 > Signed-off-by: Kai-Heng Feng

Re: [PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

2017-09-15 Thread Dmitry Torokhov
On Wed, Jul 12, 2017 at 11:39:53AM +0800, Kai-Heng Feng wrote: > Similar to other Gigabyte laptops, the touchpad on P57 requires a > keyboard reset to detect Elantech touchpad correctly. > > BugLink: https://bugs.launchpad.net/bugs/1594214 > Signed-off-by: Kai-Heng Feng Applied, thank you. >

Re: [PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

2017-08-17 Thread Kai-Heng Feng
On Wed, Jul 12, 2017 at 11:39 AM, Kai-Heng Feng wrote: > Similar to other Gigabyte laptops, the touchpad on P57 requires a > keyboard reset to detect Elantech touchpad correctly. > > BugLink: https://bugs.launchpad.net/bugs/1594214 > Signed-off-by: Kai-Heng Feng

Re: [PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

2017-08-17 Thread Kai-Heng Feng
On Wed, Jul 12, 2017 at 11:39 AM, Kai-Heng Feng wrote: > Similar to other Gigabyte laptops, the touchpad on P57 requires a > keyboard reset to detect Elantech touchpad correctly. > > BugLink: https://bugs.launchpad.net/bugs/1594214 > Signed-off-by: Kai-Heng Feng > --- >

Re: [PATCH] Input: i8042: constify pnp_device_id

2017-08-16 Thread Dmitry Torokhov
On Wed, Aug 16, 2017 at 11:11:42AM +0530, Arvind Yadav wrote: > pnp_device_id are not supposed to change at runtime. All functions > working with pnp_device_id provided by work with > const pnp_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: [PATCH] Input: i8042: constify pnp_device_id

2017-08-16 Thread Dmitry Torokhov
On Wed, Aug 16, 2017 at 11:11:42AM +0530, Arvind Yadav wrote: > pnp_device_id are not supposed to change at runtime. All functions > working with pnp_device_id provided by work with > const pnp_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Applied, thank

[PATCH] Input: i8042: constify pnp_device_id

2017-08-15 Thread Arvind Yadav
pnp_device_id are not supposed to change at runtime. All functions working with pnp_device_id provided by work with const pnp_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/input/serio/i8042-x86ia64io.h | 4 ++-- 1 file

[PATCH] Input: i8042: constify pnp_device_id

2017-08-15 Thread Arvind Yadav
pnp_device_id are not supposed to change at runtime. All functions working with pnp_device_id provided by work with const pnp_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/input/serio/i8042-x86ia64io.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

2017-07-11 Thread Kai-Heng Feng
Similar to other Gigabyte laptops, the touchpad on P57 requires a keyboard reset to detect Elantech touchpad correctly. BugLink: https://bugs.launchpad.net/bugs/1594214 Signed-off-by: Kai-Heng Feng --- drivers/input/serio/i8042-x86ia64io.h | 7 +++ 1 file

[PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

2017-07-11 Thread Kai-Heng Feng
Similar to other Gigabyte laptops, the touchpad on P57 requires a keyboard reset to detect Elantech touchpad correctly. BugLink: https://bugs.launchpad.net/bugs/1594214 Signed-off-by: Kai-Heng Feng --- drivers/input/serio/i8042-x86ia64io.h | 7 +++ 1 file changed, 7 insertions(+) diff

Re: [PATCH] Input: i8042: add a check in i8042_interrupt

2017-07-02 Thread dmitry.torok...@gmail.com
Hi, On Sat, Jun 24, 2017 at 09:38:48AM +, chenhong (N) wrote: > Description of problem: > > Encounterd BUG case: > serio: i8042 KBD port at 0x60,0x64 irq 1 > BUG: unable to handle kernel NULL pointer dereference at 0050 > IP: [] _spin_lock_irqsave+0x1f/0x40 > PGD 0 > Oops: 0002

Re: [PATCH] Input: i8042: add a check in i8042_interrupt

2017-07-02 Thread dmitry.torok...@gmail.com
Hi, On Sat, Jun 24, 2017 at 09:38:48AM +, chenhong (N) wrote: > Description of problem: > > Encounterd BUG case: > serio: i8042 KBD port at 0x60,0x64 irq 1 > BUG: unable to handle kernel NULL pointer dereference at 0050 > IP: [] _spin_lock_irqsave+0x1f/0x40 > PGD 0 > Oops: 0002

Re: [PATCH] Input: i8042 - add Clevo P650RS to the i8042 reset list

2017-04-24 Thread Dmitry Torokhov
On Mon, Apr 24, 2017 at 01:24:34PM +1000, Ed Bordin wrote: > Works for me. Thanks for the fix! Thanks for testing! > > On 14 April 2017 at 08:51, Dmitry Torokhov wrote: > > Clevo P650RS and other similar devices require i8042 to be reset in order > > to detect

Re: [PATCH] Input: i8042 - add Clevo P650RS to the i8042 reset list

2017-04-24 Thread Dmitry Torokhov
On Mon, Apr 24, 2017 at 01:24:34PM +1000, Ed Bordin wrote: > Works for me. Thanks for the fix! Thanks for testing! > > On 14 April 2017 at 08:51, Dmitry Torokhov wrote: > > Clevo P650RS and other similar devices require i8042 to be reset in order > > to detect Synaptics touchpad. > > > >

Re: [PATCH] Input: i8042 - add Clevo P650RS to the i8042 reset list

2017-04-23 Thread Ed Bordin
Works for me. Thanks for the fix! On 14 April 2017 at 08:51, Dmitry Torokhov wrote: > Clevo P650RS and other similar devices require i8042 to be reset in order > to detect Synaptics touchpad. > > Reported-by: Paweł Bylica > Bugzilla:

Re: [PATCH] Input: i8042 - add Clevo P650RS to the i8042 reset list

2017-04-23 Thread Ed Bordin
Works for me. Thanks for the fix! On 14 April 2017 at 08:51, Dmitry Torokhov wrote: > Clevo P650RS and other similar devices require i8042 to be reset in order > to detect Synaptics touchpad. > > Reported-by: Paweł Bylica > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=190301 >

[PATCH] Input: i8042 - add Clevo P650RS to the i8042 reset list

2017-04-13 Thread Dmitry Torokhov
Clevo P650RS and other similar devices require i8042 to be reset in order to detect Synaptics touchpad. Reported-by: Paweł Bylica Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=190301 Signed-off-by: Dmitry Torokhov ---

[PATCH] Input: i8042 - add Clevo P650RS to the i8042 reset list

2017-04-13 Thread Dmitry Torokhov
Clevo P650RS and other similar devices require i8042 to be reset in order to detect Synaptics touchpad. Reported-by: Paweł Bylica Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=190301 Signed-off-by: Dmitry Torokhov --- drivers/input/serio/i8042-x86ia64io.h | 7 +++ 1 file changed, 7

Re: [PATCH] Input: i8042 - add noloop quirk for Dell Embedded Box PC 3000

2017-03-07 Thread Dmitry Torokhov
On Mon, Mar 06, 2017 at 07:48:18AM -0300, Marcos Paulo de Souza wrote: > On Mon, Mar 06, 2017 at 06:03:06PM +0800, Kai-Heng Feng wrote: > > The aux port does not get detected without noloop quirk, so external PS/2 > > mouse cannot work as result. > > > > The PS/2 mouse can work with this quirk. >

Re: [PATCH] Input: i8042 - add noloop quirk for Dell Embedded Box PC 3000

2017-03-07 Thread Dmitry Torokhov
On Mon, Mar 06, 2017 at 07:48:18AM -0300, Marcos Paulo de Souza wrote: > On Mon, Mar 06, 2017 at 06:03:06PM +0800, Kai-Heng Feng wrote: > > The aux port does not get detected without noloop quirk, so external PS/2 > > mouse cannot work as result. > > > > The PS/2 mouse can work with this quirk. >

Re: [PATCH] Input: i8042 - add noloop quirk for Dell Embedded Box PC 3000

2017-03-06 Thread Marcos Paulo de Souza
On Mon, Mar 06, 2017 at 06:03:06PM +0800, Kai-Heng Feng wrote: > The aux port does not get detected without noloop quirk, so external PS/2 > mouse cannot work as result. > > The PS/2 mouse can work with this quirk. > > BugLink: https://bugs.launchpad.net/bugs/1591053 > Signed-off-by: Kai-Heng

Re: [PATCH] Input: i8042 - add noloop quirk for Dell Embedded Box PC 3000

2017-03-06 Thread Marcos Paulo de Souza
On Mon, Mar 06, 2017 at 06:03:06PM +0800, Kai-Heng Feng wrote: > The aux port does not get detected without noloop quirk, so external PS/2 > mouse cannot work as result. > > The PS/2 mouse can work with this quirk. > > BugLink: https://bugs.launchpad.net/bugs/1591053 > Signed-off-by: Kai-Heng

[PATCH] Input: i8042 - add noloop quirk for Dell Embedded Box PC 3000

2017-03-06 Thread Kai-Heng Feng
The aux port does not get detected without noloop quirk, so external PS/2 mouse cannot work as result. The PS/2 mouse can work with this quirk. BugLink: https://bugs.launchpad.net/bugs/1591053 Signed-off-by: Kai-Heng Feng --- drivers/input/serio/i8042-x86ia64io.h |

[PATCH] Input: i8042 - add noloop quirk for Dell Embedded Box PC 3000

2017-03-06 Thread Kai-Heng Feng
The aux port does not get detected without noloop quirk, so external PS/2 mouse cannot work as result. The PS/2 mouse can work with this quirk. BugLink: https://bugs.launchpad.net/bugs/1591053 Signed-off-by: Kai-Heng Feng --- drivers/input/serio/i8042-x86ia64io.h | 7 +++ 1 file changed, 7

Re: [PATCH] Input: i8042 - add TUXEDO BU1406 (N24_25BU) to the nomux list

2017-02-28 Thread Marcos Paulo de Souza
On Tue, Feb 28, 2017 at 05:20:57PM -0800, Dmitry Torokhov wrote: > TUXEDO BU1406 does not implement active multiplexing mode properly, > and takes around 550 ms in i8042_set_mux_mode(). Given that the > device does not have external AUX port, there is no downside in > disabling the MUX mode. > >

Re: [PATCH] Input: i8042 - add TUXEDO BU1406 (N24_25BU) to the nomux list

2017-02-28 Thread Marcos Paulo de Souza
On Tue, Feb 28, 2017 at 05:20:57PM -0800, Dmitry Torokhov wrote: > TUXEDO BU1406 does not implement active multiplexing mode properly, > and takes around 550 ms in i8042_set_mux_mode(). Given that the > device does not have external AUX port, there is no downside in > disabling the MUX mode. > >

[PATCH] Input: i8042 - add TUXEDO BU1406 (N24_25BU) to the nomux list

2017-02-28 Thread Dmitry Torokhov
TUXEDO BU1406 does not implement active multiplexing mode properly, and takes around 550 ms in i8042_set_mux_mode(). Given that the device does not have external AUX port, there is no downside in disabling the MUX mode. Reported-by: Paul Menzel Suggested-by: Vojtech Pavlik

[PATCH] Input: i8042 - add TUXEDO BU1406 (N24_25BU) to the nomux list

2017-02-28 Thread Dmitry Torokhov
TUXEDO BU1406 does not implement active multiplexing mode properly, and takes around 550 ms in i8042_set_mux_mode(). Given that the device does not have external AUX port, there is no downside in disabling the MUX mode. Reported-by: Paul Menzel Suggested-by: Vojtech Pavlik Signed-off-by: Dmitry

Re: [PATCH] input: i8042-x86ia64io.h: Add Pegatron touchpad to noloop table

2016-12-18 Thread Dmitry Torokhov
On Sat, Dec 17, 2016 at 12:19:34AM -0200, Marcos Paulo de Souza wrote: > Avoid AUX loopback in Pegatron C15B touchpad, so input subsystem is able > to recognize a synaptics touchpad in the AUX port. > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=93791 > (Touchpad is not detected on DNS

Re: [PATCH] input: i8042-x86ia64io.h: Add Pegatron touchpad to noloop table

2016-12-18 Thread Dmitry Torokhov
On Sat, Dec 17, 2016 at 12:19:34AM -0200, Marcos Paulo de Souza wrote: > Avoid AUX loopback in Pegatron C15B touchpad, so input subsystem is able > to recognize a synaptics touchpad in the AUX port. > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=93791 > (Touchpad is not detected on DNS

[PATCH] input: i8042-x86ia64io.h: Add Pegatron touchpad to noloop table

2016-12-16 Thread Marcos Paulo de Souza
Avoid AUX loopback in Pegatron C15B touchpad, so input subsystem is able to recognize a synaptics touchpad in the AUX port. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=93791 (Touchpad is not detected on DNS 0801480 notebook (PEGATRON C15B)) Suggested-by: Dmitry Torokhov

[PATCH] input: i8042-x86ia64io.h: Add Pegatron touchpad to noloop table

2016-12-16 Thread Marcos Paulo de Souza
Avoid AUX loopback in Pegatron C15B touchpad, so input subsystem is able to recognize a synaptics touchpad in the AUX port. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=93791 (Touchpad is not detected on DNS 0801480 notebook (PEGATRON C15B)) Suggested-by: Dmitry Torokhov Signed-off-by:

Re: [PATCH] Input: i8042 - force synchronous probing of PNP drivers

2016-12-16 Thread Luis R. Rodriguez
On Tue, Dec 13, 2016 at 09:56:32AM -0800, Dmitry Torokhov wrote: > We rely on the result of scanning PNP bus for keyboard and mouse devices to > decide whether we should continue initialization of i8042 driver or not, so > the probes can not be asynchronous. Can initializing of i8042 driver

Re: [PATCH] Input: i8042 - force synchronous probing of PNP drivers

2016-12-16 Thread Luis R. Rodriguez
On Tue, Dec 13, 2016 at 09:56:32AM -0800, Dmitry Torokhov wrote: > We rely on the result of scanning PNP bus for keyboard and mouse devices to > decide whether we should continue initialization of i8042 driver or not, so > the probes can not be asynchronous. Can initializing of i8042 driver

[PATCH] Input: i8042 - force synchronous probing of PNP drivers

2016-12-13 Thread Dmitry Torokhov
We rely on the result of scanning PNP bus for keyboard and mouse devices to decide whether we should continue initialization of i8042 driver or not, so the probes can not be asynchronous. Also, it is not a good idea to unbind either of the PNP devices while i8042 is running, so let's disable

[PATCH] Input: i8042 - force synchronous probing of PNP drivers

2016-12-13 Thread Dmitry Torokhov
We rely on the result of scanning PNP bus for keyboard and mouse devices to decide whether we should continue initialization of i8042 driver or not, so the probes can not be asynchronous. Also, it is not a good idea to unbind either of the PNP devices while i8042 is running, so let's disable

Re: [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP

2016-12-09 Thread Dmitry Torokhov
On Fri, Dec 09, 2016 at 09:55:09PM -0200, Marcos Paulo de Souza wrote: > As this define check if huge, this makes easier to read the code. > > Signed-off-by: Marcos Paulo de Souza Applied, thank you. > --- > While reviewing patches from Dmitry about presence of

Re: [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP

2016-12-09 Thread Dmitry Torokhov
On Fri, Dec 09, 2016 at 09:55:09PM -0200, Marcos Paulo de Souza wrote: > As this define check if huge, this makes easier to read the code. > > Signed-off-by: Marcos Paulo de Souza Applied, thank you. > --- > While reviewing patches from Dmitry about presence of 8042, it makes it > much

[PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP

2016-12-09 Thread Marcos Paulo de Souza
As this define check if huge, this makes easier to read the code. Signed-off-by: Marcos Paulo de Souza --- While reviewing patches from Dmitry about presence of 8042, it makes it much easier to understand the ifdefs... drivers/input/serio/i8042-x86ia64io.h | 4

[PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG_PNP

2016-12-09 Thread Marcos Paulo de Souza
As this define check if huge, this makes easier to read the code. Signed-off-by: Marcos Paulo de Souza --- While reviewing patches from Dmitry about presence of 8042, it makes it much easier to understand the ifdefs... drivers/input/serio/i8042-x86ia64io.h | 4 ++-- 1 file changed, 2

Re: [PATCH] Input: i8042 - add XMG C504 to keyboard reset table

2016-10-19 Thread Dmitry Torokhov
On Thu, Sep 08, 2016 at 11:44:35PM +0200, Patrick Scheuring wrote: > From: Patrick Scheuring > > The Schenker XMG C504 is a rebranded Gigabyte P35 v2 laptop. > Therefore it also needs a keyboard reset to detect the Elantech touchpad. > Otherwise the touchpad

Re: [PATCH] Input: i8042 - add XMG C504 to keyboard reset table

2016-10-19 Thread Dmitry Torokhov
On Thu, Sep 08, 2016 at 11:44:35PM +0200, Patrick Scheuring wrote: > From: Patrick Scheuring > > The Schenker XMG C504 is a rebranded Gigabyte P35 v2 laptop. > Therefore it also needs a keyboard reset to detect the Elantech touchpad. > Otherwise the touchpad appears to be dead. > > With this

[PATCH] Input: i8042 - add XMG C504 to keyboard reset table

2016-09-08 Thread Patrick Scheuring
From: Patrick Scheuring The Schenker XMG C504 is a rebranded Gigabyte P35 v2 laptop. Therefore it also needs a keyboard reset to detect the Elantech touchpad. Otherwise the touchpad appears to be dead. With this patch the touchpad is detected: $ dmesg | grep -E

[PATCH] Input: i8042 - add XMG C504 to keyboard reset table

2016-09-08 Thread Patrick Scheuring
From: Patrick Scheuring The Schenker XMG C504 is a rebranded Gigabyte P35 v2 laptop. Therefore it also needs a keyboard reset to detect the Elantech touchpad. Otherwise the touchpad appears to be dead. With this patch the touchpad is detected: $ dmesg | grep -E "(i8042|Elantech|elantech)" [

[PATCH] Input: i8042, lower log level when controller_init fails

2016-07-25 Thread Jiri Slaby
There are a lot of machines without i8042 controller nowadays. Sometimes i8042_controller_check returns 0 because i8042_flush does nothing (read from the port returns 0 and the while loop does not execute). In that case, the probe method is called and fails with this error output to console:

[PATCH] Input: i8042, lower log level when controller_init fails

2016-07-25 Thread Jiri Slaby
There are a lot of machines without i8042 controller nowadays. Sometimes i8042_controller_check returns 0 because i8042_flush does nothing (read from the port returns 0 and the while loop does not execute). In that case, the probe method is called and fails with this error output to console:

Re: [PATCH] Input: i8042 add Fujitsu Lifebook U745 to the nomux list

2016-01-02 Thread Dmitry Torokhov
On Wed, Dec 30, 2015 at 01:14:23AM +0100, Aurélien Francillon wrote: > Without i8042.nomux=1 the Elantech touch pad is not working at all on > a Fujitsu Lifebook U745. This patch does not seem necessary for all > U745 (maybe because of different BIOS versions?). However, it was > verified that the

Re: [PATCH] Input: i8042 add Fujitsu Lifebook U745 to the nomux list

2016-01-02 Thread Dmitry Torokhov
On Wed, Dec 30, 2015 at 01:14:23AM +0100, Aurélien Francillon wrote: > Without i8042.nomux=1 the Elantech touch pad is not working at all on > a Fujitsu Lifebook U745. This patch does not seem necessary for all > U745 (maybe because of different BIOS versions?). However, it was > verified that the

  1   2   >