Re: [PATCH] Input: psmouse - clean up Cypress probe

2015-12-03 Thread Hans de Goede
Hi, On 04-12-15 00:56, Dmitry Torokhov wrote: When Cypress protocol support is disabled cypress_init() is a stub that always returns -ENOSYS, so there is not point in testing for CONFIG_MOUSE_PS2_CYPRESS after we decided that we are dealing with a Cypress device. Also, we should only be calling

[PATCH] Input: psmouse - clean up Cypress probe

2015-12-03 Thread Dmitry Torokhov
When Cypress protocol support is disabled cypress_init() is a stub that always returns -ENOSYS, so there is not point in testing for CONFIG_MOUSE_PS2_CYPRESS after we decided that we are dealing with a Cypress device. Also, we should only be calling cypress_detect() when set_properties argument is

Re: [PATCH] Input: psmouse - clean up Cypress probe

2015-12-03 Thread Hans de Goede
Hi, On 04-12-15 00:56, Dmitry Torokhov wrote: When Cypress protocol support is disabled cypress_init() is a stub that always returns -ENOSYS, so there is not point in testing for CONFIG_MOUSE_PS2_CYPRESS after we decided that we are dealing with a Cypress device. Also, we should only be calling

[PATCH] Input: psmouse - clean up Cypress probe

2015-12-03 Thread Dmitry Torokhov
When Cypress protocol support is disabled cypress_init() is a stub that always returns -ENOSYS, so there is not point in testing for CONFIG_MOUSE_PS2_CYPRESS after we decided that we are dealing with a Cypress device. Also, we should only be calling cypress_detect() when set_properties argument is