Re: [PATCH] KVM: nVMX: fix AD condition when handling EPT violation

2017-04-24 Thread Radim Krčmář
2017-04-14 13:10+0800, Paolo Bonzini: > More important: did kvm-unit-test catch the bug? It did; the bright side. :)

Re: [PATCH] KVM: nVMX: fix AD condition when handling EPT violation

2017-04-24 Thread Radim Krčmář
2017-04-14 13:10+0800, Paolo Bonzini: > More important: did kvm-unit-test catch the bug? It did; the bright side. :)

Re: [PATCH] KVM: nVMX: fix AD condition when handling EPT violation

2017-04-13 Thread Paolo Bonzini
On 14/04/2017 00:39, Radim Krčmář wrote: > I have introduced this bug when applying and simplifying Paolo's patch > as we agreed on the list. The original was "x &= ~y; if (z) x |= y;". > > Here is the story of a bad workflow: > > A maintainer was already testing with the intended change,

Re: [PATCH] KVM: nVMX: fix AD condition when handling EPT violation

2017-04-13 Thread Paolo Bonzini
On 14/04/2017 00:39, Radim Krčmář wrote: > I have introduced this bug when applying and simplifying Paolo's patch > as we agreed on the list. The original was "x &= ~y; if (z) x |= y;". > > Here is the story of a bad workflow: > > A maintainer was already testing with the intended change,

[PATCH] KVM: nVMX: fix AD condition when handling EPT violation

2017-04-13 Thread Radim Krčmář
I have introduced this bug when applying and simplifying Paolo's patch as we agreed on the list. The original was "x &= ~y; if (z) x |= y;". Here is the story of a bad workflow: A maintainer was already testing with the intended change, but it was applied only to a testing repo on a

[PATCH] KVM: nVMX: fix AD condition when handling EPT violation

2017-04-13 Thread Radim Krčmář
I have introduced this bug when applying and simplifying Paolo's patch as we agreed on the list. The original was "x &= ~y; if (z) x |= y;". Here is the story of a bad workflow: A maintainer was already testing with the intended change, but it was applied only to a testing repo on a