Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-30 Thread Lee Jones
On Thu, 29 Oct 2015, Javier Martinez Canillas wrote: > Hello Lee, > > On Thu, Oct 29, 2015 at 12:56 AM, Krzysztof Kozlowski > wrote: > > On 28.10.2015 23:38, Lee Jones wrote: > >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > >>> They are not maintainers according to your definition of

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-30 Thread Lee Jones
On Thu, 29 Oct 2015, Krzysztof Kozlowski wrote: > On 28.10.2015 23:38, Lee Jones wrote: > > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > >> They are not maintainers according to your definition of maintainer > >> that doesn't seem what most people agree with. > > > > "most people" so

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-30 Thread Lee Jones
On Thu, 29 Oct 2015, Javier Martinez Canillas wrote: > Hello Lee, > > On Thu, Oct 29, 2015 at 12:56 AM, Krzysztof Kozlowski > wrote: > > On 28.10.2015 23:38, Lee Jones wrote: > >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > >>> They are not maintainers

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-30 Thread Lee Jones
On Thu, 29 Oct 2015, Krzysztof Kozlowski wrote: > On 28.10.2015 23:38, Lee Jones wrote: > > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > >> They are not maintainers according to your definition of maintainer > >> that doesn't seem what most people agree with. > > > > "most people" so

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Thu, Oct 29, 2015 at 12:56 AM, Krzysztof Kozlowski wrote: > On 28.10.2015 23:38, Lee Jones wrote: >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >>> They are not maintainers according to your definition of maintainer >>> that doesn't seem what most people agree with. >> >>

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
On 28.10.2015 23:38, Lee Jones wrote: > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >> They are not maintainers according to your definition of maintainer >> that doesn't seem what most people agree with. > > "most people" so far are 3 people that I assume still want to be > Maintainers

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Bartlomiej Zolnierkiewicz
[ this time with full Cc: & context preserved ] Hi, On Wednesday, October 28, 2015 08:24:46 AM Lee Jones wrote: > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > > On Tue, 27 Oct 2015, Sebastian Reichel wrote: > > > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > > > Since

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Bartlomiej Zolnierkiewicz wrote: > On Wednesday, October 28, 2015 08:24:46 AM Lee Jones wrote: > > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > > > On Tue, 27 Oct 2015, Sebastian Reichel wrote: > > > > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > > >

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, [removed since we have been discussing the same back and forth] On Wed, Oct 28, 2015 at 3:38 PM, Lee Jones wrote: >> >> No need for that, I already explained my point of view several times >> and you just think I'm wrong because I don't agree with you. So let's >> just agree on

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Wed, Oct 28, 2015 at 2:34 PM, Lee Jones wrote: > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >> On Wed, Oct 28, 2015 at 1:14 PM, Lee Jones wrote: >> > On Wed, 28 Oct 2015, Lee Jones wrote: >> > >> >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >> >> >> >> > Hello

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > On Wed, Oct 28, 2015 at 2:34 PM, Lee Jones wrote: > > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > >> On Wed, Oct 28, 2015 at 1:14 PM, Lee Jones wrote: > >> > On Wed, 28 Oct 2015, Lee Jones wrote: > >> > > >> >> On Wed, 28 Oct

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > W dniu 28.10.2015 o 19:14, Lee Jones pisze: > > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > >> On 28.10.2015 17:24, Lee Jones wrote: > >>> On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > 2015-10-28 3:44 GMT+09:00 Joe Perches : > >

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > On Wed, Oct 28, 2015 at 1:14 PM, Lee Jones wrote: > > On Wed, 28 Oct 2015, Lee Jones wrote: > > > >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > >> > >> > Hello Joe, > >> > > >> > On Wed, Oct 28, 2015 at 12:06 PM, Joe Perches

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
W dniu 28.10.2015 o 19:14, Lee Jones pisze: > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: >> On 28.10.2015 17:24, Lee Jones wrote: >>> On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: 2015-10-28 3:44 GMT+09:00 Joe Perches : > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: >>

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
W dniu 28.10.2015 o 18:55, Lee Jones pisze: > On Wed, 28 Oct 2015, Uwe Kleine-König wrote: > >> Hello, >> >> On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote: >>> On 28.10.2015 17:24, Lee Jones wrote: You guys are pushing back like this is some kind of demotion.

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Wed, Oct 28, 2015 at 1:14 PM, Lee Jones wrote: > On Wed, 28 Oct 2015, Lee Jones wrote: > >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >> >> > Hello Joe, >> > >> > On Wed, Oct 28, 2015 at 12:06 PM, Joe Perches wrote: >> > > On Wed, 2015-10-28 at 11:53 +0100, Javier

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 12:24 +, Lee Jones wrote: > On Wed, 28 Oct 2015, Joe Perches wrote: > > On Wed, 2015-10-28 at 12:14 +, Lee Jones wrote: > > > Ah, but wait. get_maintainer.pl *does* assume M means Maintainer > > > doesn't it? > > > > No, it looks at the "S:" line. > > Right. Then

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Joe Perches wrote: > On Wed, 2015-10-28 at 12:14 +, Lee Jones wrote: > > Ah, but wait. get_maintainer.pl *does* assume M means Maintainer > > doesn't it? > > No, it looks at the "S:" line. Right. Then assumes because the driver is 'supported' or 'maintained' that the

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 12:14 +, Lee Jones wrote: > Ah, but wait. get_maintainer.pl *does* assume M means Maintainer > doesn't it? No, it looks at the "S:" line. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Lee Jones wrote: > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > > > Hello Joe, > > > > On Wed, Oct 28, 2015 at 12:06 PM, Joe Perches wrote: > > > On Wed, 2015-10-28 at 11:53 +0100, Javier Martinez Canillas wrote: > > >> (Lee) think(s) that the difference between

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > Hello Joe, > > On Wed, Oct 28, 2015 at 12:06 PM, Joe Perches wrote: > > On Wed, 2015-10-28 at 11:53 +0100, Javier Martinez Canillas wrote: > >> (Lee) think(s) that the difference between a maintainer and > >> a reviewer is if a branch with

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Joe, On Wed, Oct 28, 2015 at 12:06 PM, Joe Perches wrote: > On Wed, 2015-10-28 at 11:53 +0100, Javier Martinez Canillas wrote: >> (Lee) think(s) that the difference between a maintainer and >> a reviewer is if a branch with fixes / new features are kept and pull >> requests sent while I

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 11:53 +0100, Javier Martinez Canillas wrote: > (Lee) think(s) that the difference between a maintainer and > a reviewer is if a branch with fixes / new features are kept and pull > requests sent while I think that the difference is the level of > involvement someone has with

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Wed, Oct 28, 2015 at 11:28 AM, Lee Jones wrote: > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >> On Wed, Oct 28, 2015 at 9:24 AM, Lee Jones wrote: >> > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: >> >> On Tue, 27 Oct 2015, Sebastian Reichel wrote: >> >> > On Tue,

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > On Wed, Oct 28, 2015 at 9:24 AM, Lee Jones wrote: > > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > >> On Tue, 27 Oct 2015, Sebastian Reichel wrote: > >> > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > >> > > Since

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > On 28.10.2015 17:24, Lee Jones wrote: > > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > >> 2015-10-28 3:44 GMT+09:00 Joe Perches : > >>> On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > On Tue, 27 Oct 2015, Sebastian Reichel wrote:> >

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Uwe Kleine-König wrote: > Hello, > > On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote: > > On 28.10.2015 17:24, Lee Jones wrote: > > > You guys are pushing back like this is some kind of demotion. > > > That's not the case at all. All it does is better

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Uwe Kleine-König
Hello, On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote: > On 28.10.2015 17:24, Lee Jones wrote: > > You guys are pushing back like this is some kind of demotion. > > That's not the case at all. All it does is better describe the (very > > worthy) function you *actually*

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
On 28.10.2015 18:21, Javier Martinez Canillas wrote: > Hello Lee, > (...) Let me only add something to certain part of your email... >> But you aren't maintaining the driver i.e. you don't collect patches >> and *maintain* them on an upstream branch. Granted some of you guys >> are doing a

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
On Wed, Oct 28, 2015 at 10:21 AM, Javier Martinez Canillas wrote: > > We do have in fact different tags for each type of involvement so I > usually answer with a Reviewed-by tag if I review code for a subsystem > I care but I don't maintainer or answer with an Acked-by tag if I > review *and

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
On 28.10.2015 17:24, Lee Jones wrote: > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: >> 2015-10-28 3:44 GMT+09:00 Joe Perches : >>> On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: On Tue, 27 Oct 2015, Sebastian Reichel wrote:> > > I think you should CC the people, which are changed

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Wed, Oct 28, 2015 at 9:24 AM, Lee Jones wrote: > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: >> On Tue, 27 Oct 2015, Sebastian Reichel wrote: >> > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: >> > > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Chanwoo Choi
Hi Lee, On 2015년 10월 28일 00:42, Lee Jones wrote: > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > have been able to tag specific people as Reviewers. These are key > individuals who are tasked with or volunteer to review code submitted > to a subsystem or specific file.

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > On Tue, 27 Oct 2015, Sebastian Reichel wrote: > > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > > > have been able to tag specific people as Reviewers.

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > Hello Joe, > > On Wed, Oct 28, 2015 at 12:06 PM, Joe Perches wrote: > > On Wed, 2015-10-28 at 11:53 +0100, Javier Martinez Canillas wrote: > >> (Lee) think(s) that the difference between a maintainer and > >> a reviewer is

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 12:14 +, Lee Jones wrote: > Ah, but wait. get_maintainer.pl *does* assume M means Maintainer > doesn't it? No, it looks at the "S:" line. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Wed, Oct 28, 2015 at 1:14 PM, Lee Jones wrote: > On Wed, 28 Oct 2015, Lee Jones wrote: > >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >> >> > Hello Joe, >> > >> > On Wed, Oct 28, 2015 at 12:06 PM, Joe Perches wrote: >> > > On Wed,

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
W dniu 28.10.2015 o 19:14, Lee Jones pisze: > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: >> On 28.10.2015 17:24, Lee Jones wrote: >>> On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: 2015-10-28 3:44 GMT+09:00 Joe Perches : > On Tue, 2015-10-27 at 18:15 +, Lee

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > W dniu 28.10.2015 o 19:14, Lee Jones pisze: > > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > >> On 28.10.2015 17:24, Lee Jones wrote: > >>> On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > 2015-10-28 3:44 GMT+09:00 Joe Perches

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Lee Jones wrote: > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > > > Hello Joe, > > > > On Wed, Oct 28, 2015 at 12:06 PM, Joe Perches wrote: > > > On Wed, 2015-10-28 at 11:53 +0100, Javier Martinez Canillas wrote: > > >> (Lee) think(s) that the

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 11:53 +0100, Javier Martinez Canillas wrote: > (Lee) think(s) that the difference between a maintainer and > a reviewer is if a branch with fixes / new features are kept and pull > requests sent while I think that the difference is the level of > involvement someone has with

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Joe, On Wed, Oct 28, 2015 at 12:06 PM, Joe Perches wrote: > On Wed, 2015-10-28 at 11:53 +0100, Javier Martinez Canillas wrote: >> (Lee) think(s) that the difference between a maintainer and >> a reviewer is if a branch with fixes / new features are kept and pull >>

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
W dniu 28.10.2015 o 18:55, Lee Jones pisze: > On Wed, 28 Oct 2015, Uwe Kleine-König wrote: > >> Hello, >> >> On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote: >>> On 28.10.2015 17:24, Lee Jones wrote: You guys are pushing back like this is some kind of demotion.

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > On Wed, Oct 28, 2015 at 1:14 PM, Lee Jones wrote: > > On Wed, 28 Oct 2015, Lee Jones wrote: > > > >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > >> > >> > Hello Joe, > >> > > >> > On Wed, Oct 28, 2015 at 12:06

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Joe Perches wrote: > On Wed, 2015-10-28 at 12:14 +, Lee Jones wrote: > > Ah, but wait. get_maintainer.pl *does* assume M means Maintainer > > doesn't it? > > No, it looks at the "S:" line. Right. Then assumes because the driver is 'supported' or 'maintained' that the

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Joe Perches
On Wed, 2015-10-28 at 12:24 +, Lee Jones wrote: > On Wed, 28 Oct 2015, Joe Perches wrote: > > On Wed, 2015-10-28 at 12:14 +, Lee Jones wrote: > > > Ah, but wait. get_maintainer.pl *does* assume M means Maintainer > > > doesn't it? > > > > No, it looks at the "S:" line. > > Right. Then

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > On Wed, Oct 28, 2015 at 2:34 PM, Lee Jones wrote: > > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > >> On Wed, Oct 28, 2015 at 1:14 PM, Lee Jones wrote: > >> > On Wed, 28 Oct 2015, Lee

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, [removed since we have been discussing the same back and forth] On Wed, Oct 28, 2015 at 3:38 PM, Lee Jones wrote: >> >> No need for that, I already explained my point of view several times >> and you just think I'm wrong because I don't agree with you. So let's

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Wed, Oct 28, 2015 at 2:34 PM, Lee Jones wrote: > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >> On Wed, Oct 28, 2015 at 1:14 PM, Lee Jones wrote: >> > On Wed, 28 Oct 2015, Lee Jones wrote: >> > >> >> On Wed, 28 Oct 2015, Javier

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > On Tue, 27 Oct 2015, Sebastian Reichel wrote: > > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > > > have been able to tag specific people as Reviewers.

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Uwe Kleine-König wrote: > Hello, > > On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote: > > On 28.10.2015 17:24, Lee Jones wrote: > > > You guys are pushing back like this is some kind of demotion. > > > That's not the case at all. All it does is better

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > On 28.10.2015 17:24, Lee Jones wrote: > > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: > >> 2015-10-28 3:44 GMT+09:00 Joe Perches : > >>> On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > On Tue, 27 Oct 2015, Sebastian

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Bartlomiej Zolnierkiewicz
[ this time with full Cc: & context preserved ] Hi, On Wednesday, October 28, 2015 08:24:46 AM Lee Jones wrote: > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > > On Tue, 27 Oct 2015, Sebastian Reichel wrote: > > > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > > > Since

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Bartlomiej Zolnierkiewicz wrote: > On Wednesday, October 28, 2015 08:24:46 AM Lee Jones wrote: > > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > > > On Tue, 27 Oct 2015, Sebastian Reichel wrote: > > > > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > > >

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
On 28.10.2015 23:38, Lee Jones wrote: > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >> They are not maintainers according to your definition of maintainer >> that doesn't seem what most people agree with. > > "most people" so far are 3 people that I assume still want to be > Maintainers

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Thu, Oct 29, 2015 at 12:56 AM, Krzysztof Kozlowski wrote: > On 28.10.2015 23:38, Lee Jones wrote: >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >>> They are not maintainers according to your definition of maintainer >>> that doesn't seem what most

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
On 28.10.2015 17:24, Lee Jones wrote: > On Wed, 28 Oct 2015, Krzysztof Kozlowski wrote: >> 2015-10-28 3:44 GMT+09:00 Joe Perches : >>> On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: On Tue, 27 Oct 2015, Sebastian Reichel wrote:> > > I think you should CC the people,

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Chanwoo Choi
Hi Lee, On 2015년 10월 28일 00:42, Lee Jones wrote: > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > have been able to tag specific people as Reviewers. These are key > individuals who are tasked with or volunteer to review code submitted > to a subsystem or specific file.

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Wed, Oct 28, 2015 at 9:24 AM, Lee Jones wrote: > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: >> On Tue, 27 Oct 2015, Sebastian Reichel wrote: >> > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: >> > > Since eafbaac ("MAINTAINERS: Add "R:"

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
On Wed, Oct 28, 2015 at 10:21 AM, Javier Martinez Canillas wrote: > > We do have in fact different tags for each type of involvement so I > usually answer with a Reviewed-by tag if I review code for a subsystem > I care but I don't maintainer or answer with an Acked-by tag if

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Krzysztof Kozlowski
On 28.10.2015 18:21, Javier Martinez Canillas wrote: > Hello Lee, > (...) Let me only add something to certain part of your email... >> But you aren't maintaining the driver i.e. you don't collect patches >> and *maintain* them on an upstream branch. Granted some of you guys >> are doing a

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Uwe Kleine-König
Hello, On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote: > On 28.10.2015 17:24, Lee Jones wrote: > > You guys are pushing back like this is some kind of demotion. > > That's not the case at all. All it does is better describe the (very > > worthy) function you *actually*

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Lee Jones
On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: > On Wed, Oct 28, 2015 at 9:24 AM, Lee Jones wrote: > > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > >> On Tue, 27 Oct 2015, Sebastian Reichel wrote: > >> > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-28 Thread Javier Martinez Canillas
Hello Lee, On Wed, Oct 28, 2015 at 11:28 AM, Lee Jones wrote: > On Wed, 28 Oct 2015, Javier Martinez Canillas wrote: >> On Wed, Oct 28, 2015 at 9:24 AM, Lee Jones wrote: >> > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: >> >> On Tue, 27 Oct

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Krzysztof Kozlowski
2015-10-28 3:44 GMT+09:00 Joe Perches : > > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > > On Tue, 27 Oct 2015, Sebastian Reichel wrote:> > > > > I think you should CC the people, which are changed from "M:" to > > > "R:", though. > > > > Yes, makes sense. > > > > I'd like to collect some

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Joe Perches
On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > On Tue, 27 Oct 2015, Sebastian Reichel wrote: > > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > > > have been able to tag specific people as Reviewers.

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Lee Jones
On Tue, 27 Oct 2015, Sebastian Reichel wrote: > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > > have been able to tag specific people as Reviewers. These are key > > individuals who are tasked with or volunteer

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Sebastian Reichel
Hi, On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > have been able to tag specific people as Reviewers. These are key > individuals who are tasked with or volunteer to review code submitted > to a subsystem or

[PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Lee Jones
Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we have been able to tag specific people as Reviewers. These are key individuals who are tasked with or volunteer to review code submitted to a subsystem or specific file. However, according to MAINTAINERS we have 1046 Maintainers

[PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Lee Jones
Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we have been able to tag specific people as Reviewers. These are key individuals who are tasked with or volunteer to review code submitted to a subsystem or specific file. However, according to MAINTAINERS we have 1046 Maintainers

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Joe Perches
On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > On Tue, 27 Oct 2015, Sebastian Reichel wrote: > > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > > > have been able to tag specific people as Reviewers.

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Sebastian Reichel
Hi, On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > have been able to tag specific people as Reviewers. These are key > individuals who are tasked with or volunteer to review code submitted > to a subsystem or

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Lee Jones
On Tue, 27 Oct 2015, Sebastian Reichel wrote: > On Tue, Oct 27, 2015 at 03:42:37PM +, Lee Jones wrote: > > Since eafbaac ("MAINTAINERS: Add "R:" designated-reviewers tag") we > > have been able to tag specific people as Reviewers. These are key > > individuals who are tasked with or volunteer

Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

2015-10-27 Thread Krzysztof Kozlowski
2015-10-28 3:44 GMT+09:00 Joe Perches : > > On Tue, 2015-10-27 at 18:15 +, Lee Jones wrote: > > On Tue, 27 Oct 2015, Sebastian Reichel wrote:> > > > > I think you should CC the people, which are changed from "M:" to > > > "R:", though. > > > > Yes, makes sense. > > > > I'd