Re: [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()

2014-07-06 Thread Maciej W. Rozycki
On Sun, 6 Jul 2014, Jonas Gorski wrote: > On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode wrote: > > We check that the struct vm_area_struct pointer vma is NULL and then > > dereference it a few lines below. The intent was to make sure vma is > > not NULL but this is not necessary since the bug

Re: [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()

2014-07-06 Thread Jonas Gorski
On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode wrote: > We check that the struct vm_area_struct pointer vma is NULL and then > dereference it a few lines below. The intent was to make sure vma is > not NULL but this is not necessary since the bug pre-dates GIT history > and seem to never have caused

Re: [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()

2014-07-06 Thread Jonas Gorski
On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode emilgo...@gmail.com wrote: We check that the struct vm_area_struct pointer vma is NULL and then dereference it a few lines below. The intent was to make sure vma is not NULL but this is not necessary since the bug pre-dates GIT history and seem to

Re: [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()

2014-07-06 Thread Maciej W. Rozycki
On Sun, 6 Jul 2014, Jonas Gorski wrote: On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode emilgo...@gmail.com wrote: We check that the struct vm_area_struct pointer vma is NULL and then dereference it a few lines below. The intent was to make sure vma is not NULL but this is not necessary since

[PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()

2014-07-05 Thread Emil Goode
We check that the struct vm_area_struct pointer vma is NULL and then dereference it a few lines below. The intent was to make sure vma is not NULL but this is not necessary since the bug pre-dates GIT history and seem to never have caused a problem. The tlb-4k and tlb-8k versions of

[PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()

2014-07-05 Thread Emil Goode
We check that the struct vm_area_struct pointer vma is NULL and then dereference it a few lines below. The intent was to make sure vma is not NULL but this is not necessary since the bug pre-dates GIT history and seem to never have caused a problem. The tlb-4k and tlb-8k versions of