Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-22 Thread kbuild test robot
Hi Rafael, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-22 Thread kbuild test robot
Hi Rafael, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-17 Thread Rafael J. Wysocki
On Fri, Sep 14, 2018 at 2:41 PM Thomas Gleixner wrote: > > On Fri, 14 Sep 2018, Rafael J. Wysocki wrote: > > On Fri, Sep 14, 2018 at 11:53 AM Mika Penttilä > > > > >> But doesn't injecting sleep time here make monotonic clock too large > > > >> by the amount of sleeptime? tick_freeze() /

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-17 Thread Rafael J. Wysocki
On Fri, Sep 14, 2018 at 2:41 PM Thomas Gleixner wrote: > > On Fri, 14 Sep 2018, Rafael J. Wysocki wrote: > > On Fri, Sep 14, 2018 at 11:53 AM Mika Penttilä > > > > >> But doesn't injecting sleep time here make monotonic clock too large > > > >> by the amount of sleeptime? tick_freeze() /

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Thomas Gleixner
On Fri, 14 Sep 2018, Rafael J. Wysocki wrote: > On Fri, Sep 14, 2018 at 11:53 AM Mika Penttilä > > >> But doesn't injecting sleep time here make monotonic clock too large > > >> by the amount of sleeptime? tick_freeze() / tick_unfreeze() already > > >> injects the sleeptime (otherwise delta

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Thomas Gleixner
On Fri, 14 Sep 2018, Rafael J. Wysocki wrote: > On Fri, Sep 14, 2018 at 11:53 AM Mika Penttilä > > >> But doesn't injecting sleep time here make monotonic clock too large > > >> by the amount of sleeptime? tick_freeze() / tick_unfreeze() already > > >> injects the sleeptime (otherwise delta

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Rafael J. Wysocki
On Fri, Sep 14, 2018 at 11:53 AM Mika Penttilä wrote: > > On 09/14/2018 11:46 AM, Rafael J. Wysocki wrote: > > On Friday, September 14, 2018 10:28:44 AM CEST Mika Penttilä wrote: > >> Hi! > >> > >> > >> On 09/14/2018 09:59 AM, Rafael J. Wysocki wrote: > >>> From: Rafael J. Wysocki > >>> > >>>

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Rafael J. Wysocki
On Fri, Sep 14, 2018 at 11:53 AM Mika Penttilä wrote: > > On 09/14/2018 11:46 AM, Rafael J. Wysocki wrote: > > On Friday, September 14, 2018 10:28:44 AM CEST Mika Penttilä wrote: > >> Hi! > >> > >> > >> On 09/14/2018 09:59 AM, Rafael J. Wysocki wrote: > >>> From: Rafael J. Wysocki > >>> > >>>

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Mika Penttilä
On 09/14/2018 11:46 AM, Rafael J. Wysocki wrote: > On Friday, September 14, 2018 10:28:44 AM CEST Mika Penttilä wrote: >> Hi! >> >> >> On 09/14/2018 09:59 AM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> There is a difference in behavior between suspend-to-idle and >>>

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Mika Penttilä
On 09/14/2018 11:46 AM, Rafael J. Wysocki wrote: > On Friday, September 14, 2018 10:28:44 AM CEST Mika Penttilä wrote: >> Hi! >> >> >> On 09/14/2018 09:59 AM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> There is a difference in behavior between suspend-to-idle and >>>

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Rafael J. Wysocki
On Friday, September 14, 2018 10:28:44 AM CEST Mika Penttilä wrote: > Hi! > > > On 09/14/2018 09:59 AM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > There is a difference in behavior between suspend-to-idle and > > suspend-to-RAM in the timekeeping handling that leads to

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Rafael J. Wysocki
On Friday, September 14, 2018 10:28:44 AM CEST Mika Penttilä wrote: > Hi! > > > On 09/14/2018 09:59 AM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > There is a difference in behavior between suspend-to-idle and > > suspend-to-RAM in the timekeeping handling that leads to

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Mika Penttilä
Hi! On 09/14/2018 09:59 AM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > There is a difference in behavior between suspend-to-idle and > suspend-to-RAM in the timekeeping handling that leads to functional > issues. Namely, every iteration of the loop in s2idle_loop() > increases the

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Mika Penttilä
Hi! On 09/14/2018 09:59 AM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > There is a difference in behavior between suspend-to-idle and > suspend-to-RAM in the timekeeping handling that leads to functional > issues. Namely, every iteration of the loop in s2idle_loop() > increases the

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Peter Zijlstra
On Fri, Sep 14, 2018 at 09:47:28AM +0200, Rafael J. Wysocki wrote: > On Fri, Sep 14, 2018 at 9:41 AM Peter Zijlstra wrote: > > Do we want a 'warning' of sorts when the delta becomes significant (for > > whatever that is) ? That might be an indication that there are frequent > > wakeups which we

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Peter Zijlstra
On Fri, Sep 14, 2018 at 09:47:28AM +0200, Rafael J. Wysocki wrote: > On Fri, Sep 14, 2018 at 9:41 AM Peter Zijlstra wrote: > > Do we want a 'warning' of sorts when the delta becomes significant (for > > whatever that is) ? That might be an indication that there are frequent > > wakeups which we

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Rafael J. Wysocki
On Fri, Sep 14, 2018 at 9:41 AM Peter Zijlstra wrote: > > On Fri, Sep 14, 2018 at 08:59:03AM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > There is a difference in behavior between suspend-to-idle and > > suspend-to-RAM in the timekeeping handling that leads to functional >

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Rafael J. Wysocki
On Fri, Sep 14, 2018 at 9:41 AM Peter Zijlstra wrote: > > On Fri, Sep 14, 2018 at 08:59:03AM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > There is a difference in behavior between suspend-to-idle and > > suspend-to-RAM in the timekeeping handling that leads to functional >

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Peter Zijlstra
On Fri, Sep 14, 2018 at 08:59:03AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > There is a difference in behavior between suspend-to-idle and > suspend-to-RAM in the timekeeping handling that leads to functional > issues. Namely, every iteration of the loop in s2idle_loop() >

Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Peter Zijlstra
On Fri, Sep 14, 2018 at 08:59:03AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > There is a difference in behavior between suspend-to-idle and > suspend-to-RAM in the timekeeping handling that leads to functional > issues. Namely, every iteration of the loop in s2idle_loop() >

[PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki There is a difference in behavior between suspend-to-idle and suspend-to-RAM in the timekeeping handling that leads to functional issues. Namely, every iteration of the loop in s2idle_loop() increases the monotinic clock somewhat, even if timekeeping_suspend() and

[PATCH] PM / suspend: Count suspend-to-idle loop as sleep time

2018-09-14 Thread Rafael J. Wysocki
From: Rafael J. Wysocki There is a difference in behavior between suspend-to-idle and suspend-to-RAM in the timekeeping handling that leads to functional issues. Namely, every iteration of the loop in s2idle_loop() increases the monotinic clock somewhat, even if timekeeping_suspend() and