Re: [PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Nick Krause
Greg KH wrote on July 9th at 1:19 P.M. Ok, this has been fun to watch on lkml for a while now, but really, please, just stop doing this. Randomly searching the kernel source for FIXME lines and just commenting them out, isn't ok. Almost always, those lines are there because the original

Re: [PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Greg KH
Ok, this has been fun to watch on lkml for a while now, but really, please, just stop doing this. Randomly searching the kernel source for FIXME lines and just commenting them out, isn't ok. Almost always, those lines are there because the original developer really doesn't know how else to

[PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Nicholas Krause
This patch removes a fixme message in this file for setting the usb 2 speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be shared for the other things on the board with the usb chipset. Signed-off-by: Nicholas Krause ---

Re: [PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Sergei Shtylyov
Hello. On 07/09/2014 05:58 AM, Nicholas Krause wrote: This patch removes a fixme message in this file:wq for setting the usb 2 The vim's commands interspersed with text? :-) speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be

Re: [PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Uwe Kleine-König
On Tue, Jul 08, 2014 at 09:58:39PM -0400, Nicholas Krause wrote: > This patch removes a fixme message in this file:wq for setting the usb 2 :wq? > speed on the board to the correct level. We need to depend on the > bootloader for doing this as the wires may be shared for the other > things on the

Re: [PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Sergei Shtylyov
Hello. On 07/09/2014 05:58 AM, Nicholas Krause wrote: This patch removes a fixme message in this file:wq for setting the usb 2 The vim's commands interspersed with text? :-) speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be

[PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Nicholas Krause
This patch removes a fixme message in this file for setting the usb 2 speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be shared for the other things on the board with the usb chipset. Signed-off-by: Nicholas Krause xerofo...@gmail.com

Re: [PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Greg KH
Ok, this has been fun to watch on lkml for a while now, but really, please, just stop doing this. Randomly searching the kernel source for FIXME lines and just commenting them out, isn't ok. Almost always, those lines are there because the original developer really doesn't know how else to

Re: [PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Nick Krause
Greg KH wrote on July 9th at 1:19 P.M. Ok, this has been fun to watch on lkml for a while now, but really, please, just stop doing this. Randomly searching the kernel source for FIXME lines and just commenting them out, isn't ok. Almost always, those lines are there because the original

Re: [PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Uwe Kleine-König
On Tue, Jul 08, 2014 at 09:58:39PM -0400, Nicholas Krause wrote: This patch removes a fixme message in this file:wq for setting the usb 2 :wq? speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be shared for the other things on the

Re: [PATCH] Removes FIXME message in usb.c

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 09:58:39PM -0400, Nicholas Krause wrote: > This patch removes a fixme message in this file:wq for setting the usb 2 I don't think you did this correctly :) > speed on the board to the correct level. We need to depend on the > bootloader for doing this as the wires may be

[PATCH] Removes FIXME message in usb.c

2014-07-08 Thread Nicholas Krause
This patch removes a fixme message in this file:wq for setting the usb 2 speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be shared for the other things on the board with the usb chipset. Signed-off-by: Nicholas Krause ---

[PATCH] Removes FIXME message in usb.c

2014-07-08 Thread Nicholas Krause
This patch removes a fixme message in this file:wq for setting the usb 2 speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be shared for the other things on the board with the usb chipset. Signed-off-by: Nicholas Krause

Re: [PATCH] Removes FIXME message in usb.c

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 09:58:39PM -0400, Nicholas Krause wrote: This patch removes a fixme message in this file:wq for setting the usb 2 I don't think you did this correctly :) speed on the board to the correct level. We need to depend on the bootloader for doing this as the wires may be