Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Thomas Glanzmann
Hello Eric, > Hmm.. I was not aware of high RTT for some packets. > Can you spot this on the pcap you provided ? with the latest patch as in: (node-62) [~/work/linux-2.6] git diff | pbot http://pbot.rmdir.de/CQwqI6b7wJProw_xaukmEg with net.ipv4.tcp_min_tso_segs=2 we had this pcap:

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Thomas Glanzmann
Hello Eric, > Also please make sure you have this patch : > http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=4a5ab4e224288403b0b4b6b8c4d339323150c312 I did not have this patch. I apply it, rerun and send you the pcap. (node-62) [~/work/linux-2.6] wcat

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Eric Dumazet
On Mon, 2014-02-10 at 13:01 -0800, Eric Dumazet wrote: > On Mon, 2014-02-10 at 21:56 +0100, Thomas Glanzmann wrote: > > Hello Nab, > > > > > This looks correct to me. Thomas, once your able to confirm please > > > include your 'Tested-by' and I'll include for the next -rc3 PULL > > > request. >

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Eric Dumazet
On Mon, 2014-02-10 at 21:56 +0100, Thomas Glanzmann wrote: > Hello Nab, > > > This looks correct to me. Thomas, once your able to confirm please > > include your 'Tested-by' and I'll include for the next -rc3 PULL > > request. > > Eric is currently reviewing our latest iteration with MSG_MORE

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Thomas Glanzmann
Hello Nab, > This looks correct to me. Thomas, once your able to confirm please > include your 'Tested-by' and I'll include for the next -rc3 PULL > request. Eric is currently reviewing our latest iteration with MSG_MORE for kernel_sendmsg and MSG_MORE | MSG_SENDPAGE_NOTLAST for sendpage.

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Nicholas A. Bellinger
Hi Eric & Thomas, On Sun, 2014-02-09 at 04:30 -0800, Eric Dumazet wrote: > On Sun, 2014-02-09 at 08:42 +0100, Eric Dumazet wrote: > > The new infrastructure is used in iscsit_fe_sendpage_sg to avoid sending > > three > > TCP packets instead of one by settings the MSG_MORE when calling > >

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Nicholas A. Bellinger
Hi Eric Thomas, On Sun, 2014-02-09 at 04:30 -0800, Eric Dumazet wrote: On Sun, 2014-02-09 at 08:42 +0100, Eric Dumazet wrote: The new infrastructure is used in iscsit_fe_sendpage_sg to avoid sending three TCP packets instead of one by settings the MSG_MORE when calling kernel_sendmsg

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Thomas Glanzmann
Hello Nab, This looks correct to me. Thomas, once your able to confirm please include your 'Tested-by' and I'll include for the next -rc3 PULL request. Eric is currently reviewing our latest iteration with MSG_MORE for kernel_sendmsg and MSG_MORE | MSG_SENDPAGE_NOTLAST for sendpage. However

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Eric Dumazet
On Mon, 2014-02-10 at 21:56 +0100, Thomas Glanzmann wrote: Hello Nab, This looks correct to me. Thomas, once your able to confirm please include your 'Tested-by' and I'll include for the next -rc3 PULL request. Eric is currently reviewing our latest iteration with MSG_MORE for

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Eric Dumazet
On Mon, 2014-02-10 at 13:01 -0800, Eric Dumazet wrote: On Mon, 2014-02-10 at 21:56 +0100, Thomas Glanzmann wrote: Hello Nab, This looks correct to me. Thomas, once your able to confirm please include your 'Tested-by' and I'll include for the next -rc3 PULL request. Eric is

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Thomas Glanzmann
Hello Eric, Also please make sure you have this patch : http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=4a5ab4e224288403b0b4b6b8c4d339323150c312 I did not have this patch. I apply it, rerun and send you the pcap. (node-62) [~/work/linux-2.6] wcat

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-10 Thread Thomas Glanzmann
Hello Eric, Hmm.. I was not aware of high RTT for some packets. Can you spot this on the pcap you provided ? with the latest patch as in: (node-62) [~/work/linux-2.6] git diff | pbot http://pbot.rmdir.de/CQwqI6b7wJProw_xaukmEg with net.ipv4.tcp_min_tso_segs=2 we had this pcap:

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-09 Thread Thomas Glanzmann
Hello Eric, > 1) Use your own identity as the sender, not impersonate me. > ( thats standard convention ) sorry about that, will not happen ever again. > 2) Put following line as first line of the mail > ( Documentation/SubmittingPatches lines ~565) > From: Eric Dumazet > Then I'll add my :

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-09 Thread Eric Dumazet
On Sun, 2014-02-09 at 08:42 +0100, Eric Dumazet wrote: > The new infrastructure is used in iscsit_fe_sendpage_sg to avoid sending three > TCP packets instead of one by settings the MSG_MORE when calling > kernel_sendmsg > via the wrapper functions tx_data and iscsit_do_tx_data. This reduces the

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-09 Thread Eric Dumazet
On Sun, 2014-02-09 at 08:42 +0100, Eric Dumazet wrote: The new infrastructure is used in iscsit_fe_sendpage_sg to avoid sending three TCP packets instead of one by settings the MSG_MORE when calling kernel_sendmsg via the wrapper functions tx_data and iscsit_do_tx_data. This reduces the TCP

Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-09 Thread Thomas Glanzmann
Hello Eric, 1) Use your own identity as the sender, not impersonate me. ( thats standard convention ) sorry about that, will not happen ever again. 2) Put following line as first line of the mail ( Documentation/SubmittingPatches lines ~565) From: Eric Dumazet eduma...@google.com Then

[PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-08 Thread Eric Dumazet
The new infrastructure is used in iscsit_fe_sendpage_sg to avoid sending three TCP packets instead of one by settings the MSG_MORE when calling kernel_sendmsg via the wrapper functions tx_data and iscsit_do_tx_data. This reduces the TCP overhead by sending the same data in less TCP packets and

[PATCH] This extends tx_data and and iscsit_do_tx_data with the additional parameter flags and avoids sending multiple TCP packets in iscsit_fe_sendpage_sg

2014-02-08 Thread Eric Dumazet
The new infrastructure is used in iscsit_fe_sendpage_sg to avoid sending three TCP packets instead of one by settings the MSG_MORE when calling kernel_sendmsg via the wrapper functions tx_data and iscsit_do_tx_data. This reduces the TCP overhead by sending the same data in less TCP packets and