Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

kbuild test robot wrote: > >> fs/cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC' > SB_NOEXEC | SB_NOSUID | SB_NODEV) There's a missing '|' before SB_NOEXEC at the end of the preceding line. David

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

kbuild test robot wrote: > >> fs/cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC' > SB_NOEXEC | SB_NOSUID | SB_NODEV) There's a missing '|' before SB_NOEXEC at the end of the preceding line. David

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

Hi David, [auto build test WARNING on linus/master] [also build test WARNING on v4.12-rc4] [cannot apply to next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

Hi David, [auto build test WARNING on linus/master] [also build test WARNING on v4.12-rc4] [cannot apply to next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

Hi David, [auto build test ERROR on linus/master] [also build test ERROR on v4.12-rc4] [cannot apply to next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

Hi David, [auto build test ERROR on linus/master] [also build test ERROR on v4.12-rc4] [cannot apply to next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

Jeff Layton wrote: > I guess you mean stuff like affs_fill_super which does: > > sb->s_flags |= MS_NODEV | MS_NOSUID; > > It seems like it's doing that too late to be useful. Actually, after the change, it seems nothing actually tests SB_NOSUID, SB_NODEV or SB_NOEXEC,

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

Jeff Layton wrote: > I guess you mean stuff like affs_fill_super which does: > > sb->s_flags |= MS_NODEV | MS_NOSUID; > > It seems like it's doing that too late to be useful. Actually, after the change, it seems nothing actually tests SB_NOSUID, SB_NODEV or SB_NOEXEC, so those bits should

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

On Fri, 2017-06-09 at 16:01 +0100, David Howells wrote: > Differentiate the MS_* flags passed to mount(2) from the internal flags set > in the super_block's s_flags. s_flags are now called SB_*, with the names > and the values for the moment mirroring the MS_* flags that they're > equivalent to.

Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

On Fri, 2017-06-09 at 16:01 +0100, David Howells wrote: > Differentiate the MS_* flags passed to mount(2) from the internal flags set > in the super_block's s_flags. s_flags are now called SB_*, with the names > and the values for the moment mirroring the MS_* flags that they're > equivalent to.