Re: [PATCH] X86_64: hpet tsc calibration fix broken smi detection logic

2007-07-19 Thread Andi Kleen
Andrew Morton <[EMAIL PROTECTED]> writes: > > So I queued this, and then another patch to revert it so that the > x86_64-clockevents conversion would apply. But I was unable to locate the > corresponding bug in the post-x86_64-clockevents tree. Did it get fixed by > other means in there? Yes,

Re: [PATCH] X86_64: hpet tsc calibration fix broken smi detection logic

2007-07-19 Thread Andi Kleen
Andrew Morton [EMAIL PROTECTED] writes: So I queued this, and then another patch to revert it so that the x86_64-clockevents conversion would apply. But I was unable to locate the corresponding bug in the post-x86_64-clockevents tree. Did it get fixed by other means in there? Yes, the

Re: [PATCH] X86_64: hpet tsc calibration fix broken smi detection logic

2007-07-18 Thread Andrew Morton
On Sat, 14 Jul 2007 10:41:39 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > The current SMI detection logic in read_hpet_tsc() makes sure, > that when a SMI happens between the read of the HPET counter and > the read of the TSC, this wrong value is used for TSC calibration. > > This is not

Re: [PATCH] X86_64: hpet tsc calibration fix broken smi detection logic

2007-07-18 Thread Andrew Morton
On Sat, 14 Jul 2007 10:41:39 +0200 Thomas Gleixner [EMAIL PROTECTED] wrote: The current SMI detection logic in read_hpet_tsc() makes sure, that when a SMI happens between the read of the HPET counter and the read of the TSC, this wrong value is used for TSC calibration. This is not the

[PATCH] X86_64: hpet tsc calibration fix broken smi detection logic

2007-07-14 Thread Thomas Gleixner
The current SMI detection logic in read_hpet_tsc() makes sure, that when a SMI happens between the read of the HPET counter and the read of the TSC, this wrong value is used for TSC calibration. This is not the intention of the function. The comparison must ensure, that we do _NOT_ use such a

[PATCH] X86_64: hpet tsc calibration fix broken smi detection logic

2007-07-14 Thread Thomas Gleixner
The current SMI detection logic in read_hpet_tsc() makes sure, that when a SMI happens between the read of the HPET counter and the read of the TSC, this wrong value is used for TSC calibration. This is not the intention of the function. The comparison must ensure, that we do _NOT_ use such a