Re: [PATCH] async_tx: fix kmap_atomic usage in async_memcpy

2007-07-19 Thread Dan Williams
On 7/19/07, Andrew Morton <[EMAIL PROTECTED]> wrote: Neato. You (or at least, Shannon) run a git tree. I always get confused when git-tree-owners send me patches, because I expect them to put the patches into their git trees. So if you, a git-tree-owner, wish me to merge-test-and-forward a

Re: [PATCH] async_tx: fix kmap_atomic usage in async_memcpy

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 18:12:52 -0700 Dan Williams <[EMAIL PROTECTED]> wrote: > Andrew Morton: > [async_memcpy] is very wrong if both ASYNC_TX_KMAP_DST and > ASYNC_TX_KMAP_SRC can ever be set. We'll end up using the same kmap > slot for both src add dest and we get either

[PATCH] async_tx: fix kmap_atomic usage in async_memcpy

2007-07-19 Thread Dan Williams
Andrew Morton: [async_memcpy] is very wrong if both ASYNC_TX_KMAP_DST and ASYNC_TX_KMAP_SRC can ever be set. We'll end up using the same kmap slot for both src add dest and we get either corrupted data or a BUG. Evgeniy Polyakov: Btw, shouldn't it always be

[PATCH] async_tx: fix kmap_atomic usage in async_memcpy

2007-07-19 Thread Dan Williams
Andrew Morton: [async_memcpy] is very wrong if both ASYNC_TX_KMAP_DST and ASYNC_TX_KMAP_SRC can ever be set. We'll end up using the same kmap slot for both src add dest and we get either corrupted data or a BUG. Evgeniy Polyakov: Btw, shouldn't it always be

Re: [PATCH] async_tx: fix kmap_atomic usage in async_memcpy

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 18:12:52 -0700 Dan Williams [EMAIL PROTECTED] wrote: Andrew Morton: [async_memcpy] is very wrong if both ASYNC_TX_KMAP_DST and ASYNC_TX_KMAP_SRC can ever be set. We'll end up using the same kmap slot for both src add dest and we get either corrupted data

Re: [PATCH] async_tx: fix kmap_atomic usage in async_memcpy

2007-07-19 Thread Dan Williams
On 7/19/07, Andrew Morton [EMAIL PROTECTED] wrote: Neato. You (or at least, Shannon) run a git tree. I always get confused when git-tree-owners send me patches, because I expect them to put the patches into their git trees. So if you, a git-tree-owner, wish me to merge-test-and-forward a