Re: [PATCH] audit: process errors from filter user rules

2013-12-09 Thread Richard Guy Briggs
On 13/12/05, Eric Paris wrote: > I know we talked about this patch, and it seemed like a good idea at the > time, but honestly, these races are so rare, it isn't worth the code > complexity. I tried to simplify the readability of your code and got > something better, but still the loop is

Re: [PATCH] audit: process errors from filter user rules

2013-12-09 Thread Richard Guy Briggs
On 13/12/05, Eric Paris wrote: I know we talked about this patch, and it seemed like a good idea at the time, but honestly, these races are so rare, it isn't worth the code complexity. I tried to simplify the readability of your code and got something better, but still the loop is needless...

Re: [PATCH] audit: process errors from filter user rules

2013-12-05 Thread Eric Paris
I know we talked about this patch, and it seemed like a good idea at the time, but honestly, these races are so rare, it isn't worth the code complexity. I tried to simplify the readability of your code and got something better, but still the loop is needless... Just log the messages on any

Re: [PATCH] audit: process errors from filter user rules

2013-12-05 Thread Eric Paris
I know we talked about this patch, and it seemed like a good idea at the time, but honestly, these races are so rare, it isn't worth the code complexity. I tried to simplify the readability of your code and got something better, but still the loop is needless... Just log the messages on any

[PATCH] audit: process errors from filter user rules

2013-12-04 Thread Richard Guy Briggs
Errors from filter user rules were previously ignored, and worse, an error on a AUDIT_NEVER rule disabled logging on that rule. On -ESTALE, retry up to 5 times. On error on AUDIT_NEVER rules, log. Signed-off-by: Richard Guy Briggs --- kernel/audit.c |2 +- kernel/auditfilter.c |

[PATCH] audit: process errors from filter user rules

2013-12-04 Thread Richard Guy Briggs
Errors from filter user rules were previously ignored, and worse, an error on a AUDIT_NEVER rule disabled logging on that rule. On -ESTALE, retry up to 5 times. On error on AUDIT_NEVER rules, log. Signed-off-by: Richard Guy Briggs r...@redhat.com --- kernel/audit.c |2 +-