Re: [PATCH] be2net: Fix some u16 fields appropriately

2017-08-28 Thread David Miller
From: 严海双 Date: Tue, 29 Aug 2017 09:04:57 +0800 > The GET_TX_COMPL_BITS comes from amap_get which also returns a 32-bit value: It never returns a value with more than 16-bits of significance for this specific call. Please stop trying to be semantically clever

Re: [PATCH] be2net: Fix some u16 fields appropriately

2017-08-28 Thread David Miller
From: 严海双 Date: Tue, 29 Aug 2017 09:04:57 +0800 > The GET_TX_COMPL_BITS comes from amap_get which also returns a 32-bit value: It never returns a value with more than 16-bits of significance for this specific call. Please stop trying to be semantically clever when arguing about this change.

Re: [PATCH] be2net: Fix some u16 fields appropriately

2017-08-28 Thread 严海双
> On 2017年8月29日, at 上午7:19, David Miller wrote: > > From: Haishuang Yan > Date: Sun, 27 Aug 2017 15:24:45 +0800 > >> In be_tx_compl_process, frag_index declared as u32, so it's better to >> declare last_index as u32 also. >> >> CC: Ajit

Re: [PATCH] be2net: Fix some u16 fields appropriately

2017-08-28 Thread 严海双
> On 2017年8月29日, at 上午7:19, David Miller wrote: > > From: Haishuang Yan > Date: Sun, 27 Aug 2017 15:24:45 +0800 > >> In be_tx_compl_process, frag_index declared as u32, so it's better to >> declare last_index as u32 also. >> >> CC: Ajit Khaparde >> Fixes: b0fd2eb28bd4 ("be2net: Declare some

Re: [PATCH] be2net: Fix some u16 fields appropriately

2017-08-28 Thread David Miller
From: Haishuang Yan Date: Sun, 27 Aug 2017 15:24:45 +0800 > In be_tx_compl_process, frag_index declared as u32, so it's better to > declare last_index as u32 also. > > CC: Ajit Khaparde > Fixes: b0fd2eb28bd4 ("be2net: Declare some

Re: [PATCH] be2net: Fix some u16 fields appropriately

2017-08-28 Thread David Miller
From: Haishuang Yan Date: Sun, 27 Aug 2017 15:24:45 +0800 > In be_tx_compl_process, frag_index declared as u32, so it's better to > declare last_index as u32 also. > > CC: Ajit Khaparde > Fixes: b0fd2eb28bd4 ("be2net: Declare some u16 fields as u32 to improve > performance") > Signed-off-by:

[PATCH] be2net: Fix some u16 fields appropriately

2017-08-27 Thread Haishuang Yan
In be_tx_compl_process, frag_index declared as u32, so it's better to declare last_index as u32 also. CC: Ajit Khaparde Fixes: b0fd2eb28bd4 ("be2net: Declare some u16 fields as u32 to improve performance") Signed-off-by: Haishuang Yan

[PATCH] be2net: Fix some u16 fields appropriately

2017-08-27 Thread Haishuang Yan
In be_tx_compl_process, frag_index declared as u32, so it's better to declare last_index as u32 also. CC: Ajit Khaparde Fixes: b0fd2eb28bd4 ("be2net: Declare some u16 fields as u32 to improve performance") Signed-off-by: Haishuang Yan --- drivers/net/ethernet/emulex/benet/be.h | 2 +-