Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Ming Lei
On Fri, Oct 10, 2014 at 3:12 AM, Jens Axboe wrote: > On 10/09/2014 11:58 AM, Jeff Mahoney wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 10/9/14, 12:13 PM, Ming Lei wrote: >>> On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei >>> wrote: On Thu, Oct 9, 2014 at 10:26 PM, Jeff

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jens Axboe
On 10/09/2014 11:58 AM, Jeff Mahoney wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/9/14, 12:13 PM, Ming Lei wrote: >> On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei >> wrote: >>> On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney >>> wrote: -BEGIN PGP SIGNED MESSAGE-

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 12:13 PM, Ming Lei wrote: > On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei > wrote: >> On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney >> wrote: >>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >>> >>> On 10/9/14, 9:53 AM, Jeff Moyer wrote:

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Ming Lei
On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei wrote: > On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 10/9/14, 9:53 AM, Jeff Moyer wrote: >>> Jeff Mahoney writes: >>> Commit 05f1dd53152173 (block: add queue flag for disabling

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Ming Lei
On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/9/14, 9:53 AM, Jeff Moyer wrote: >> Jeff Mahoney writes: >> >>> Commit 05f1dd53152173 (block: add queue flag for disabling SG >>> merging) uses bi_vcnt to assign bio->bi_phys_segments

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 9:53 AM, Jeff Moyer wrote: > Jeff Mahoney writes: > >> Commit 05f1dd53152173 (block: add queue flag for disabling SG >> merging) uses bi_vcnt to assign bio->bi_phys_segments if sg >> merging is disabled. When using device mapper on top

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jeff Moyer
Jeff Mahoney writes: > Commit 05f1dd53152173 (block: add queue flag for disabling SG merging) uses > bi_vcnt to assign bio->bi_phys_segments if sg merging is disabled. When > using device mapper on top of a blk-mq device (virtio_blk in my test), > we'd end up overflowing the scatterlist in

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jeff Moyer
Jeff Mahoney je...@suse.com writes: Commit 05f1dd53152173 (block: add queue flag for disabling SG merging) uses bi_vcnt to assign bio-bi_phys_segments if sg merging is disabled. When using device mapper on top of a blk-mq device (virtio_blk in my test), we'd end up overflowing the scatterlist

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 9:53 AM, Jeff Moyer wrote: Jeff Mahoney je...@suse.com writes: Commit 05f1dd53152173 (block: add queue flag for disabling SG merging) uses bi_vcnt to assign bio-bi_phys_segments if sg merging is disabled. When using device mapper on

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Ming Lei
On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney je...@suse.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 9:53 AM, Jeff Moyer wrote: Jeff Mahoney je...@suse.com writes: Commit 05f1dd53152173 (block: add queue flag for disabling SG merging) uses bi_vcnt to assign

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Ming Lei
On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei ming@canonical.com wrote: On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney je...@suse.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 9:53 AM, Jeff Moyer wrote: Jeff Mahoney je...@suse.com writes: Commit 05f1dd53152173 (block:

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 12:13 PM, Ming Lei wrote: On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei ming@canonical.com wrote: On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney je...@suse.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 9:53

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Jens Axboe
On 10/09/2014 11:58 AM, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 12:13 PM, Ming Lei wrote: On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei ming@canonical.com wrote: On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney je...@suse.com wrote: -BEGIN PGP

Re: [PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-09 Thread Ming Lei
On Fri, Oct 10, 2014 at 3:12 AM, Jens Axboe ax...@kernel.dk wrote: On 10/09/2014 11:58 AM, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/9/14, 12:13 PM, Ming Lei wrote: On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei ming@canonical.com wrote: On Thu, Oct 9, 2014 at

[PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-08 Thread Jeff Mahoney
Commit 05f1dd53152173 (block: add queue flag for disabling SG merging) uses bi_vcnt to assign bio->bi_phys_segments if sg merging is disabled. When using device mapper on top of a blk-mq device (virtio_blk in my test), we'd end up overflowing the scatterlist in __blk_bios_map_sg. __bio_clone_fast

[PATCH] block: copy bi_vcnt in __bio_clone_fast

2014-10-08 Thread Jeff Mahoney
Commit 05f1dd53152173 (block: add queue flag for disabling SG merging) uses bi_vcnt to assign bio-bi_phys_segments if sg merging is disabled. When using device mapper on top of a blk-mq device (virtio_blk in my test), we'd end up overflowing the scatterlist in __blk_bios_map_sg. __bio_clone_fast