Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-27 Thread Alan Cox
On Thu, 27 Sep 2007 12:28:31 -0700 "Brett Warden" <[EMAIL PROTECTED]> wrote: > Fixes use of parport_write_control() to match the newer interface that > requires explicit parport_data_reverse() and parport_data_forward() > calls. This eliminates the following error message and restores the >

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-27 Thread Brett Warden
Fixes use of parport_write_control() to match the newer interface that requires explicit parport_data_reverse() and parport_data_forward() calls. This eliminates the following error message and restores the original intended behavior: parport0 (bw-qcam): use data_reverse for this! Also increases

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-27 Thread Brett Warden
Fixes use of parport_write_control() to match the newer interface that requires explicit parport_data_reverse() and parport_data_forward() calls. This eliminates the following error message and restores the original intended behavior: parport0 (bw-qcam): use data_reverse for this! Also increases

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-27 Thread Alan Cox
On Thu, 27 Sep 2007 12:28:31 -0700 Brett Warden [EMAIL PROTECTED] wrote: Fixes use of parport_write_control() to match the newer interface that requires explicit parport_data_reverse() and parport_data_forward() calls. This eliminates the following error message and restores the original

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
On 9/26/07, Ray Lee <[EMAIL PROTECTED]> wrote: > On 9/26/07, Brett Warden <[EMAIL PROTECTED]> wrote: > > On 9/26/07, Ray Lee <[EMAIL PROTECTED]> wrote: > > > > > Just as an aside, if you've tested this and it works, then there's no > > > point to keep the write_lpcontrol even as a comment. Kill

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 12:12:50 -0700 Brett Warden wrote: > Appeases the warning "parport0 (bw-qcam): use data_reverse for this!" > > Signed-off-by: Brett T. Warden <[EMAIL PROTECTED]> > Where does the warning come from? (what software produces it?) > --- > > It seems to work fine with my

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Ray Lee
On 9/26/07, Brett Warden <[EMAIL PROTECTED]> wrote: > On 9/26/07, Ray Lee <[EMAIL PROTECTED]> wrote: > > > Just as an aside, if you've tested this and it works, then there's no > > point to keep the write_lpcontrol even as a comment. Kill those four > > lines, and if someone's interested in what

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
On 9/26/07, Ray Lee <[EMAIL PROTECTED]> wrote: > Just as an aside, if you've tested this and it works, then there's no > point to keep the write_lpcontrol even as a comment. Kill those four > lines, and if someone's interested in what happened they'll just look > at the file history. Point

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Ray Lee
On 9/26/07, Brett Warden <[EMAIL PROTECTED]> wrote: > Appeases the warning "parport0 (bw-qcam): use data_reverse for this!" > > Signed-off-by: Brett T. Warden <[EMAIL PROTECTED]> > > --- > > It seems to work fine with my Quickcam under 2.6.22. > @@ -369,7 +374,11 @@ static void qc_reset(struct

[PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
Appeases the warning "parport0 (bw-qcam): use data_reverse for this!" Signed-off-by: Brett T. Warden <[EMAIL PROTECTED]> --- It seems to work fine with my Quickcam under 2.6.22. diff --git a/drivers/media/video/bw-qcam.c b/drivers/media/video/bw-qcam.c index 7d47cbe..01e47ed 100644 ---

[PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
Appeases the warning parport0 (bw-qcam): use data_reverse for this! Signed-off-by: Brett T. Warden [EMAIL PROTECTED] --- It seems to work fine with my Quickcam under 2.6.22. diff --git a/drivers/media/video/bw-qcam.c b/drivers/media/video/bw-qcam.c index 7d47cbe..01e47ed 100644 ---

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Ray Lee
On 9/26/07, Brett Warden [EMAIL PROTECTED] wrote: Appeases the warning parport0 (bw-qcam): use data_reverse for this! Signed-off-by: Brett T. Warden [EMAIL PROTECTED] --- It seems to work fine with my Quickcam under 2.6.22. @@ -369,7 +374,11 @@ static void qc_reset(struct qcam_device *q)

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
On 9/26/07, Ray Lee [EMAIL PROTECTED] wrote: Just as an aside, if you've tested this and it works, then there's no point to keep the write_lpcontrol even as a comment. Kill those four lines, and if someone's interested in what happened they'll just look at the file history. Point taken,

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Ray Lee
On 9/26/07, Brett Warden [EMAIL PROTECTED] wrote: On 9/26/07, Ray Lee [EMAIL PROTECTED] wrote: Just as an aside, if you've tested this and it works, then there's no point to keep the write_lpcontrol even as a comment. Kill those four lines, and if someone's interested in what happened

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 12:12:50 -0700 Brett Warden wrote: Appeases the warning parport0 (bw-qcam): use data_reverse for this! Signed-off-by: Brett T. Warden [EMAIL PROTECTED] Where does the warning come from? (what software produces it?) --- It seems to work fine with my Quickcam under

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
On 9/26/07, Ray Lee [EMAIL PROTECTED] wrote: On 9/26/07, Brett Warden [EMAIL PROTECTED] wrote: On 9/26/07, Ray Lee [EMAIL PROTECTED] wrote: Just as an aside, if you've tested this and it works, then there's no point to keep the write_lpcontrol even as a comment. Kill those four