Re: [PATCH] certs: Fix wrong kconfig option used for x509_revocation_list

2021-03-04 Thread David Howells
Eric Snowberg wrote: > Since S_R_K is a string, I could not get that to work. Okay. > >> + hostprogs-always-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += extract-cert I think this should then refer to CONFIG_SYSTEM_REVOCATION_LIST. David

Re: [PATCH] certs: Fix wrong kconfig option used for x509_revocation_list

2021-03-03 Thread Jarkko Sakkinen
On Tue, Mar 02, 2021 at 10:44:18PM -0500, Eric Snowberg wrote: > This fixes a build issue when x509_revocation_list is not defined. "Fix a" Let's stick to the imperative form in commit messages. > > $ make ARCH=x86_64 O=build64 all > > EXTRACT_CERTS ../ > At main.c:154: > - SSL

Re: [PATCH] certs: Fix wrong kconfig option used for x509_revocation_list

2021-03-03 Thread Eric Snowberg
> On Mar 3, 2021, at 2:24 AM, David Howells wrote: > > Eric Snowberg wrote: > >> +ifeq ($(CONFIG_SYSTEM_REVOCATION_LIST),y) >> +obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += revocation_certificates.o >> +endif > > Should the ifeq be referring to CONFIG_SYSTEM_REVOCATION_KEYS rather than >

Re: [PATCH] certs: Fix wrong kconfig option used for x509_revocation_list

2021-03-03 Thread David Howells
Eric Snowberg wrote: > +ifeq ($(CONFIG_SYSTEM_REVOCATION_LIST),y) > +obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += revocation_certificates.o > +endif Should the ifeq be referring to CONFIG_SYSTEM_REVOCATION_KEYS rather than CONFIG_SYSTEM_REVOCATION_LIST? In fact, since S_R_K depends indirectly on

[PATCH] certs: Fix wrong kconfig option used for x509_revocation_list

2021-03-03 Thread Eric Snowberg
This fixes a build issue when x509_revocation_list is not defined. $ make ARCH=x86_64 O=build64 all EXTRACT_CERTS ../ At main.c:154: - SSL error:0909006C:PEM routines:get_name:no start line: crypto/pem/pem_lib.c:745 extract-cert: ../: Is a directory make[2]: [../certs/Makefile:119: