Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-24 Thread John 'Warthog9' Hawley
You can disregard this, I missed the other thread and that looks fine. On 03/24/2017 01:14 PM, John 'Warthog9' Hawley wrote: > On 03/21/2017 11:31 AM, Joe Perches wrote: >> On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: >>> Spamassassin sticks a long (~79 character)

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-24 Thread John 'Warthog9' Hawley
You can disregard this, I missed the other thread and that looks fine. On 03/24/2017 01:14 PM, John 'Warthog9' Hawley wrote: > On 03/21/2017 11:31 AM, Joe Perches wrote: >> On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: >>> Spamassassin sticks a long (~79 character)

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-24 Thread John 'Warthog9' Hawley
On 03/21/2017 11:31 AM, Joe Perches wrote: > On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: >> Spamassassin sticks a long (~79 character) long string after a >> line that has a single space in it. The line with space causes >> checkpatch to erroniously think that it's in

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-24 Thread John 'Warthog9' Hawley
On 03/21/2017 11:31 AM, Joe Perches wrote: > On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: >> Spamassassin sticks a long (~79 character) long string after a >> line that has a single space in it. The line with space causes >> checkpatch to erroniously think that it's in

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-23 Thread Joe Perches
On Wed, 2017-03-22 at 23:01 -0700, Darren Hart wrote: > I still haven't figured out why we test for this specific set of patterns. Why > is a line that starts with a space and ends with a newline considered still > in_header_lines. Or more specifically, why aren't we just testing for an empty >

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-23 Thread Joe Perches
On Wed, 2017-03-22 at 23:01 -0700, Darren Hart wrote: > I still haven't figured out why we test for this specific set of patterns. Why > is a line that starts with a space and ends with a newline considered still > in_header_lines. Or more specifically, why aren't we just testing for an empty >

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-23 Thread Darren Hart
On Wed, Mar 22, 2017 at 11:17:33AM -0700, Joe Perches wrote: > On Wed, 2017-03-22 at 08:25 -0700, Darren Hart wrote: > > On Tue, Mar 21, 2017 at 11:31:08AM -0700, Joe Perches wrote: > > > On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: > > > > Spamassassin sticks a long

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-23 Thread Darren Hart
On Wed, Mar 22, 2017 at 11:17:33AM -0700, Joe Perches wrote: > On Wed, 2017-03-22 at 08:25 -0700, Darren Hart wrote: > > On Tue, Mar 21, 2017 at 11:31:08AM -0700, Joe Perches wrote: > > > On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: > > > > Spamassassin sticks a long

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-22 Thread Joe Perches
On Wed, 2017-03-22 at 08:25 -0700, Darren Hart wrote: > On Tue, Mar 21, 2017 at 11:31:08AM -0700, Joe Perches wrote: > > On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: > > > Spamassassin sticks a long (~79 character) long string after a > > > line that has a single space

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-22 Thread Joe Perches
On Wed, 2017-03-22 at 08:25 -0700, Darren Hart wrote: > On Tue, Mar 21, 2017 at 11:31:08AM -0700, Joe Perches wrote: > > On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: > > > Spamassassin sticks a long (~79 character) long string after a > > > line that has a single space

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-22 Thread Darren Hart
On Tue, Mar 21, 2017 at 11:31:08AM -0700, Joe Perches wrote: > On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: > > Spamassassin sticks a long (~79 character) long string after a > > line that has a single space in it. The line with space causes > > checkpatch to

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-22 Thread Darren Hart
On Tue, Mar 21, 2017 at 11:31:08AM -0700, Joe Perches wrote: > On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: > > Spamassassin sticks a long (~79 character) long string after a > > line that has a single space in it. The line with space causes > > checkpatch to

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-21 Thread Joe Perches
On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: > Spamassassin sticks a long (~79 character) long string after a > line that has a single space in it. The line with space causes > checkpatch to erroniously think that it's in the content body, as > opposed to headers and

Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-21 Thread Joe Perches
On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote: > Spamassassin sticks a long (~79 character) long string after a > line that has a single space in it. The line with space causes > checkpatch to erroniously think that it's in the content body, as > opposed to headers and

[PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-21 Thread John 'Warthog9' Hawley (VMware)
Spamassassin sticks a long (~79 character) long string after a line that has a single space in it. The line with space causes checkpatch to erroniously think that it's in the content body, as opposed to headers and thus flag a mail header as an unwrapped long comment line. This flags when

[PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

2017-03-21 Thread John 'Warthog9' Hawley (VMware)
Spamassassin sticks a long (~79 character) long string after a line that has a single space in it. The line with space causes checkpatch to erroniously think that it's in the content body, as opposed to headers and thus flag a mail header as an unwrapped long comment line. This flags when