Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-18 Thread Christian Borntraeger
On 09/14/2016 08:33 PM, Greg KH wrote: > On Wed, Sep 14, 2016 at 08:16:55PM +0200, Christian Borntraeger wrote: >> On 09/14/2016 08:06 PM, Joe Perches wrote: >>> On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: >>> This will certainly help to reduce the noise. On the other hand

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-18 Thread Christian Borntraeger
On 09/14/2016 08:33 PM, Greg KH wrote: > On Wed, Sep 14, 2016 at 08:16:55PM +0200, Christian Borntraeger wrote: >> On 09/14/2016 08:06 PM, Joe Perches wrote: >>> On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: >>> This will certainly help to reduce the noise. On the other hand

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Josh Triplett
On Wed, Sep 14, 2016 at 05:05:09PM -0700, Joe Perches wrote: > On Wed, 2016-09-14 at 16:54 -0700, Josh Triplett wrote: > > On Wed, Sep 14, 2016 at 07:56:55PM +0200, Christian Borntraeger wrote: > > > On 09/14/2016 07:51 PM, Joe Perches wrote: > > > > checkpatch can be a useful tool for patches. >

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Josh Triplett
On Wed, Sep 14, 2016 at 05:05:09PM -0700, Joe Perches wrote: > On Wed, 2016-09-14 at 16:54 -0700, Josh Triplett wrote: > > On Wed, Sep 14, 2016 at 07:56:55PM +0200, Christian Borntraeger wrote: > > > On 09/14/2016 07:51 PM, Joe Perches wrote: > > > > checkpatch can be a useful tool for patches. >

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
On Wed, 2016-09-14 at 16:54 -0700, Josh Triplett wrote: > On Wed, Sep 14, 2016 at 07:56:55PM +0200, Christian Borntraeger wrote: > > On 09/14/2016 07:51 PM, Joe Perches wrote: > > > checkpatch can be a useful tool for patches. > > > > > > It can be a much more controversial tool when used on files

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
On Wed, 2016-09-14 at 16:54 -0700, Josh Triplett wrote: > On Wed, Sep 14, 2016 at 07:56:55PM +0200, Christian Borntraeger wrote: > > On 09/14/2016 07:51 PM, Joe Perches wrote: > > > checkpatch can be a useful tool for patches. > > > > > > It can be a much more controversial tool when used on files

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Josh Triplett
On Wed, Sep 14, 2016 at 07:56:55PM +0200, Christian Borntraeger wrote: > On 09/14/2016 07:51 PM, Joe Perches wrote: > > checkpatch can be a useful tool for patches. > > > > It can be a much more controversial tool when used on files with the > > -f option for style and whitespace changes for code

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Josh Triplett
On Wed, Sep 14, 2016 at 07:56:55PM +0200, Christian Borntraeger wrote: > On 09/14/2016 07:51 PM, Joe Perches wrote: > > checkpatch can be a useful tool for patches. > > > > It can be a much more controversial tool when used on files with the > > -f option for style and whitespace changes for code

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
On Wed, 2016-09-14 at 20:54 +0200, Christian Borntraeger wrote: > On 09/14/2016 08:33 PM, Greg KH wrote: > > That's not true, I _WANT_ checkpatch cleanups for the portion of the > > kernel I maintain. It keeps the code correct, up to date, easier to > > maintain, and in doing so, we have found

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
On Wed, 2016-09-14 at 20:54 +0200, Christian Borntraeger wrote: > On 09/14/2016 08:33 PM, Greg KH wrote: > > That's not true, I _WANT_ checkpatch cleanups for the portion of the > > kernel I maintain. It keeps the code correct, up to date, easier to > > maintain, and in doing so, we have found

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Christian Borntraeger
On 09/14/2016 08:33 PM, Greg KH wrote: > On Wed, Sep 14, 2016 at 08:16:55PM +0200, Christian Borntraeger wrote: >> On 09/14/2016 08:06 PM, Joe Perches wrote: >>> On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: >>> This will certainly help to reduce the noise. On the other hand

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Christian Borntraeger
On 09/14/2016 08:33 PM, Greg KH wrote: > On Wed, Sep 14, 2016 at 08:16:55PM +0200, Christian Borntraeger wrote: >> On 09/14/2016 08:06 PM, Joe Perches wrote: >>> On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: >>> This will certainly help to reduce the noise. On the other hand

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Greg KH
On Wed, Sep 14, 2016 at 08:16:55PM +0200, Christian Borntraeger wrote: > On 09/14/2016 08:06 PM, Joe Perches wrote: > > On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: > > > >> This will certainly help to reduce the noise. On the other hand I remember > >> Linus > >> saying

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Greg KH
On Wed, Sep 14, 2016 at 08:16:55PM +0200, Christian Borntraeger wrote: > On 09/14/2016 08:06 PM, Joe Perches wrote: > > On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: > > > >> This will certainly help to reduce the noise. On the other hand I remember > >> Linus > >> saying

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Christian Borntraeger
On 09/14/2016 08:21 PM, Joe Perches wrote: > On Wed, 2016-09-14 at 20:16 +0200, Christian Borntraeger wrote: >> You know what. >> with some additional writing like >> "Existing code outside staging is not supposed to be "fixed" to match >> checkpatch. >> Please do not send checkpatch initiated

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Christian Borntraeger
On 09/14/2016 08:21 PM, Joe Perches wrote: > On Wed, 2016-09-14 at 20:16 +0200, Christian Borntraeger wrote: >> You know what. >> with some additional writing like >> "Existing code outside staging is not supposed to be "fixed" to match >> checkpatch. >> Please do not send checkpatch initiated

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
On Wed, 2016-09-14 at 20:16 +0200, Christian Borntraeger wrote: > You know what.  > with some additional writing like  > "Existing code outside staging is not supposed to be "fixed" to match > checkpatch. > Please do not send checkpatch initiated patches for those files" > near the newly created

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
On Wed, 2016-09-14 at 20:16 +0200, Christian Borntraeger wrote: > You know what.  > with some additional writing like  > "Existing code outside staging is not supposed to be "fixed" to match > checkpatch. > Please do not send checkpatch initiated patches for those files" > near the newly created

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Christian Borntraeger
On 09/14/2016 08:06 PM, Joe Perches wrote: > On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: > >> This will certainly help to reduce the noise. On the other hand I remember >> Linus >> saying something along the line that he does not like the -f parameter (and >> he >> prefers

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Christian Borntraeger
On 09/14/2016 08:06 PM, Joe Perches wrote: > On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: > >> This will certainly help to reduce the noise. On the other hand I remember >> Linus >> saying something along the line that he does not like the -f parameter (and >> he >> prefers

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: > This will certainly help to reduce the noise. On the other hand I remember > Linus > saying something along the line that he does not like the -f parameter (and he > prefers to set this automatically). So while I like the approach

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
On Wed, 2016-09-14 at 19:56 +0200, Christian Borntraeger wrote: > This will certainly help to reduce the noise. On the other hand I remember > Linus > saying something along the line that he does not like the -f parameter (and he > prefers to set this automatically). So while I like the approach

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Christian Borntraeger
On 09/14/2016 07:51 PM, Joe Perches wrote: > checkpatch can be a useful tool for patches. > > It can be a much more controversial tool when used on files with the > -f option for style and whitespace changes for code that is relatively > stable, obsolete, or for maintained by specific

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Christian Borntraeger
On 09/14/2016 07:51 PM, Joe Perches wrote: > checkpatch can be a useful tool for patches. > > It can be a much more controversial tool when used on files with the > -f option for style and whitespace changes for code that is relatively > stable, obsolete, or for maintained by specific

[PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
checkpatch can be a useful tool for patches. It can be a much more controversial tool when used on files with the -f option for style and whitespace changes for code that is relatively stable, obsolete, or for maintained by specific individuals. o By default, allow checkpatch to be used with the

[PATCH] checkpatch: Minimize checkpatch induced patches...

2016-09-14 Thread Joe Perches
checkpatch can be a useful tool for patches. It can be a much more controversial tool when used on files with the -f option for style and whitespace changes for code that is relatively stable, obsolete, or for maintained by specific individuals. o By default, allow checkpatch to be used with the