Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 20:31 +0100, Stefan Richter wrote: > AFAIU Daniel's patch still leaves the possibility to use the '-' > syntax, > doesn't it? > > (The program 'cat' is of the kind which always reads from stdin if no > file name is given, or if '-' is given instead of a file name. So, >

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Jiri Slaby
On 01/14/2008 08:31 PM, Stefan Richter wrote: it is with cat. There you have to type no less than 'cat --help', or at least with GNU cat.) --h (--he --hel --help) suffices due to getopt_long gnu implementation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Stefan Richter
Daniel Walker wrote: > On Mon, 2008-01-14 at 19:12 +, Andy Whitcroft wrote: >> with this I cannot run checkpatch and "type" (ie paste) a patch >> fragment to check it. ... > I'm not sure I understand what you mean .. Can you give an example? AFAIU Daniel's patch still leaves the possibility

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 19:12 +, Andy Whitcroft wrote: > So it does, however that of itself differs from the unix norm; as with > this I cannot run checkpatch and "type" (ie paste) a patch fragment to > check it. So I don't think we want the semantics as you have there, > as its confusing to

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Andy Whitcroft
On Mon, Jan 14, 2008 at 09:35:15AM -0800, Daniel Walker wrote: > > On Mon, 2008-01-14 at 17:17 +, Andy Whitcroft wrote: > > On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote: > > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > > > Acked-by: Jiri Slaby <[EMAIL PROTECTED]> >

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 17:17 +, Andy Whitcroft wrote: > On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote: > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > > Acked-by: Jiri Slaby <[EMAIL PROTECTED]> > > As an absolute minimum this seems reasonable to me. I guess we could

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Andy Whitcroft
On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote: > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > Acked-by: Jiri Slaby <[EMAIL PROTECTED]> As an absolute minimum this seems reasonable to me. I guess we could make no arguments default to '-' also. There are up and downsides

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Andy Whitcroft
On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] Acked-by: Jiri Slaby [EMAIL PROTECTED] As an absolute minimum this seems reasonable to me. I guess we could make no arguments default to '-' also. There are up and downsides to

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 17:17 +, Andy Whitcroft wrote: On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] Acked-by: Jiri Slaby [EMAIL PROTECTED] As an absolute minimum this seems reasonable to me. I guess we could make no

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Andy Whitcroft
On Mon, Jan 14, 2008 at 09:35:15AM -0800, Daniel Walker wrote: On Mon, 2008-01-14 at 17:17 +, Andy Whitcroft wrote: On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] Acked-by: Jiri Slaby [EMAIL PROTECTED] As an

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 19:12 +, Andy Whitcroft wrote: So it does, however that of itself differs from the unix norm; as with this I cannot run checkpatch and type (ie paste) a patch fragment to check it. So I don't think we want the semantics as you have there, as its confusing to the

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Daniel Walker
On Mon, 2008-01-14 at 20:31 +0100, Stefan Richter wrote: AFAIU Daniel's patch still leaves the possibility to use the '-' syntax, doesn't it? (The program 'cat' is of the kind which always reads from stdin if no file name is given, or if '-' is given instead of a file name. So, 'cat'

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Stefan Richter
Daniel Walker wrote: On Mon, 2008-01-14 at 19:12 +, Andy Whitcroft wrote: with this I cannot run checkpatch and type (ie paste) a patch fragment to check it. ... I'm not sure I understand what you mean .. Can you give an example? AFAIU Daniel's patch still leaves the possibility to use

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-14 Thread Jiri Slaby
On 01/14/2008 08:31 PM, Stefan Richter wrote: it is with cat. There you have to type no less than 'cat --help', or at least with GNU cat.) --h (--he --hel --help) suffices due to getopt_long gnu implementation -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 18:29 +0100, Stefan Richter wrote: > Daniel Walker wrote: > > On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: > >> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > >> + print "When patchfile is -, read standard input.\n"; > > > Naww .. Why add documentation

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Stefan Richter
Daniel Walker wrote: > On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: >> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> >> +print "When patchfile is -, read standard input.\n"; > Naww .. Why add documentation when you can just make it do the right > thing .. Why add code for a

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > Acked-by: Jiri Slaby <[EMAIL PROTECTED]> > --- > scripts/checkpatch.pl |1 + > 1 file changed, 1 insertion(+) > > Index: linux/scripts/checkpatch.pl >

[PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Stefan Richter
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> Acked-by: Jiri Slaby <[EMAIL PROTECTED]> --- scripts/checkpatch.pl |1 + 1 file changed, 1 insertion(+) Index: linux/scripts/checkpatch.pl === ---

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] Acked-by: Jiri Slaby [EMAIL PROTECTED] --- scripts/checkpatch.pl |1 + 1 file changed, 1 insertion(+) Index: linux/scripts/checkpatch.pl

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Stefan Richter
Daniel Walker wrote: On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] +print When patchfile is -, read standard input.\n; Naww .. Why add documentation when you can just make it do the right thing .. Why add code for a feature

Re: [PATCH] checkpatch.pl: show how to read from stdin

2008-01-11 Thread Daniel Walker
On Fri, 2008-01-11 at 18:29 +0100, Stefan Richter wrote: Daniel Walker wrote: On Fri, 2008-01-11 at 18:06 +0100, Stefan Richter wrote: Signed-off-by: Stefan Richter [EMAIL PROTECTED] + print When patchfile is -, read standard input.\n; Naww .. Why add documentation when you can just