Re: [PATCH] cifs: fix srcip_matches() for ipv6

2013-01-20 Thread Steve French
merged into cifs-2.6.git On Wed, Jan 16, 2013 at 10:04 PM, Nickolai Zeldovich wrote: > On Wed, Jan 16, 2013 at 10:51 PM, Steve French wrote: >> How did you discover this - did you have an ipv6 test case or by >> inspection or ...? > > By mostly-automated inspection (i.e., with the help of a

Re: [PATCH] cifs: fix srcip_matches() for ipv6

2013-01-20 Thread Steve French
merged into cifs-2.6.git On Wed, Jan 16, 2013 at 10:04 PM, Nickolai Zeldovich nicko...@csail.mit.edu wrote: On Wed, Jan 16, 2013 at 10:51 PM, Steve French smfre...@gmail.com wrote: How did you discover this - did you have an ipv6 test case or by inspection or ...? By mostly-automated

Re: [PATCH] cifs: fix srcip_matches() for ipv6

2013-01-17 Thread Jeff Layton
On Wed, 16 Jan 2013 21:36:17 -0500 Nickolai Zeldovich wrote: > srcip_matches() previously had code like this: > > srcip_matches(..., struct sockaddr *rhs) { > /* ... */ > struct sockaddr_in6 *vaddr6 = (struct sockaddr_in6 *) > return ipv6_addr_equal(..., >sin6_addr); > } > >

Re: [PATCH] cifs: fix srcip_matches() for ipv6

2013-01-17 Thread Jeff Layton
On Wed, 16 Jan 2013 21:36:17 -0500 Nickolai Zeldovich nicko...@csail.mit.edu wrote: srcip_matches() previously had code like this: srcip_matches(..., struct sockaddr *rhs) { /* ... */ struct sockaddr_in6 *vaddr6 = (struct sockaddr_in6 *) rhs; return ipv6_addr_equal(...,

Re: [PATCH] cifs: fix srcip_matches() for ipv6

2013-01-16 Thread Nickolai Zeldovich
On Wed, Jan 16, 2013 at 10:51 PM, Steve French wrote: > How did you discover this - did you have an ipv6 test case or by > inspection or ...? By mostly-automated inspection (i.e., with the help of a static program analysis tool). Nickolai. -- To unsubscribe from this list: send the line

Re: [PATCH] cifs: fix srcip_matches() for ipv6

2013-01-16 Thread Steve French
Makes sense. How did you discover this - did you have an ipv6 test case or by inspection or ...? On Wed, Jan 16, 2013 at 8:36 PM, Nickolai Zeldovich wrote: > srcip_matches() previously had code like this: > > srcip_matches(..., struct sockaddr *rhs) { > /* ... */ > struct sockaddr_in6

[PATCH] cifs: fix srcip_matches() for ipv6

2013-01-16 Thread Nickolai Zeldovich
srcip_matches() previously had code like this: srcip_matches(..., struct sockaddr *rhs) { /* ... */ struct sockaddr_in6 *vaddr6 = (struct sockaddr_in6 *) return ipv6_addr_equal(..., >sin6_addr); } which interpreted the values on the stack after the 'rhs' pointer as an ipv6

[PATCH] cifs: fix srcip_matches() for ipv6

2013-01-16 Thread Nickolai Zeldovich
srcip_matches() previously had code like this: srcip_matches(..., struct sockaddr *rhs) { /* ... */ struct sockaddr_in6 *vaddr6 = (struct sockaddr_in6 *) rhs; return ipv6_addr_equal(..., vaddr6-sin6_addr); } which interpreted the values on the stack after the 'rhs' pointer as an

Re: [PATCH] cifs: fix srcip_matches() for ipv6

2013-01-16 Thread Steve French
Makes sense. How did you discover this - did you have an ipv6 test case or by inspection or ...? On Wed, Jan 16, 2013 at 8:36 PM, Nickolai Zeldovich nicko...@csail.mit.edu wrote: srcip_matches() previously had code like this: srcip_matches(..., struct sockaddr *rhs) { /* ... */

Re: [PATCH] cifs: fix srcip_matches() for ipv6

2013-01-16 Thread Nickolai Zeldovich
On Wed, Jan 16, 2013 at 10:51 PM, Steve French smfre...@gmail.com wrote: How did you discover this - did you have an ipv6 test case or by inspection or ...? By mostly-automated inspection (i.e., with the help of a static program analysis tool). Nickolai. -- To unsubscribe from this list: send