Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

2016-09-19 Thread arvind Yadav
On Wednesday 14 September 2016 11:54 PM, Stephen Boyd wrote: On 09/14, arvind.yadav...@gmail.com wrote: @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node *np) return; err: + if (reg) This is always true? Why check? I have removed this check.

Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

2016-09-19 Thread arvind Yadav
On Wednesday 14 September 2016 11:54 PM, Stephen Boyd wrote: On 09/14, arvind.yadav...@gmail.com wrote: @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node *np) return; err: + if (reg) This is always true? Why check? I have removed this check.

Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

2016-09-14 Thread Stephen Boyd
On 09/14, arvind.yadav...@gmail.com wrote: > @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node > *np) > return; > > err: > + if (reg) This is always true? Why check? > + iounmap(reg); > if (clk_data) >

Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

2016-09-14 Thread Stephen Boyd
On 09/14, arvind.yadav...@gmail.com wrote: > @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node > *np) > return; > > err: > + if (reg) This is always true? Why check? > + iounmap(reg); > if (clk_data) >

[PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

2016-09-14 Thread arvind . yadav . cs
From: Arvind Yadav Free memory mapping, if probe is not successful. Signed-off-by: Arvind Yadav --- drivers/clk/st/clk-flexgen.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/clk/st/clk-flexgen.c

[PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap

2016-09-14 Thread arvind . yadav . cs
From: Arvind Yadav Free memory mapping, if probe is not successful. Signed-off-by: Arvind Yadav --- drivers/clk/st/clk-flexgen.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c index 546bd79..af8df7b