Re: [PATCH] dma-debug: Check scatterlist segments

2018-05-08 Thread Robin Murphy
On 25/04/18 06:58, Christoph Hellwig wrote: This looks interesting. I suspect it is going to blow up in quite a few places, so maybe at least for now it might make sense to have a separate config option? True, it's nice to verify this for 'traditional' dma_map_sg() usage, but places where

Re: [PATCH] dma-debug: Check scatterlist segments

2018-05-08 Thread Robin Murphy
On 25/04/18 06:58, Christoph Hellwig wrote: This looks interesting. I suspect it is going to blow up in quite a few places, so maybe at least for now it might make sense to have a separate config option? True, it's nice to verify this for 'traditional' dma_map_sg() usage, but places where

Re: [PATCH] dma-debug: Check scatterlist segments

2018-04-24 Thread Christoph Hellwig
This looks interesting. I suspect it is going to blow up in quite a few places, so maybe at least for now it might make sense to have a separate config option? On Tue, Apr 24, 2018 at 05:12:19PM +0100, Robin Murphy wrote: > Drivers/subsystems creating scatterlists for DMA should be taking care >

Re: [PATCH] dma-debug: Check scatterlist segments

2018-04-24 Thread Christoph Hellwig
This looks interesting. I suspect it is going to blow up in quite a few places, so maybe at least for now it might make sense to have a separate config option? On Tue, Apr 24, 2018 at 05:12:19PM +0100, Robin Murphy wrote: > Drivers/subsystems creating scatterlists for DMA should be taking care >

Re: [PATCH] dma-debug: Check scatterlist segments

2018-04-24 Thread kbuild test robot
Hi Robin, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc2 next-20180424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] dma-debug: Check scatterlist segments

2018-04-24 Thread kbuild test robot
Hi Robin, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc2 next-20180424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] dma-debug: Check scatterlist segments

2018-04-24 Thread Robin Murphy
Drivers/subsystems creating scatterlists for DMA should be taking care to respect the scatter-gather limitations of the appropriate device, as described by dma_parms. A DMA API implementation cannot feasibly split a scatterlist into *more* entries than originally passed, so it is not well defined

[PATCH] dma-debug: Check scatterlist segments

2018-04-24 Thread Robin Murphy
Drivers/subsystems creating scatterlists for DMA should be taking care to respect the scatter-gather limitations of the appropriate device, as described by dma_parms. A DMA API implementation cannot feasibly split a scatterlist into *more* entries than originally passed, so it is not well defined