Re: [PATCH] driver/base/node: remove unnecessary kfree of node struct from unregister_one_node

2014-10-08 Thread Yasuaki Ishimatsu
(2014/10/09 13:10), Xishi Qiu wrote: > On 2014/10/3 18:06, Yasuaki Ishimatsu wrote: > >> Commit 92d585ef067d ("numa: fix NULL pointer access and memory >> leak in unregister_one_node()") added kfree() of node struct in >> unregister_one_node(). But node struct is freed by node_device_release() >>

Re: [PATCH] driver/base/node: remove unnecessary kfree of node struct from unregister_one_node

2014-10-08 Thread Xishi Qiu
On 2014/10/3 18:06, Yasuaki Ishimatsu wrote: > Commit 92d585ef067d ("numa: fix NULL pointer access and memory > leak in unregister_one_node()") added kfree() of node struct in > unregister_one_node(). But node struct is freed by node_device_release() > which is called in unregister_node(). So by

Re: [PATCH] driver/base/node: remove unnecessary kfree of node struct from unregister_one_node

2014-10-08 Thread Xishi Qiu
On 2014/10/3 18:06, Yasuaki Ishimatsu wrote: Commit 92d585ef067d (numa: fix NULL pointer access and memory leak in unregister_one_node()) added kfree() of node struct in unregister_one_node(). But node struct is freed by node_device_release() which is called in unregister_node(). So by

Re: [PATCH] driver/base/node: remove unnecessary kfree of node struct from unregister_one_node

2014-10-08 Thread Yasuaki Ishimatsu
(2014/10/09 13:10), Xishi Qiu wrote: On 2014/10/3 18:06, Yasuaki Ishimatsu wrote: Commit 92d585ef067d (numa: fix NULL pointer access and memory leak in unregister_one_node()) added kfree() of node struct in unregister_one_node(). But node struct is freed by node_device_release() which is

[PATCH] driver/base/node: remove unnecessary kfree of node struct from unregister_one_node

2014-10-03 Thread Yasuaki Ishimatsu
Commit 92d585ef067d ("numa: fix NULL pointer access and memory leak in unregister_one_node()") added kfree() of node struct in unregister_one_node(). But node struct is freed by node_device_release() which is called in unregister_node(). So by adding the kfree(), node struct is freed two times.

[PATCH] driver/base/node: remove unnecessary kfree of node struct from unregister_one_node

2014-10-03 Thread Yasuaki Ishimatsu
Commit 92d585ef067d (numa: fix NULL pointer access and memory leak in unregister_one_node()) added kfree() of node struct in unregister_one_node(). But node struct is freed by node_device_release() which is called in unregister_node(). So by adding the kfree(), node struct is freed two times.