Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-23 Thread Herton Ronaldo Krzesinski
On Wed, Jan 23, 2013 at 12:21:29PM -0500, Ilija Hadzic wrote: > On Wed, Jan 23, 2013 at 11:07 AM, Herton Ronaldo Krzesinski > wrote: > > On Thu, Jan 17, 2013 at 10:09:42AM -0700, Shuah Khan wrote: > >> On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: > >> > Actually, the code path affected

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-23 Thread Ilija Hadzic
On Wed, Jan 23, 2013 at 11:07 AM, Herton Ronaldo Krzesinski wrote: > On Thu, Jan 17, 2013 at 10:09:42AM -0700, Shuah Khan wrote: >> On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: >> > Actually, the code path affected by your patch is not executed in UMS mode >> > at all. Notice that

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-23 Thread Herton Ronaldo Krzesinski
On Thu, Jan 17, 2013 at 10:09:42AM -0700, Shuah Khan wrote: > On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: > > Actually, the code path affected by your patch is not executed in UMS mode > > at all. Notice that radeon_cs_parser_fini is only called from > > radeon_cs_ioctl which is a

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-23 Thread Herton Ronaldo Krzesinski
On Thu, Jan 17, 2013 at 10:09:42AM -0700, Shuah Khan wrote: On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: Actually, the code path affected by your patch is not executed in UMS mode at all. Notice that radeon_cs_parser_fini is only called from radeon_cs_ioctl which is a KMS-only

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-23 Thread Ilija Hadzic
On Wed, Jan 23, 2013 at 11:07 AM, Herton Ronaldo Krzesinski herton.krzesin...@canonical.com wrote: On Thu, Jan 17, 2013 at 10:09:42AM -0700, Shuah Khan wrote: On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: Actually, the code path affected by your patch is not executed in UMS mode at

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-23 Thread Herton Ronaldo Krzesinski
On Wed, Jan 23, 2013 at 12:21:29PM -0500, Ilija Hadzic wrote: On Wed, Jan 23, 2013 at 11:07 AM, Herton Ronaldo Krzesinski herton.krzesin...@canonical.com wrote: On Thu, Jan 17, 2013 at 10:09:42AM -0700, Shuah Khan wrote: On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: Actually, the

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-17 Thread Shuah Khan
On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: > Actually, the code path affected by your patch is not executed in UMS mode > at all. Notice that radeon_cs_parser_fini is only called from > radeon_cs_ioctl which is a KMS-only ioctl (see radeon_kms.c). > > The equivalent of the fix you

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-17 Thread Shuah Khan
On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: Actually, the code path affected by your patch is not executed in UMS mode at all. Notice that radeon_cs_parser_fini is only called from radeon_cs_ioctl which is a KMS-only ioctl (see radeon_kms.c). The equivalent of the fix you are

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-16 Thread Ilija Hadzic
Actually, the code path affected by your patch is not executed in UMS mode at all. Notice that radeon_cs_parser_fini is only called from radeon_cs_ioctl which is a KMS-only ioctl (see radeon_kms.c). The equivalent of the fix you are trying to do is in a6b7e1a02b77ab8fe8775d20a88c53d8ba55482e

[PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-16 Thread Shuah Khan
Fix parser->rdev NULL pointer dereference in radeon_cs_parser_fini(). While back-porting drm/radeon: fix NULL pointer dereference in UMS mode patch (commit-id: ff4bd0827764e10a428a9d39e6814c5478863f94) to 3,7.y, noticed another instance of NULL pointer dereference in radeon_cs_parser_fini()

[PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-16 Thread Shuah Khan
Fix parser-rdev NULL pointer dereference in radeon_cs_parser_fini(). While back-porting drm/radeon: fix NULL pointer dereference in UMS mode patch (commit-id: ff4bd0827764e10a428a9d39e6814c5478863f94) to 3,7.y, noticed another instance of NULL pointer dereference in radeon_cs_parser_fini()

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-16 Thread Ilija Hadzic
Actually, the code path affected by your patch is not executed in UMS mode at all. Notice that radeon_cs_parser_fini is only called from radeon_cs_ioctl which is a KMS-only ioctl (see radeon_kms.c). The equivalent of the fix you are trying to do is in a6b7e1a02b77ab8fe8775d20a88c53d8ba55482e