Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Christoph Hellwig
On Wed, Nov 25, 2020 at 07:57:20PM -0400, Jason Gunthorpe wrote: > annotate is OK, I used that for a long time.. > > My main gripe was it didn't setup the to/cc until after the annotate > editor closes. I put the To/Cc into the cover letter text file.

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Jason Gunthorpe
On Wed, Nov 25, 2020 at 06:11:29PM +, Christoph Hellwig wrote: > On Wed, Nov 25, 2020 at 02:06:06PM -0400, Jason Gunthorpe wrote: > > It uses a empty 'cover-letter' commit and automatically transforms it > > into exactly the right stuff. Keeps track of everything you send in > > git, and there

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Daniel Stone
Hi, On Wed, 25 Nov 2020 at 18:06, Jason Gunthorpe wrote: > On Wed, Nov 25, 2020 at 05:28:32PM +0100, Daniel Vetter wrote: > > Apologies again, this shouldn't have been included. But at least I > > have an idea now why this patch somehow was included in the git > > send-email. Lovely interface

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Christoph Hellwig
On Wed, Nov 25, 2020 at 02:06:06PM -0400, Jason Gunthorpe wrote: > It uses a empty 'cover-letter' commit and automatically transforms it > into exactly the right stuff. Keeps track of everything you send in > git, and there is a little tool to auto-run git range-diff to help > build change logs..

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Jason Gunthorpe
On Wed, Nov 25, 2020 at 05:28:32PM +0100, Daniel Vetter wrote: > On Wed, Nov 25, 2020 at 5:25 PM Daniel Vetter wrote: > > > > Random observation while trying to review Christian's patch series to > > stop looking at struct page for dma-buf imports. > > > > This was originally added in > > > >

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Daniel Vetter
On Wed, Nov 25, 2020 at 5:25 PM Daniel Vetter wrote: > > Random observation while trying to review Christian's patch series to > stop looking at struct page for dma-buf imports. > > This was originally added in > > commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 > Author: Thomas Hellstrom >

[PATCH] drm/ttm: don't set page->mapping

2020-11-25 Thread Daniel Vetter
Random observation while trying to review Christian's patch series to stop looking at struct page for dma-buf imports. This was originally added in commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 Author: Thomas Hellstrom Date: Fri Jan 3 11:47:23 2014 +0100 drm/ttm: Correctly set page

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-20 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 11:08:31AM +0100, Christian König wrote: > Am 20.11.20 um 11:05 schrieb Daniel Vetter: > > On Fri, Nov 20, 2020 at 11:04 AM Christian König > > wrote: > > > Am 20.11.20 um 10:54 schrieb Daniel Vetter: > > > > Random observation while trying to review Christian's patch

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-20 Thread Christian König
Am 20.11.20 um 11:05 schrieb Daniel Vetter: On Fri, Nov 20, 2020 at 11:04 AM Christian König wrote: Am 20.11.20 um 10:54 schrieb Daniel Vetter: Random observation while trying to review Christian's patch series to stop looking at struct page for dma-buf imports. This was originally added in

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-20 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 11:04 AM Christian König wrote: > > Am 20.11.20 um 10:54 schrieb Daniel Vetter: > > Random observation while trying to review Christian's patch series to > > stop looking at struct page for dma-buf imports. > > > > This was originally added in > > > > commit

Re: [PATCH] drm/ttm: don't set page->mapping

2020-11-20 Thread Christian König
Am 20.11.20 um 10:54 schrieb Daniel Vetter: Random observation while trying to review Christian's patch series to stop looking at struct page for dma-buf imports. This was originally added in commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 Author: Thomas Hellstrom Date: Fri Jan 3 11:47:23

[PATCH] drm/ttm: don't set page->mapping

2020-11-20 Thread Daniel Vetter
Random observation while trying to review Christian's patch series to stop looking at struct page for dma-buf imports. This was originally added in commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 Author: Thomas Hellstrom Date: Fri Jan 3 11:47:23 2014 +0100 drm/ttm: Correctly set page