RE: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

2018-01-17 Thread Deepak Singh Rawat
as Hellstrom <thellst...@vmware.com>; Rob Clark > <rcl...@redhat.com>; David Airlie <airl...@linux.ie>; linux- > ker...@vger.kernel.org; sta...@vger.kernel.org; linux-graphics-maintainer > <linux-graphics-maintai...@vmware.com> > Subject: [PATCH] drm/vmwgfx: fix memory cor

RE: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

2018-01-17 Thread Deepak Singh Rawat
vid Airlie ; linux- > ker...@vger.kernel.org; sta...@vger.kernel.org; linux-graphics-maintainer > > Subject: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou > connectors > > From: Rob Clark > > It looks like in all cases 'struct vmw_connector_state' is used.

Re: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

2018-01-17 Thread Thomas Hellstrom
On 01/17/2018 04:16 PM, Rob Clark wrote: From: Rob Clark It looks like in all cases 'struct vmw_connector_state' is used. But only in stdu connectors, was atomic_{duplicate,destroy}_state() properly subclassed. Leading to writes beyond the end of the allocated connector

Re: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

2018-01-17 Thread Thomas Hellstrom
On 01/17/2018 04:16 PM, Rob Clark wrote: From: Rob Clark It looks like in all cases 'struct vmw_connector_state' is used. But only in stdu connectors, was atomic_{duplicate,destroy}_state() properly subclassed. Leading to writes beyond the end of the allocated connector state block and all

[PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

2018-01-17 Thread Rob Clark
From: Rob Clark It looks like in all cases 'struct vmw_connector_state' is used. But only in stdu connectors, was atomic_{duplicate,destroy}_state() properly subclassed. Leading to writes beyond the end of the allocated connector state block and all sorts of fun memory

[PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

2018-01-17 Thread Rob Clark
From: Rob Clark It looks like in all cases 'struct vmw_connector_state' is used. But only in stdu connectors, was atomic_{duplicate,destroy}_state() properly subclassed. Leading to writes beyond the end of the allocated connector state block and all sorts of fun memory corruption related