Re: [PATCH] efibc: avoid stack overflow warning

2016-05-01 Thread Matt Fleming
On Sun, 01 May, at 01:25:12AM, Arnd Bergmann wrote: > On Saturday 30 April 2016 23:46:41 Matt Fleming wrote: > > > > > It's not something we'd have to worry about in practice, but it does > > > make my patch incorrect. Should we come up with a different way to > > > do it? > > > > Jeremy

Re: [PATCH] efibc: avoid stack overflow warning

2016-05-01 Thread Matt Fleming
On Sun, 01 May, at 01:25:12AM, Arnd Bergmann wrote: > On Saturday 30 April 2016 23:46:41 Matt Fleming wrote: > > > > > It's not something we'd have to worry about in practice, but it does > > > make my patch incorrect. Should we come up with a different way to > > > do it? > > > > Jeremy

Re: [PATCH] efibc: avoid stack overflow warning

2016-04-30 Thread Arnd Bergmann
On Saturday 30 April 2016 23:46:41 Matt Fleming wrote: > > > It's not something we'd have to worry about in practice, but it does > > make my patch incorrect. Should we come up with a different way to > > do it? > > Jeremy proposed a patch to dynamically allocate the memory, which I > think is

Re: [PATCH] efibc: avoid stack overflow warning

2016-04-30 Thread Arnd Bergmann
On Saturday 30 April 2016 23:46:41 Matt Fleming wrote: > > > It's not something we'd have to worry about in practice, but it does > > make my patch incorrect. Should we come up with a different way to > > do it? > > Jeremy proposed a patch to dynamically allocate the memory, which I > think is

Re: [PATCH] efibc: avoid stack overflow warning

2016-04-30 Thread Matt Fleming
On Sun, 01 May, at 12:34:29AM, Arnd Bergmann wrote: > > The sys_restart() system call takes a mutex before calling kernel_restart() > or kernel_poweroff(). > > I've had a closer look now and found that there are a few other > callers of kernel_restart, so I guess if you restart using sysctl > at

Re: [PATCH] efibc: avoid stack overflow warning

2016-04-30 Thread Matt Fleming
On Sun, 01 May, at 12:34:29AM, Arnd Bergmann wrote: > > The sys_restart() system call takes a mutex before calling kernel_restart() > or kernel_poweroff(). > > I've had a closer look now and found that there are a few other > callers of kernel_restart, so I guess if you restart using sysctl > at

Re: [PATCH] efibc: avoid stack overflow warning

2016-04-30 Thread Arnd Bergmann
On Saturday 30 April 2016 21:14:49 Matt Fleming wrote: > On Fri, 29 Apr, at 07:48:31PM, Arnd Bergmann wrote: > > gcc complains about a newly added file for the EFI Bootloader Control: > > > > drivers/firmware/efi/efibc.c: In function 'efibc_set_variable': > > drivers/firmware/efi/efibc.c:53:1:

Re: [PATCH] efibc: avoid stack overflow warning

2016-04-30 Thread Arnd Bergmann
On Saturday 30 April 2016 21:14:49 Matt Fleming wrote: > On Fri, 29 Apr, at 07:48:31PM, Arnd Bergmann wrote: > > gcc complains about a newly added file for the EFI Bootloader Control: > > > > drivers/firmware/efi/efibc.c: In function 'efibc_set_variable': > > drivers/firmware/efi/efibc.c:53:1:

Re: [PATCH] efibc: avoid stack overflow warning

2016-04-30 Thread Matt Fleming
On Fri, 29 Apr, at 07:48:31PM, Arnd Bergmann wrote: > gcc complains about a newly added file for the EFI Bootloader Control: > > drivers/firmware/efi/efibc.c: In function 'efibc_set_variable': > drivers/firmware/efi/efibc.c:53:1: error: the frame size of 2272 bytes is > larger than 1024 bytes

Re: [PATCH] efibc: avoid stack overflow warning

2016-04-30 Thread Matt Fleming
On Fri, 29 Apr, at 07:48:31PM, Arnd Bergmann wrote: > gcc complains about a newly added file for the EFI Bootloader Control: > > drivers/firmware/efi/efibc.c: In function 'efibc_set_variable': > drivers/firmware/efi/efibc.c:53:1: error: the frame size of 2272 bytes is > larger than 1024 bytes

[PATCH] efibc: avoid stack overflow warning

2016-04-29 Thread Arnd Bergmann
gcc complains about a newly added file for the EFI Bootloader Control: drivers/firmware/efi/efibc.c: In function 'efibc_set_variable': drivers/firmware/efi/efibc.c:53:1: error: the frame size of 2272 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] The problem is the declaration of

[PATCH] efibc: avoid stack overflow warning

2016-04-29 Thread Arnd Bergmann
gcc complains about a newly added file for the EFI Bootloader Control: drivers/firmware/efi/efibc.c: In function 'efibc_set_variable': drivers/firmware/efi/efibc.c:53:1: error: the frame size of 2272 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] The problem is the declaration of