Re: [PATCH] eventfd: convert to ->write_iter()

2020-11-18 Thread Michal Kubecek
On Wed, Nov 18, 2020 at 04:25:37PM -0700, Jens Axboe wrote: > On 11/18/20 4:18 PM, Michal Kubecek wrote: > > On Wed, Nov 18, 2020 at 02:27:08PM -0700, Jens Axboe wrote: > >> On 11/18/20 12:59 PM, Michal Kubecek wrote: > >>> On Wed, Nov 18, 2020 at 03:18:06PM +, Christoph Hellwig wrote: >

Re: [PATCH] eventfd: convert to ->write_iter()

2020-11-18 Thread Jens Axboe
On 11/18/20 4:18 PM, Michal Kubecek wrote: > On Wed, Nov 18, 2020 at 02:27:08PM -0700, Jens Axboe wrote: >> On 11/18/20 12:59 PM, Michal Kubecek wrote: >>> On Wed, Nov 18, 2020 at 03:18:06PM +, Christoph Hellwig wrote: On Wed, Nov 18, 2020 at 10:19:17AM +0100, Michal Kubecek wrote: >

Re: [PATCH] eventfd: convert to ->write_iter()

2020-11-18 Thread Michal Kubecek
On Wed, Nov 18, 2020 at 02:27:08PM -0700, Jens Axboe wrote: > On 11/18/20 12:59 PM, Michal Kubecek wrote: > > On Wed, Nov 18, 2020 at 03:18:06PM +, Christoph Hellwig wrote: > >> On Wed, Nov 18, 2020 at 10:19:17AM +0100, Michal Kubecek wrote: > >>> While eventfd ->read() callback was replaced

Re: [PATCH] eventfd: convert to ->write_iter()

2020-11-18 Thread Jens Axboe
On 11/18/20 12:59 PM, Michal Kubecek wrote: > On Wed, Nov 18, 2020 at 03:18:06PM +, Christoph Hellwig wrote: >> On Wed, Nov 18, 2020 at 10:19:17AM +0100, Michal Kubecek wrote: >>> While eventfd ->read() callback was replaced by ->read_iter() recently, >>> it still provides ->write() for

Re: [PATCH] eventfd: convert to ->write_iter()

2020-11-18 Thread Michal Kubecek
On Wed, Nov 18, 2020 at 03:18:06PM +, Christoph Hellwig wrote: > On Wed, Nov 18, 2020 at 10:19:17AM +0100, Michal Kubecek wrote: > > While eventfd ->read() callback was replaced by ->read_iter() recently, > > it still provides ->write() for writes. Since commit 4d03e3cc5982 ("fs: > > don't

Re: [PATCH] eventfd: convert to ->write_iter()

2020-11-18 Thread Christoph Hellwig
On Wed, Nov 18, 2020 at 10:19:17AM +0100, Michal Kubecek wrote: > While eventfd ->read() callback was replaced by ->read_iter() recently, > it still provides ->write() for writes. Since commit 4d03e3cc5982 ("fs: > don't allow kernel reads and writes without iter ops"), this prevents >

[PATCH] eventfd: convert to ->write_iter()

2020-11-18 Thread Michal Kubecek
While eventfd ->read() callback was replaced by ->read_iter() recently, it still provides ->write() for writes. Since commit 4d03e3cc5982 ("fs: don't allow kernel reads and writes without iter ops"), this prevents kernel_write() to be used for eventfd and with set_fs() removal, ->write() cannot be