Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-10-17 Thread Andreas Dilger
On Oct 16, 2007 15:00 -0700, Andrew Morton wrote: > On Fri, 13 Jul 2007 18:36:54 -0700 > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > @@ -1136,12 +1136,12 @@ static int ext2_statfs (struct dentry * > > buf->f_type = EXT2_SUPER_MAGIC; > > buf->f_bsize = sb->s_blocksize; > >

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-10-17 Thread Andreas Dilger
On Oct 16, 2007 15:00 -0700, Andrew Morton wrote: On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty [EMAIL PROTECTED] wrote: @@ -1136,12 +1136,12 @@ static int ext2_statfs (struct dentry * buf-f_type = EXT2_SUPER_MAGIC; buf-f_bsize = sb-s_blocksize; buf-f_blocks =

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-10-16 Thread Badari
Andrew Morton wrote: On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: More statfs() improvements for ext2. ext2 already maintains percpu counters for free blocks and inodes. Derive free block count and inode count by summing up percpu counters, instead of

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-10-16 Thread Andrew Morton
On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > More statfs() improvements for ext2. ext2 already maintains > percpu counters for free blocks and inodes. Derive free > block count and inode count by summing up percpu counters, > instead of counting up all the

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-10-16 Thread Andrew Morton
On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty [EMAIL PROTECTED] wrote: More statfs() improvements for ext2. ext2 already maintains percpu counters for free blocks and inodes. Derive free block count and inode count by summing up percpu counters, instead of counting up all the groups

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-10-16 Thread Badari
Andrew Morton wrote: On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty [EMAIL PROTECTED] wrote: More statfs() improvements for ext2. ext2 already maintains percpu counters for free blocks and inodes. Derive free block count and inode count by summing up percpu counters, instead of

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-07-20 Thread Andreas Dilger
On Jul 19, 2007 08:18 -0700, Badari Pulavarty wrote: > In my setups (4 & 8-way), I didn't measure any significant performance > improvements (in any reasonable workload). I see some decent > improvements on cooked-up (1 million stats) tests :( I don't have any numbers to publish, but this did

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-07-20 Thread Andreas Dilger
On Jul 19, 2007 08:18 -0700, Badari Pulavarty wrote: In my setups (4 8-way), I didn't measure any significant performance improvements (in any reasonable workload). I see some decent improvements on cooked-up (1 million stats) tests :( I don't have any numbers to publish, but this did help

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-07-19 Thread Badari Pulavarty
On Wed, 2007-07-18 at 20:18 -0700, Andrew Morton wrote: > On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > More statfs() improvements for ext2. ext2 already maintains > > percpu counters for free blocks and inodes. Derive free > > block count and inode count by

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-07-19 Thread Badari Pulavarty
On Wed, 2007-07-18 at 20:18 -0700, Andrew Morton wrote: On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty [EMAIL PROTECTED] wrote: More statfs() improvements for ext2. ext2 already maintains percpu counters for free blocks and inodes. Derive free block count and inode count by summing

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-07-18 Thread Andrew Morton
On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > More statfs() improvements for ext2. ext2 already maintains > percpu counters for free blocks and inodes. Derive free > block count and inode count by summing up percpu counters, > instead of counting up all the

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-07-18 Thread Andrew Morton
On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty [EMAIL PROTECTED] wrote: More statfs() improvements for ext2. ext2 already maintains percpu counters for free blocks and inodes. Derive free block count and inode count by summing up percpu counters, instead of counting up all the groups in

[PATCH] ext2 statfs improvement for block and inode free count

2007-07-13 Thread Badari Pulavarty
Andrew, Can you include it in -mm ? BTW, this patch is against mainline, won't apply cleanly to -mm, due to other statfs() improvements. Thanks, Badari More statfs() improvements for ext2. ext2 already maintains percpu counters for free blocks and inodes. Derive free block count and inode

[PATCH] ext2 statfs improvement for block and inode free count

2007-07-13 Thread Badari Pulavarty
Andrew, Can you include it in -mm ? BTW, this patch is against mainline, won't apply cleanly to -mm, due to other statfs() improvements. Thanks, Badari More statfs() improvements for ext2. ext2 already maintains percpu counters for free blocks and inodes. Derive free block count and inode