Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-11 Thread Valdis Klētnieks
On Mon, 11 Jan 2021 11:48:32 -0800, Kees Cook said: > On Mon, Jan 11, 2021 at 07:37:19AM -0600, Josh Poimboeuf wrote: > > I think putting the flag in a variable (based on call cc-ifversion) > > should be easy enough, then we can put this little saga behind us and > > pretend it never happened :-)

Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-11 Thread Kees Cook
On Mon, Jan 11, 2021 at 07:37:19AM -0600, Josh Poimboeuf wrote: > On Mon, Jan 11, 2021 at 07:31:17AM -0500, Valdis Klētnieks wrote: > > On Mon, 11 Jan 2021 05:56:59 -0500, I said: > > > > > > It's probably related. I'm just having a hard time understanding why > > > > 4.9 and 5.4 > > > > whine

Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-11 Thread Josh Poimboeuf
On Mon, Jan 11, 2021 at 07:31:17AM -0500, Valdis Klētnieks wrote: > On Mon, 11 Jan 2021 05:56:59 -0500, I said: > > > > It's probably related. I'm just having a hard time understanding why 4.9 > > > and 5.4 > > > whine about the lack of a space, while 8.3 and 11 didn't complain... > > So after

Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-11 Thread Valdis Klētnieks
On Mon, 11 Jan 2021 05:56:59 -0500, I said: > > It's probably related. I'm just having a hard time understanding why 4.9 > > and 5.4 > > whine about the lack of a space, while 8.3 and 11 didn't complain... So after more digging, at least some clarity has surfaced. It looks like it's not a

Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-11 Thread Geert Uytterhoeven
Hi Valdis, On Mon, Jan 11, 2021 at 11:57 AM Valdis Klētnieks wrote: > On Mon, 11 Jan 2021 10:47:23 +0100, Geert Uytterhoeven said: > > I guess this is the cause of the new "warning: invalid suffix on > > literal; C++11 requires a space between literal and string macro > > [-Wliteral-suffix]"

Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-11 Thread Valdis Klētnieks
On Mon, 11 Jan 2021 10:47:23 +0100, Geert Uytterhoeven said: > I guess this is the cause of the new "warning: invalid suffix on > literal; C++11 requires a space between literal and string macro > [-Wliteral-suffix]" with gcc 4.9 or 5.4? Well, we fixed a #error, and picked up a warning. That's

Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-11 Thread Geert Uytterhoeven
Hi Kees, Valdis, On Thu, Jan 7, 2021 at 12:11 AM Kees Cook wrote: > On Sat, 26 Dec 2020 13:21:58 -0500, Valdis Klētnieks wrote: > > Fedora Rawhide has started including gcc 11,and the g++ compiler > > throws a wobbly when it hits scripts/gcc-plugins: > > > > HOSTCXX

Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-06 Thread Kees Cook
On Sat, 26 Dec 2020 13:21:58 -0500, Valdis Klētnieks wrote: > Fedora Rawhide has started including gcc 11,and the g++ compiler > throws a wobbly when it hits scripts/gcc-plugins: > > HOSTCXX scripts/gcc-plugins/latent_entropy_plugin.so > In file included from /usr/include/c++/11/type_traits:35,

Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-05 Thread Josh Poimboeuf
On Sat, Dec 26, 2020 at 01:21:58PM -0500, Valdis Klētnieks wrote: > Fedora Rawhide has started including gcc 11,and the g++ compiler > throws a wobbly when it hits scripts/gcc-plugins: > > HOSTCXX scripts/gcc-plugins/latent_entropy_plugin.so > In file included from

[PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2020-12-26 Thread Valdis Klētnieks
Fedora Rawhide has started including gcc 11,and the g++ compiler throws a wobbly when it hits scripts/gcc-plugins: HOSTCXX scripts/gcc-plugins/latent_entropy_plugin.so In file included from /usr/include/c++/11/type_traits:35, from