Re: [PATCH] genirq: do not mask interrupts by default

2007-03-27 Thread Benjamin Herrenschmidt
On Tue, 2007-03-27 at 09:32 +0200, Ingo Molnar wrote: > * Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > Note that I'm not opposed to the change at all, I think it's a good > > idea, I'm just worried I'm discovering it a bit late and I've seen > > PICs broken in some many colorful ways

Re: [PATCH] genirq: do not mask interrupts by default

2007-03-27 Thread Ingo Molnar
* Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > Note that I'm not opposed to the change at all, I think it's a good > idea, I'm just worried I'm discovering it a bit late and I've seen > PICs broken in some many colorful ways that I'm a bit worried... Oh > well... This change does not

Re: [PATCH] genirq: do not mask interrupts by default

2007-03-27 Thread Ingo Molnar
* Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: Note that I'm not opposed to the change at all, I think it's a good idea, I'm just worried I'm discovering it a bit late and I've seen PICs broken in some many colorful ways that I'm a bit worried... Oh well... This change does not really

Re: [PATCH] genirq: do not mask interrupts by default

2007-03-27 Thread Benjamin Herrenschmidt
On Tue, 2007-03-27 at 09:32 +0200, Ingo Molnar wrote: * Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: Note that I'm not opposed to the change at all, I think it's a good idea, I'm just worried I'm discovering it a bit late and I've seen PICs broken in some many colorful ways that I'm

Re: [PATCH] genirq: do not mask interrupts by default

2007-03-26 Thread Benjamin Herrenschmidt
> I missed that one ... thanks for not telling/CC'ing me and not fixing > powerpc :-( (I know, everybody is supposed to have the bandwidth to read > all of lkml... I don't). > > We need to audit all of our PICs to make sure they can deal with > disabling an already ack'ed interrupt, which isn't

Re: [PATCH] genirq: do not mask interrupts by default

2007-03-26 Thread Benjamin Herrenschmidt
> Parent: 1f2ea0837dbc263ce2a2512c4e73c83df68a6a55 > Author: Ingo Molnar <[EMAIL PROTECTED]> > AuthorDate: Fri Feb 16 01:28:24 2007 -0800 > Committer: Linus Torvalds <[EMAIL PROTECTED]> > CommitDate: Fri Feb 16 08:14:00 2007 -0800 > > [PATCH] genirq: do not mask interrupts by

Re: [PATCH] genirq: do not mask interrupts by default

2007-03-26 Thread Benjamin Herrenschmidt
: 1f2ea0837dbc263ce2a2512c4e73c83df68a6a55 Author: Ingo Molnar [EMAIL PROTECTED] AuthorDate: Fri Feb 16 01:28:24 2007 -0800 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Fri Feb 16 08:14:00 2007 -0800 [PATCH] genirq: do not mask interrupts by default Never mask interrupts immediately upon

Re: [PATCH] genirq: do not mask interrupts by default

2007-03-26 Thread Benjamin Herrenschmidt
I missed that one ... thanks for not telling/CC'ing me and not fixing powerpc :-( (I know, everybody is supposed to have the bandwidth to read all of lkml... I don't). We need to audit all of our PICs to make sure they can deal with disabling an already ack'ed interrupt, which isn't

[patch] genirq: do not mask interrupts by default

2007-01-30 Thread Ingo Molnar
Subject: [patch] genirq: do not mask interrupts by default From: Ingo Molnar <[EMAIL PROTECTED]> never mask interrupts immediately upon request. Disabling interrupts in high-performance codepaths is rare, and on the other hand this change could recover lost edges (or even other types o

[patch] genirq: do not mask interrupts by default

2007-01-30 Thread Ingo Molnar
Subject: [patch] genirq: do not mask interrupts by default From: Ingo Molnar [EMAIL PROTECTED] never mask interrupts immediately upon request. Disabling interrupts in high-performance codepaths is rare, and on the other hand this change could recover lost edges (or even other types of lost