Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On 2018-08-24 12:56, Piotr Król wrote: On 08/03/2018 09:08 PM, Andy Shevchenko wrote: Hi Andy, (...) +#define APU_FCH_ACPI_MMIO_BASE 0xFED8 +#define APU_FCH_GPIO_BASE (APU_FCH_ACPI_MMIO_BASE + 0x1500) Wow! Can we see ACPI tables for these boards? Care to share (via some file share

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On 2018-08-24 12:56, Piotr Król wrote: On 08/03/2018 09:08 PM, Andy Shevchenko wrote: Hi Andy, (...) +#define APU_FCH_ACPI_MMIO_BASE 0xFED8 +#define APU_FCH_GPIO_BASE (APU_FCH_ACPI_MMIO_BASE + 0x1500) Wow! Can we see ACPI tables for these boards? Care to share (via some file share

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On 08/03/2018 09:08 PM, Andy Shevchenko wrote: Hi Andy, (...) >> +#define APU_FCH_ACPI_MMIO_BASE 0xFED8 >> +#define APU_FCH_GPIO_BASE (APU_FCH_ACPI_MMIO_BASE + 0x1500) > > Wow! Can we see ACPI tables for these boards? Care to share (via some > file share service) output of `acpidump

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On 08/03/2018 09:08 PM, Andy Shevchenko wrote: Hi Andy, (...) >> +#define APU_FCH_ACPI_MMIO_BASE 0xFED8 >> +#define APU_FCH_GPIO_BASE (APU_FCH_ACPI_MMIO_BASE + 0x1500) > > Wow! Can we see ACPI tables for these boards? Care to share (via some > file share service) output of `acpidump

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Tue, 2018-08-07 at 13:18 +0200, Florian Eckert wrote: > Hello Andy > > I think this are the information you want to have. > I was rather asking for something like TRM. By schematics, I meant a simplified GPIO buffers and pin control explained on hardware level. Below has nothing to do with

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Tue, 2018-08-07 at 13:18 +0200, Florian Eckert wrote: > Hello Andy > > I think this are the information you want to have. > I was rather asking for something like TRM. By schematics, I meant a simplified GPIO buffers and pin control explained on hardware level. Below has nothing to do with

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On 2018-08-03 21:08, Andy Shevchenko wrote: - APU2/APU3 -> front button reset support - APU3 -> SIM switch support Good. Can we see some specification for those platforms? I think the informations from Christian Lamparter are OK?

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On 2018-08-03 21:08, Andy Shevchenko wrote: - APU2/APU3 -> front button reset support - APU3 -> SIM switch support Good. Can we see some specification for those platforms? I think the informations from Christian Lamparter are OK?

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

Hello Andy I think this are the information you want to have. On 2018-08-04 20:22, Christian Lamparter wrote: As for the APUs. The vendor (PC Engines) happily provides PDFs and schematics for their boards:

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

Hello Andy I think this are the information you want to have. On 2018-08-04 20:22, Christian Lamparter wrote: As for the APUs. The vendor (PC Engines) happily provides PDFs and schematics for their boards:

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Thursday, August 2, 2018 11:30:00 PM CEST Linus Walleij wrote: > On Wed, Aug 1, 2018 at 1:12 PM Florian Eckert wrote: > > > Add a new device driver "gpio-apu" which will now handle the GPIOs on > > APU2 and APU3 devices from PC Engines. > > > > - APU2/APU3 -> front button reset support > > -

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Thursday, August 2, 2018 11:30:00 PM CEST Linus Walleij wrote: > On Wed, Aug 1, 2018 at 1:12 PM Florian Eckert wrote: > > > Add a new device driver "gpio-apu" which will now handle the GPIOs on > > APU2 and APU3 devices from PC Engines. > > > > - APU2/APU3 -> front button reset support > > -

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Wed, Aug 1, 2018 at 2:12 PM, Florian Eckert wrote: Thanks for the patch, my comments below. > Add a new device driver "gpio-apu" which will now handle the GPIOs on > APU2 and APU3 devices from PC Engines. > - APU2/APU3 -> front button reset support > - APU3 -> SIM switch support Good. Can

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Wed, Aug 1, 2018 at 2:12 PM, Florian Eckert wrote: Thanks for the patch, my comments below. > Add a new device driver "gpio-apu" which will now handle the GPIOs on > APU2 and APU3 devices from PC Engines. > - APU2/APU3 -> front button reset support > - APU3 -> SIM switch support Good. Can

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Thu, 2018-08-02 at 23:30 +0200, Linus Walleij wrote: > On Wed, Aug 1, 2018 at 1:12 PM Florian Eckert wrote: [] > > + spinlock_t lock; > > I think checkpatch now mandates that you put in a comment > about what this lock is locking. Please remember that checkpatch doesn't mandate

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Thu, 2018-08-02 at 23:30 +0200, Linus Walleij wrote: > On Wed, Aug 1, 2018 at 1:12 PM Florian Eckert wrote: [] > > + spinlock_t lock; > > I think checkpatch now mandates that you put in a comment > about what this lock is locking. Please remember that checkpatch doesn't mandate

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Wed, Aug 1, 2018 at 1:12 PM Florian Eckert wrote: > Add a new device driver "gpio-apu" which will now handle the GPIOs on > APU2 and APU3 devices from PC Engines. > > - APU2/APU3 -> front button reset support > - APU3 -> SIM switch support > > Signed-off-by: Florian Eckert Hi Florian,

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

On Wed, Aug 1, 2018 at 1:12 PM Florian Eckert wrote: > Add a new device driver "gpio-apu" which will now handle the GPIOs on > APU2 and APU3 devices from PC Engines. > > - APU2/APU3 -> front button reset support > - APU3 -> SIM switch support > > Signed-off-by: Florian Eckert Hi Florian,

[PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

Add a new device driver "gpio-apu" which will now handle the GPIOs on APU2 and APU3 devices from PC Engines. - APU2/APU3 -> front button reset support - APU3 -> SIM switch support Signed-off-by: Florian Eckert --- drivers/gpio/Kconfig| 10 ++ drivers/gpio/Makefile | 1 +

[PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

Add a new device driver "gpio-apu" which will now handle the GPIOs on APU2 and APU3 devices from PC Engines. - APU2/APU3 -> front button reset support - APU3 -> SIM switch support Signed-off-by: Florian Eckert --- drivers/gpio/Kconfig| 10 ++ drivers/gpio/Makefile | 1 +