Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-14 Thread Bin Gao
On Tue, Jun 14, 2016 at 01:09:31PM +0300, Mika Westerberg wrote: > On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote: > > +static const struct platform_device_id pmic_gpio_id_table[] = { > > + { "bxt_wcove_gpio", }, > > +}; > > Do you really need this? > > > + > > +static struct

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-14 Thread Bin Gao
On Tue, Jun 14, 2016 at 01:09:31PM +0300, Mika Westerberg wrote: > On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote: > > +static const struct platform_device_id pmic_gpio_id_table[] = { > > + { "bxt_wcove_gpio", }, > > +}; > > Do you really need this? > > > + > > +static struct

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-14 Thread Mika Westerberg
On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote: > +static const struct platform_device_id pmic_gpio_id_table[] = { > + { "bxt_wcove_gpio", }, > +}; Do you really need this? > + > +static struct platform_driver wcove_gpio_driver = { > + .probe = wcove_gpio_probe, > + .remove

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-14 Thread Mika Westerberg
On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote: > +static const struct platform_device_id pmic_gpio_id_table[] = { > + { "bxt_wcove_gpio", }, > +}; Do you really need this? > + > +static struct platform_driver wcove_gpio_driver = { > + .probe = wcove_gpio_probe, > + .remove

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-13 Thread Bin Gao
On Mon, Jun 13, 2016 at 02:43:16PM +0200, Linus Walleij wrote: > On Sat, Jun 11, 2016 at 8:01 AM, Bin Gao wrote: > > > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > > This driver is based on gpio-crystalcove.c. > > > > Signed-off-by: Ajay

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-13 Thread Bin Gao
On Mon, Jun 13, 2016 at 02:43:16PM +0200, Linus Walleij wrote: > On Sat, Jun 11, 2016 at 8:01 AM, Bin Gao wrote: > > > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > > This driver is based on gpio-crystalcove.c. > > > > Signed-off-by: Ajay Thomas > > Signed-off-by:

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-13 Thread Linus Walleij
On Sat, Jun 11, 2016 at 8:01 AM, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. > > Signed-off-by: Ajay Thomas > Signed-off-by: Bin Gao

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-13 Thread Linus Walleij
On Sat, Jun 11, 2016 at 8:01 AM, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. > > Signed-off-by: Ajay Thomas > Signed-off-by: Bin Gao It is always good to let Mika and Mathias look at new Intel GPIO

[PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-10 Thread Bin Gao
This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- drivers/gpio/Kconfig | 13 ++ drivers/gpio/Makefile

[PATCH] gpio: add Intel WhiskeyCove GPIO driver

2016-06-10 Thread Bin Gao
This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- drivers/gpio/Kconfig | 13 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-wcove.c | 402