Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-24 Thread Linus Walleij
Mostly it seems we are in understanding here, looking forward to the patches... On Thu, Nov 24, 2016 at 5:32 PM, Thierry Reding wrote: > On Thu, Nov 24, 2016 at 04:08:08PM +0100, Linus Walleij wrote: >> I don't understand. Userspace should have no concern about the >>

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-24 Thread Linus Walleij
Mostly it seems we are in understanding here, looking forward to the patches... On Thu, Nov 24, 2016 at 5:32 PM, Thierry Reding wrote: > On Thu, Nov 24, 2016 at 04:08:08PM +0100, Linus Walleij wrote: >> I don't understand. Userspace should have no concern about the >> numberspace. Lines can be

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-24 Thread Thierry Reding
On Thu, Nov 24, 2016 at 04:08:08PM +0100, Linus Walleij wrote: > On Wed, Nov 23, 2016 at 8:40 PM, Thierry Reding > wrote: > > On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: > > >> Everything, all kernel users and all character device users, end up > >>

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-24 Thread Thierry Reding
On Thu, Nov 24, 2016 at 04:08:08PM +0100, Linus Walleij wrote: > On Wed, Nov 23, 2016 at 8:40 PM, Thierry Reding > wrote: > > On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: > > >> Everything, all kernel users and all character device users, end up > >> calling gpiod_request(). >

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-24 Thread Linus Walleij
On Wed, Nov 23, 2016 at 8:40 PM, Thierry Reding wrote: > On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: >> Everything, all kernel users and all character device users, end up >> calling gpiod_request(). > > It looks like I stumbled across the only case

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-24 Thread Linus Walleij
On Wed, Nov 23, 2016 at 8:40 PM, Thierry Reding wrote: > On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: >> Everything, all kernel users and all character device users, end up >> calling gpiod_request(). > > It looks like I stumbled across the only case where this isn't true. >

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-24 Thread Thierry Reding
On Thu, Nov 24, 2016 at 12:06:16PM +0530, Laxman Dewangan wrote: > > On Thursday 24 November 2016 01:10 AM, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: > > > > > > This is already possible and several drivers

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-24 Thread Thierry Reding
On Thu, Nov 24, 2016 at 12:06:16PM +0530, Laxman Dewangan wrote: > > On Thursday 24 November 2016 01:10 AM, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: > > > > > > This is already possible and several drivers

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-23 Thread Laxman Dewangan
On Thursday 24 November 2016 01:10 AM, Thierry Reding wrote: * PGP Signed by an unknown key On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: This is already possible and several drivers are doing this. Everything, all kernel users and all character device users, end up calling

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-23 Thread Laxman Dewangan
On Thursday 24 November 2016 01:10 AM, Thierry Reding wrote: * PGP Signed by an unknown key On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: This is already possible and several drivers are doing this. Everything, all kernel users and all character device users, end up calling

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-23 Thread Thierry Reding
On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: > On Tue, Nov 22, 2016 at 6:30 PM, Thierry Reding > wrote: > > > So I don't really know how to go about merging both. I'll reply to this > > email later with a copy of the patch that I wrote, maybe we can

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-23 Thread Thierry Reding
On Wed, Nov 23, 2016 at 02:25:51PM +0100, Linus Walleij wrote: > On Tue, Nov 22, 2016 at 6:30 PM, Thierry Reding > wrote: > > > So I don't really know how to go about merging both. I'll reply to this > > email later with a copy of the patch that I wrote, maybe we can take it > > from there. > >

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-23 Thread Linus Walleij
On Tue, Nov 22, 2016 at 6:30 PM, Thierry Reding wrote: > So I don't really know how to go about merging both. I'll reply to this > email later with a copy of the patch that I wrote, maybe we can take it > from there. I trust you nVidia people to sort this out. I guess

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-23 Thread Linus Walleij
On Tue, Nov 22, 2016 at 6:30 PM, Thierry Reding wrote: > So I don't really know how to go about merging both. I'll reply to this > email later with a copy of the patch that I wrote, maybe we can take it > from there. I trust you nVidia people to sort this out. I guess in worst case you can

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-22 Thread Thierry Reding
On Tue, Nov 08, 2016 at 12:07:55PM -0700, Stephen Warren wrote: > On 11/02/2016 04:48 AM, Suresh Mangipudi wrote: > > Add GPIO driver for T186 based platforms. > > Adds support for MAIN and AON GPIO's from T186. > > I'm not sure how you/Thierry will approach merging this with the other GPIO >

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-22 Thread Thierry Reding
On Tue, Nov 08, 2016 at 12:07:55PM -0700, Stephen Warren wrote: > On 11/02/2016 04:48 AM, Suresh Mangipudi wrote: > > Add GPIO driver for T186 based platforms. > > Adds support for MAIN and AON GPIO's from T186. > > I'm not sure how you/Thierry will approach merging this with the other GPIO >

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-08 Thread Stephen Warren
On 11/02/2016 04:48 AM, Suresh Mangipudi wrote: Add GPIO driver for T186 based platforms. Adds support for MAIN and AON GPIO's from T186. I'm not sure how you/Thierry will approach merging this with the other GPIO driver he has, but here's a very quick review of this one in case it's useful.

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-08 Thread Stephen Warren
On 11/02/2016 04:48 AM, Suresh Mangipudi wrote: Add GPIO driver for T186 based platforms. Adds support for MAIN and AON GPIO's from T186. I'm not sure how you/Thierry will approach merging this with the other GPIO driver he has, but here's a very quick review of this one in case it's useful.

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-08 Thread Thierry Reding
On Tue, Nov 08, 2016 at 09:49:27AM -0700, Stephen Warren wrote: > On 11/08/2016 08:55 AM, Thierry Reding wrote: > > On Mon, Nov 07, 2016 at 05:42:33PM -0800, Olof Johansson wrote: > > > On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding > > > wrote: > > > > On Mon, Nov 07,

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-08 Thread Thierry Reding
On Tue, Nov 08, 2016 at 09:49:27AM -0700, Stephen Warren wrote: > On 11/08/2016 08:55 AM, Thierry Reding wrote: > > On Mon, Nov 07, 2016 at 05:42:33PM -0800, Olof Johansson wrote: > > > On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding > > > wrote: > > > > On Mon, Nov 07, 2016 at 08:53:37AM +0100,

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-08 Thread Stephen Warren
On 11/08/2016 08:55 AM, Thierry Reding wrote: On Mon, Nov 07, 2016 at 05:42:33PM -0800, Olof Johansson wrote: On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding wrote: On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: On Wed, Nov 2, 2016 at 11:48 AM, Suresh

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-08 Thread Stephen Warren
On 11/08/2016 08:55 AM, Thierry Reding wrote: On Mon, Nov 07, 2016 at 05:42:33PM -0800, Olof Johansson wrote: On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding wrote: On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi wrote: Add

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-08 Thread Thierry Reding
On Mon, Nov 07, 2016 at 05:42:33PM -0800, Olof Johansson wrote: > On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding > wrote: > > On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: > >> On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi >

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-08 Thread Thierry Reding
On Mon, Nov 07, 2016 at 05:42:33PM -0800, Olof Johansson wrote: > On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding > wrote: > > On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: > >> On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi > >> wrote: > >> > >> > Add GPIO driver for T186

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-07 Thread Olof Johansson
On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding wrote: > On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: >> On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi >> wrote: >> >> > Add GPIO driver for T186 based platforms. >> > Adds

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-07 Thread Olof Johansson
On Mon, Nov 7, 2016 at 5:21 AM, Thierry Reding wrote: > On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: >> On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi >> wrote: >> >> > Add GPIO driver for T186 based platforms. >> > Adds support for MAIN and AON GPIO's from T186. >> > >> >

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-07 Thread Thierry Reding
On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: > On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi > wrote: > > > Add GPIO driver for T186 based platforms. > > Adds support for MAIN and AON GPIO's from T186. > > > > Signed-off-by: Suresh Mangipudi

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-07 Thread Thierry Reding
On Mon, Nov 07, 2016 at 08:53:37AM +0100, Linus Walleij wrote: > On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi > wrote: > > > Add GPIO driver for T186 based platforms. > > Adds support for MAIN and AON GPIO's from T186. > > > > Signed-off-by: Suresh Mangipudi > >

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-06 Thread Linus Walleij
On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi wrote: > Add GPIO driver for T186 based platforms. > Adds support for MAIN and AON GPIO's from T186. > > Signed-off-by: Suresh Mangipudi Stephen/Thierry/Alexandre: Can I get your review on this

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-06 Thread Linus Walleij
On Wed, Nov 2, 2016 at 11:48 AM, Suresh Mangipudi wrote: > Add GPIO driver for T186 based platforms. > Adds support for MAIN and AON GPIO's from T186. > > Signed-off-by: Suresh Mangipudi Stephen/Thierry/Alexandre: Can I get your review on this Tegra thing? Yours, Linus Walleij

[PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-02 Thread Suresh Mangipudi
Add GPIO driver for T186 based platforms. Adds support for MAIN and AON GPIO's from T186. Signed-off-by: Suresh Mangipudi --- drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile| 1 + drivers/gpio/gpio-tegra186.c | 647

[PATCH] gpio: tegra186: Add support for T186 GPIO

2016-11-02 Thread Suresh Mangipudi
Add GPIO driver for T186 based platforms. Adds support for MAIN and AON GPIO's from T186. Signed-off-by: Suresh Mangipudi --- drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile| 1 + drivers/gpio/gpio-tegra186.c | 647 +++ 3 files