Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

On Mon, Apr 24, 2017 at 05:58:18AM +0200, Heiko Schocher wrote: > Hello Guenter, Rahul, > > Am 23.04.2017 um 17:43 schrieb Guenter Roeck: > >Hi Rahul, > > > >On 04/23/2017 07:10 AM, Rahul Bedarkar wrote: > >>Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. > >> > >>Signed-off-by: Rahul

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

On Mon, Apr 24, 2017 at 05:58:18AM +0200, Heiko Schocher wrote: > Hello Guenter, Rahul, > > Am 23.04.2017 um 17:43 schrieb Guenter Roeck: > >Hi Rahul, > > > >On 04/23/2017 07:10 AM, Rahul Bedarkar wrote: > >>Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. > >> > >>Signed-off-by: Rahul

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

On Mon, Apr 24, 2017 at 12:19:18PM +0530, Rahul Bedarkar wrote: > Hello Guenter, Heiko, > > On Mon, Apr 24, 2017 at 9:28 AM, Heiko Schocher wrote: > > Hello Guenter, Rahul, > > > > Hmm.. I like this patch too, but have also no idea, what is preffered. > > > > Looking into

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

On Mon, Apr 24, 2017 at 12:19:18PM +0530, Rahul Bedarkar wrote: > Hello Guenter, Heiko, > > On Mon, Apr 24, 2017 at 9:28 AM, Heiko Schocher wrote: > > Hello Guenter, Rahul, > > > > Hmm.. I like this patch too, but have also no idea, what is preffered. > > > > Looking into drivers/hwmon > > > >

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

Hello Guenter, Heiko, On Mon, Apr 24, 2017 at 9:28 AM, Heiko Schocher wrote: > Hello Guenter, Rahul, > > Hmm.. I like this patch too, but have also no idea, what is preffered. > > Looking into drivers/hwmon > > pollux:linux hs [master] $ grep -lr __maybe_unused drivers/hwmon/ >

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

Hello Guenter, Heiko, On Mon, Apr 24, 2017 at 9:28 AM, Heiko Schocher wrote: > Hello Guenter, Rahul, > > Hmm.. I like this patch too, but have also no idea, what is preffered. > > Looking into drivers/hwmon > > pollux:linux hs [master] $ grep -lr __maybe_unused drivers/hwmon/ >

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

Hello Guenter, Rahul, Am 23.04.2017 um 17:43 schrieb Guenter Roeck: Hi Rahul, On 04/23/2017 07:10 AM, Rahul Bedarkar wrote: Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. Signed-off-by: Rahul Bedarkar Thanks a lot for your patch. While I in general prefer

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

Hello Guenter, Rahul, Am 23.04.2017 um 17:43 schrieb Guenter Roeck: Hi Rahul, On 04/23/2017 07:10 AM, Rahul Bedarkar wrote: Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. Signed-off-by: Rahul Bedarkar Thanks a lot for your patch. While I in general prefer code that avoids #ifdef, I

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

Hi Rahul, On 04/23/2017 07:10 AM, Rahul Bedarkar wrote: Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. Signed-off-by: Rahul Bedarkar Thanks a lot for your patch. While I in general prefer code that avoids #ifdef, I have seen patches which do the opposite

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

Hi Rahul, On 04/23/2017 07:10 AM, Rahul Bedarkar wrote: Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. Signed-off-by: Rahul Bedarkar Thanks a lot for your patch. While I in general prefer code that avoids #ifdef, I have seen patches which do the opposite when handling PM code. It

[PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. Signed-off-by: Rahul Bedarkar --- drivers/hwmon/tmp103.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/tmp103.c b/drivers/hwmon/tmp103.c index d0bb28b..7f85b14

[PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. Signed-off-by: Rahul Bedarkar --- drivers/hwmon/tmp103.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/tmp103.c b/drivers/hwmon/tmp103.c index d0bb28b..7f85b14 100644 ---